* [PATCH] snic: don't use GFP_DMA in snic_queue_report_tgt_req
@ 2021-12-22 9:20 Christoph Hellwig
2021-12-23 4:46 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2021-12-22 9:20 UTC (permalink / raw)
To: martin.petersen, kartilak, sebaddel; +Cc: linux-scsi
The driver doesn't express DMA addressing limitation under 32-bits
anywhere else, so remove the spurious GFP_DMA allocation.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/scsi/snic/snic_disc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/snic/snic_disc.c b/drivers/scsi/snic/snic_disc.c
index e9ccfb97773f1..27e98df83b31f 100644
--- a/drivers/scsi/snic/snic_disc.c
+++ b/drivers/scsi/snic/snic_disc.c
@@ -100,7 +100,7 @@ snic_queue_report_tgt_req(struct snic *snic)
SNIC_BUG_ON(ntgts == 0);
buf_len = ntgts * sizeof(struct snic_tgt_id) + SNIC_SG_DESC_ALIGN;
- buf = kzalloc(buf_len, GFP_KERNEL|GFP_DMA);
+ buf = kzalloc(buf_len, GFP_KERNEL);
if (!buf) {
snic_req_free(snic, rqi);
SNIC_HOST_ERR(snic->shost, "Resp Buf Alloc Failed.\n");
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] snic: don't use GFP_DMA in snic_queue_report_tgt_req
2021-12-22 9:20 [PATCH] snic: don't use GFP_DMA in snic_queue_report_tgt_req Christoph Hellwig
@ 2021-12-23 4:46 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2021-12-23 4:46 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: martin.petersen, kartilak, sebaddel, linux-scsi
Christoph,
> The driver doesn't express DMA addressing limitation under 32-bits
> anywhere else, so remove the spurious GFP_DMA allocation.
Applied to 5.17/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-23 4:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-22 9:20 [PATCH] snic: don't use GFP_DMA in snic_queue_report_tgt_req Christoph Hellwig
2021-12-23 4:46 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.