From: kernel test robot <lkp@intel.com>
To: Jeffle Xu <jefflexu@linux.alibaba.com>,
dhowells@redhat.com, linux-cachefs@redhat.com, xiang@kernel.org,
chao@kernel.org, linux-erofs@lists.ozlabs.org
Cc: kbuild-all@lists.01.org, linux-fsdevel@vger.kernel.org,
joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com,
tao.peng@linux.alibaba.com, gerry@linux.alibaba.com
Subject: Re: [PATCH v1 19/23] cachefiles: implement .demand_read() for demand read
Date: Mon, 27 Dec 2021 23:32:21 +0800 [thread overview]
Message-ID: <202112272340.1ho7sEjG-lkp@intel.com> (raw)
In-Reply-To: <20211227125444.21187-20-jefflexu@linux.alibaba.com>
Hi Jeffle,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on dhowells-fs/fscache-next]
[cannot apply to xiang-erofs/dev-test ceph-client/for-linus linus/master v5.16-rc7 next-20211224]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jeffle-Xu/fscache-erofs-fscache-based-demand-read-semantics/20211227-205742
base: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git fscache-next
config: csky-defconfig (https://download.01.org/0day-ci/archive/20211227/202112272340.1ho7sEjG-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/54c300b4598e3f2836d8233681da387fe388cfda
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jeffle-Xu/fscache-erofs-fscache-based-demand-read-semantics/20211227-205742
git checkout 54c300b4598e3f2836d8233681da387fe388cfda
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=csky SHELL=/bin/bash fs/cachefiles/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
fs/cachefiles/io.c:564:5: warning: no previous prototype for 'cachefiles_demand_read' [-Wmissing-prototypes]
564 | int cachefiles_demand_read(struct netfs_cache_resources *cres,
| ^~~~~~~~~~~~~~~~~~~~~~
In function 'cachefiles_alloc_req',
inlined from 'cachefiles_demand_read' at fs/cachefiles/io.c:575:8:
>> fs/cachefiles/io.c:557:9: warning: 'strncpy' specified bound 255 equals destination size [-Wstringop-truncation]
557 | strncpy(req_in->path, object->d_name, sizeof(req_in->path));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/strncpy +557 fs/cachefiles/io.c
541
542 static struct cachefiles_req *cachefiles_alloc_req(struct cachefiles_object *object,
543 loff_t start_pos,
544 size_t len)
545 {
546 struct cachefiles_req *req;
547 struct cachefiles_req_in *req_in;
548
549 req = kzalloc(sizeof(*req), GFP_KERNEL);
550 if (!req)
551 return NULL;
552
553 req_in = &req->req_in;
554
555 req_in->off = start_pos;
556 req_in->len = len;
> 557 strncpy(req_in->path, object->d_name, sizeof(req_in->path));
558
559 init_completion(&req->done);
560
561 return req;
562 }
563
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Jeffle Xu <jefflexu@linux.alibaba.com>,
dhowells@redhat.com, linux-cachefs@redhat.com, xiang@kernel.org,
chao@kernel.org, linux-erofs@lists.ozlabs.org
Cc: kbuild-all@lists.01.org, tao.peng@linux.alibaba.com,
joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com,
linux-fsdevel@vger.kernel.org, gerry@linux.alibaba.com
Subject: Re: [PATCH v1 19/23] cachefiles: implement .demand_read() for demand read
Date: Mon, 27 Dec 2021 23:32:21 +0800 [thread overview]
Message-ID: <202112272340.1ho7sEjG-lkp@intel.com> (raw)
In-Reply-To: <20211227125444.21187-20-jefflexu@linux.alibaba.com>
Hi Jeffle,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on dhowells-fs/fscache-next]
[cannot apply to xiang-erofs/dev-test ceph-client/for-linus linus/master v5.16-rc7 next-20211224]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jeffle-Xu/fscache-erofs-fscache-based-demand-read-semantics/20211227-205742
base: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git fscache-next
config: csky-defconfig (https://download.01.org/0day-ci/archive/20211227/202112272340.1ho7sEjG-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/54c300b4598e3f2836d8233681da387fe388cfda
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jeffle-Xu/fscache-erofs-fscache-based-demand-read-semantics/20211227-205742
git checkout 54c300b4598e3f2836d8233681da387fe388cfda
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=csky SHELL=/bin/bash fs/cachefiles/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
fs/cachefiles/io.c:564:5: warning: no previous prototype for 'cachefiles_demand_read' [-Wmissing-prototypes]
564 | int cachefiles_demand_read(struct netfs_cache_resources *cres,
| ^~~~~~~~~~~~~~~~~~~~~~
In function 'cachefiles_alloc_req',
inlined from 'cachefiles_demand_read' at fs/cachefiles/io.c:575:8:
>> fs/cachefiles/io.c:557:9: warning: 'strncpy' specified bound 255 equals destination size [-Wstringop-truncation]
557 | strncpy(req_in->path, object->d_name, sizeof(req_in->path));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/strncpy +557 fs/cachefiles/io.c
541
542 static struct cachefiles_req *cachefiles_alloc_req(struct cachefiles_object *object,
543 loff_t start_pos,
544 size_t len)
545 {
546 struct cachefiles_req *req;
547 struct cachefiles_req_in *req_in;
548
549 req = kzalloc(sizeof(*req), GFP_KERNEL);
550 if (!req)
551 return NULL;
552
553 req_in = &req->req_in;
554
555 req_in->off = start_pos;
556 req_in->len = len;
> 557 strncpy(req_in->path, object->d_name, sizeof(req_in->path));
558
559 init_completion(&req->done);
560
561 return req;
562 }
563
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v1 19/23] cachefiles: implement .demand_read() for demand read
Date: Mon, 27 Dec 2021 23:32:21 +0800 [thread overview]
Message-ID: <202112272340.1ho7sEjG-lkp@intel.com> (raw)
In-Reply-To: <20211227125444.21187-20-jefflexu@linux.alibaba.com>
[-- Attachment #1: Type: text/plain, Size: 3092 bytes --]
Hi Jeffle,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on dhowells-fs/fscache-next]
[cannot apply to xiang-erofs/dev-test ceph-client/for-linus linus/master v5.16-rc7 next-20211224]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jeffle-Xu/fscache-erofs-fscache-based-demand-read-semantics/20211227-205742
base: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git fscache-next
config: csky-defconfig (https://download.01.org/0day-ci/archive/20211227/202112272340.1ho7sEjG-lkp(a)intel.com/config)
compiler: csky-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/54c300b4598e3f2836d8233681da387fe388cfda
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jeffle-Xu/fscache-erofs-fscache-based-demand-read-semantics/20211227-205742
git checkout 54c300b4598e3f2836d8233681da387fe388cfda
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=csky SHELL=/bin/bash fs/cachefiles/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
fs/cachefiles/io.c:564:5: warning: no previous prototype for 'cachefiles_demand_read' [-Wmissing-prototypes]
564 | int cachefiles_demand_read(struct netfs_cache_resources *cres,
| ^~~~~~~~~~~~~~~~~~~~~~
In function 'cachefiles_alloc_req',
inlined from 'cachefiles_demand_read' at fs/cachefiles/io.c:575:8:
>> fs/cachefiles/io.c:557:9: warning: 'strncpy' specified bound 255 equals destination size [-Wstringop-truncation]
557 | strncpy(req_in->path, object->d_name, sizeof(req_in->path));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/strncpy +557 fs/cachefiles/io.c
541
542 static struct cachefiles_req *cachefiles_alloc_req(struct cachefiles_object *object,
543 loff_t start_pos,
544 size_t len)
545 {
546 struct cachefiles_req *req;
547 struct cachefiles_req_in *req_in;
548
549 req = kzalloc(sizeof(*req), GFP_KERNEL);
550 if (!req)
551 return NULL;
552
553 req_in = &req->req_in;
554
555 req_in->off = start_pos;
556 req_in->len = len;
> 557 strncpy(req_in->path, object->d_name, sizeof(req_in->path));
558
559 init_completion(&req->done);
560
561 return req;
562 }
563
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2021-12-27 15:32 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-27 12:54 [PATCH v1 00/23] fscache,erofs: fscache-based demand-read semantics Jeffle Xu
2021-12-27 12:54 ` Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 01/23] cachefiles: add cachefiles_demand devnode Jeffle Xu
2021-12-27 12:54 ` Jeffle Xu
2021-12-28 2:47 ` Joseph Qi
2021-12-28 2:47 ` Joseph Qi
2021-12-28 12:34 ` JeffleXu
2021-12-28 12:34 ` JeffleXu
2021-12-27 12:54 ` [PATCH v1 02/23] cachefiles: add mode command to distinguish modes Jeffle Xu
2021-12-27 12:54 ` Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 03/23] cachefiles: detect backing file size in demand-read mode Jeffle Xu
2021-12-27 12:54 ` Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 04/23] netfs: make ops->init_rreq() optional Jeffle Xu
2021-12-27 12:54 ` Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 05/23] netfs: add inode parameter to netfs_alloc_read_request() Jeffle Xu
2021-12-27 12:54 ` Jeffle Xu
2022-01-04 14:00 ` Gao Xiang
2022-01-04 14:00 ` Gao Xiang
2022-01-13 3:10 ` [Linux-cachefs] " JeffleXu
2022-01-13 3:10 ` JeffleXu
2022-01-13 12:09 ` Gao Xiang
2022-01-13 12:09 ` Gao Xiang
2021-12-27 12:54 ` [PATCH v1 06/23] erofs: export erofs_map_blocks() Jeffle Xu
2021-12-27 12:54 ` Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 07/23] erofs: add nodev mode Jeffle Xu
2021-12-27 12:54 ` Jeffle Xu
2022-01-04 14:33 ` Gao Xiang
2022-01-04 14:33 ` Gao Xiang
2022-01-04 14:58 ` Gao Xiang
2022-01-04 14:58 ` Gao Xiang
2022-01-05 9:04 ` JeffleXu
2021-12-27 12:54 ` [PATCH v1 08/23] erofs: register global fscache volume Jeffle Xu
2021-12-27 12:54 ` Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 09/23] erofs: add cookie context helper functions Jeffle Xu
2021-12-27 12:54 ` Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 10/23] erofs: add anonymous inode managing page cache of blob file Jeffle Xu
2021-12-27 12:54 ` Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 11/23] erofs: register cookie context for bootstrap Jeffle Xu
2021-12-27 12:54 ` Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 12/23] erofs: implement fscache-based metadata read Jeffle Xu
2021-12-27 12:54 ` Jeffle Xu
2021-12-27 17:07 ` kernel test robot
2021-12-27 17:07 ` kernel test robot
2021-12-27 17:07 ` kernel test robot
2021-12-27 17:17 ` kernel test robot
2021-12-27 17:17 ` kernel test robot
2021-12-27 17:17 ` kernel test robot
2021-12-27 12:54 ` [PATCH v1 13/23] erofs: implement fscache-based data read Jeffle Xu
2021-12-27 12:54 ` Jeffle Xu
2022-01-03 6:32 ` JeffleXu
2022-01-03 6:32 ` JeffleXu
2022-01-04 14:40 ` Gao Xiang
2022-01-04 14:40 ` Gao Xiang
2022-01-05 2:29 ` JeffleXu
2021-12-27 12:54 ` [PATCH v1 14/23] erofs: register cookie context for data blobs Jeffle Xu
2021-12-27 12:54 ` Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 15/23] erofs: implement fscache-based data read " Jeffle Xu
2021-12-27 12:54 ` Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 16/23] erofs: add 'uuid' mount option Jeffle Xu
2021-12-27 12:54 ` Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 17/23] netfs: support on demand read Jeffle Xu
2021-12-27 12:54 ` Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 18/23] cachefiles: use idr tree managing pending " Jeffle Xu
2021-12-27 12:54 ` Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 19/23] cachefiles: implement .demand_read() for " Jeffle Xu
2021-12-27 12:54 ` Jeffle Xu
2021-12-27 15:32 ` kernel test robot [this message]
2021-12-27 15:32 ` kernel test robot
2021-12-27 15:32 ` kernel test robot
2021-12-27 15:36 ` Matthew Wilcox
2021-12-27 15:36 ` Matthew Wilcox
2021-12-28 12:33 ` JeffleXu
2021-12-28 12:33 ` JeffleXu
2022-01-12 9:02 ` JeffleXu
2022-01-12 9:02 ` JeffleXu
2022-01-19 13:20 ` Matthew Wilcox
2022-01-19 13:20 ` Matthew Wilcox
2022-01-20 12:43 ` JeffleXu
2022-01-20 12:43 ` JeffleXu
2021-12-27 15:55 ` kernel test robot
2021-12-27 15:55 ` kernel test robot
2021-12-27 15:55 ` kernel test robot
2021-12-27 12:54 ` [PATCH v1 20/23] cachefiles: implement .poll() " Jeffle Xu
2021-12-27 12:54 ` Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 21/23] cachefiles: implement .read() " Jeffle Xu
2021-12-27 12:54 ` Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 22/23] cachefiles: add done command " Jeffle Xu
2021-12-27 12:54 ` Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 23/23] erofs: support on " Jeffle Xu
2021-12-27 12:54 ` Jeffle Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202112272340.1ho7sEjG-lkp@intel.com \
--to=lkp@intel.com \
--cc=bo.liu@linux.alibaba.com \
--cc=chao@kernel.org \
--cc=dhowells@redhat.com \
--cc=gerry@linux.alibaba.com \
--cc=jefflexu@linux.alibaba.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-cachefs@redhat.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tao.peng@linux.alibaba.com \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.