All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] perl: Enable threading
@ 2021-12-30 21:23 Saul Wold
  2022-01-06 18:22 ` [OE-core] " Khem Raj
  0 siblings, 1 reply; 3+ messages in thread
From: Saul Wold @ 2021-12-30 21:23 UTC (permalink / raw)
  To: openembedded-core; +Cc: Saul Wold

When the tranisiton to perl-cross occured, the threading define
seems to have been missed.  The perl tests for threading where
simply skipped, so there was no direct failures.  This was verified
by running perl ptest before and after the change to see PASS vs SKIP
results of threaded related tests.

Signed-off-by: Saul Wold <saul.wold@windriver.com>
---
 meta/recipes-devtools/perl/perl_5.34.0.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-devtools/perl/perl_5.34.0.bb b/meta/recipes-devtools/perl/perl_5.34.0.bb
index a6ae80f07e1..3306a093692 100644
--- a/meta/recipes-devtools/perl/perl_5.34.0.bb
+++ b/meta/recipes-devtools/perl/perl_5.34.0.bb
@@ -53,6 +53,7 @@ do_configure:class-target() {
     ./configure --prefix=${prefix} --libdir=${libdir} \
     --target=${TARGET_SYS} \
     -Duseshrplib \
+    -Dusethreads \
     -Dsoname=libperl.so.5 \
     -Dvendorprefix=${prefix} \
     -Darchlibexp=${STAGING_LIBDIR}/perl5/${PV}/${TARGET_ARCH}-linux \
-- 
2.31.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [OE-core] [PATCH] perl: Enable threading
  2021-12-30 21:23 [PATCH] perl: Enable threading Saul Wold
@ 2022-01-06 18:22 ` Khem Raj
  2022-01-06 18:39   ` Saul Wold
  0 siblings, 1 reply; 3+ messages in thread
From: Khem Raj @ 2022-01-06 18:22 UTC (permalink / raw)
  To: Saul Wold; +Cc: Patches and discussions about the oe-core layer

On Thu, Dec 30, 2021 at 1:24 PM Saul Wold <Saul.Wold@windriver.com> wrote:
>
> When the tranisiton to perl-cross occured, the threading define
> seems to have been missed.  The perl tests for threading where
> simply skipped, so there was no direct failures.  This was verified
> by running perl ptest before and after the change to see PASS vs SKIP
> results of threaded related tests.
>

Do we need this for perl-native too ? I am seeing failures like below

https://errors.yoctoproject.org/Errors/Details/621556/
https://errors.yoctoproject.org/Errors/Details/621555/

can you take a look ?

> Signed-off-by: Saul Wold <saul.wold@windriver.com>
> ---
>  meta/recipes-devtools/perl/perl_5.34.0.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-devtools/perl/perl_5.34.0.bb b/meta/recipes-devtools/perl/perl_5.34.0.bb
> index a6ae80f07e1..3306a093692 100644
> --- a/meta/recipes-devtools/perl/perl_5.34.0.bb
> +++ b/meta/recipes-devtools/perl/perl_5.34.0.bb
> @@ -53,6 +53,7 @@ do_configure:class-target() {
>      ./configure --prefix=${prefix} --libdir=${libdir} \
>      --target=${TARGET_SYS} \
>      -Duseshrplib \
> +    -Dusethreads \
>      -Dsoname=libperl.so.5 \
>      -Dvendorprefix=${prefix} \
>      -Darchlibexp=${STAGING_LIBDIR}/perl5/${PV}/${TARGET_ARCH}-linux \
> --
> 2.31.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#160066): https://lists.openembedded.org/g/openembedded-core/message/160066
> Mute This Topic: https://lists.openembedded.org/mt/88042607/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [OE-core] [PATCH] perl: Enable threading
  2022-01-06 18:22 ` [OE-core] " Khem Raj
@ 2022-01-06 18:39   ` Saul Wold
  0 siblings, 0 replies; 3+ messages in thread
From: Saul Wold @ 2022-01-06 18:39 UTC (permalink / raw)
  To: Khem Raj; +Cc: Patches and discussions about the oe-core layer



On 1/6/22 10:22, Khem Raj wrote:
> On Thu, Dec 30, 2021 at 1:24 PM Saul Wold <Saul.Wold@windriver.com> wrote:
>>
>> When the tranisiton to perl-cross occured, the threading define
>> seems to have been missed.  The perl tests for threading where
>> simply skipped, so there was no direct failures.  This was verified
>> by running perl ptest before and after the change to see PASS vs SKIP
>> results of threaded related tests.
>>
> 
> Do we need this for perl-native too ? I am seeing failures like below
> 
> https://errors.yoctoproject.org/Errors/Details/621556/
> https://errors.yoctoproject.org/Errors/Details/621555/
> 
> can you take a look ?
> 
Yes, I am looking into it.  RP mentioned it earlier today.

Yes, I guess I just enabled for the target and not native or nativesdk, 
building and testing now.


Sau!

>> Signed-off-by: Saul Wold <saul.wold@windriver.com>
>> ---
>>   meta/recipes-devtools/perl/perl_5.34.0.bb | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/recipes-devtools/perl/perl_5.34.0.bb b/meta/recipes-devtools/perl/perl_5.34.0.bb
>> index a6ae80f07e1..3306a093692 100644
>> --- a/meta/recipes-devtools/perl/perl_5.34.0.bb
>> +++ b/meta/recipes-devtools/perl/perl_5.34.0.bb
>> @@ -53,6 +53,7 @@ do_configure:class-target() {
>>       ./configure --prefix=${prefix} --libdir=${libdir} \
>>       --target=${TARGET_SYS} \
>>       -Duseshrplib \
>> +    -Dusethreads \
>>       -Dsoname=libperl.so.5 \
>>       -Dvendorprefix=${prefix} \
>>       -Darchlibexp=${STAGING_LIBDIR}/perl5/${PV}/${TARGET_ARCH}-linux \
>> --
>> 2.31.1
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#160066): https://lists.openembedded.org/g/openembedded-core/message/160066
>> Mute This Topic: https://lists.openembedded.org/mt/88042607/1997914
>> Group Owner: openembedded-core+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>

-- 
Sau!


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-01-06 18:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-30 21:23 [PATCH] perl: Enable threading Saul Wold
2022-01-06 18:22 ` [OE-core] " Khem Raj
2022-01-06 18:39   ` Saul Wold

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.