All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/pipewire: fix avahi build
@ 2022-01-01 14:26 Fabrice Fontaine
  2022-01-04 16:45 ` Arnout Vandecappelle
  2022-01-26 20:00 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2022-01-01 14:26 UTC (permalink / raw)
  To: buildroot; +Cc: James Hilliard, Fabrice Fontaine

Fix the following build failure raised since commit
27908c6eab768d0b9fd3444a929b3f1b1510da71:

../output-1/build/pipewire-0.3.40/meson.build:348:0: ERROR: Dependency "avahi-client" not found, tried pkgconfig

Fixes:
 - http://autobuild.buildroot.org/results/d1707ad82159aafbddb69c503109bf2e830f0f29

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/pipewire/pipewire.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/pipewire/pipewire.mk b/package/pipewire/pipewire.mk
index efda3ad695..7043745cc1 100644
--- a/package/pipewire/pipewire.mk
+++ b/package/pipewire/pipewire.mk
@@ -82,7 +82,8 @@ else
 PIPEWIRE_CONF_OPTS += -Dalsa=disabled -Dpipewire-alsa=disabled
 endif
 
-ifeq ($(BR2_PACKAGE_AVAHI),y)
+# avahi support needs avahi-client, which needs avahi-daemon and dbus
+ifeq ($(BR2_PACKAGE_AVAHI)$(BR2_PACKAGE_AVAHI_DAEMON)$(BR2_PACKAGE_DBUS),yyy)
 PIPEWIRE_CONF_OPTS += -Davahi=enabled
 PIPEWIRE_DEPENDENCIES += avahi
 else
-- 
2.33.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/pipewire: fix avahi build
  2022-01-01 14:26 [Buildroot] [PATCH 1/1] package/pipewire: fix avahi build Fabrice Fontaine
@ 2022-01-04 16:45 ` Arnout Vandecappelle
  2022-01-26 20:00 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2022-01-04 16:45 UTC (permalink / raw)
  To: Fabrice Fontaine, buildroot; +Cc: James Hilliard



On 01/01/2022 15:26, Fabrice Fontaine wrote:
> Fix the following build failure raised since commit
> 27908c6eab768d0b9fd3444a929b3f1b1510da71:
> 
> ../output-1/build/pipewire-0.3.40/meson.build:348:0: ERROR: Dependency "avahi-client" not found, tried pkgconfig
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/d1707ad82159aafbddb69c503109bf2e830f0f29
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>   package/pipewire/pipewire.mk | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/pipewire/pipewire.mk b/package/pipewire/pipewire.mk
> index efda3ad695..7043745cc1 100644
> --- a/package/pipewire/pipewire.mk
> +++ b/package/pipewire/pipewire.mk
> @@ -82,7 +82,8 @@ else
>   PIPEWIRE_CONF_OPTS += -Dalsa=disabled -Dpipewire-alsa=disabled
>   endif
>   
> -ifeq ($(BR2_PACKAGE_AVAHI),y)
> +# avahi support needs avahi-client, which needs avahi-daemon and dbus
> +ifeq ($(BR2_PACKAGE_AVAHI)$(BR2_PACKAGE_AVAHI_DAEMON)$(BR2_PACKAGE_DBUS),yyy)

  BR2_PACKAGE_AVAHI is redundant with BR2_PACKAGE_AVAHI_DAEMON, but I kept it 
anyway since it's IMHO a little clearer that way.

  Applied to master, thanks.

  Regards,
  Arnout

>   PIPEWIRE_CONF_OPTS += -Davahi=enabled
>   PIPEWIRE_DEPENDENCIES += avahi
>   else
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/pipewire: fix avahi build
  2022-01-01 14:26 [Buildroot] [PATCH 1/1] package/pipewire: fix avahi build Fabrice Fontaine
  2022-01-04 16:45 ` Arnout Vandecappelle
@ 2022-01-26 20:00 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2022-01-26 20:00 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: James Hilliard, buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Fix the following build failure raised since commit
 > 27908c6eab768d0b9fd3444a929b3f1b1510da71:

 > ../output-1/build/pipewire-0.3.40/meson.build:348:0: ERROR: Dependency
 > "avahi-client" not found, tried pkgconfig

 > Fixes:
 >  - http://autobuild.buildroot.org/results/d1707ad82159aafbddb69c503109bf2e830f0f29

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2021.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-01-26 20:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-01 14:26 [Buildroot] [PATCH 1/1] package/pipewire: fix avahi build Fabrice Fontaine
2022-01-04 16:45 ` Arnout Vandecappelle
2022-01-26 20:00 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.