[Buildroot] Patching a BR package makefile

[Buildroot] Patching a BR package makefile

[Jacques Samoun]

[-- Attachment #1.1: Type: text/plain, Size: 525 bytes --]

Hello,

I had to modify a OPENSSH_CONF_OPTS of the openssh.mk package makefile to
solve a known interoperability issue (openssh vs libopenssl). Now the fix
is verified, i would like to create a patch to be applied to this openssh.mk
.

However, while I already did a couple of patches to other packages, they
were always so far applied to the course code of the packages. In
this specific case, I do not know how to make this on the
buildroot/package/<package>.mk file.

Is there a preferred way to do so ?

Regards,
Jacques

[-- Attachment #1.2: Type: text/html, Size: 732 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] Patching a BR package makefile

[Richard Ash]

On Wed, 29 Dec 2021 14:57:54 +0200
Jacques Samoun <jacques.samoun33@gmail.com> wrote:

> I had to modify a OPENSSH_CONF_OPTS of the openssh.mk package
> makefile to solve a known interoperability issue (openssh vs
> libopenssl). Now the fix is verified, i would like to create a patch
> to be applied to this openssh.mk .
> 
> However, while I already did a couple of patches to other packages,
> they were always so far applied to the course code of the packages. In
> this specific case, I do not know how to make this on the
> buildroot/package/<package>.mk file.
> 
> Is there a preferred way to do so ?

As far as I know, there isn't a way to do this within buildroot,
because the buildroot tree is (has to be) immutable by the time
buildroot runs. Put another way you can't patch what effectively
becomes one vast Makefile from within that Makefile without badly
upsetting make!

The only options I have found are:
1. Write a wrapper script to unpack the buildroot tarball and apply
your patches (note you may have problems if your patches change over
time).
2. Have your own fork of buildroot git, and then your own branch from
the relevant release tag with your changes on top. This means you can
rebase your changes with git's help when you want to move to a newer
buildroot. Convenient if the rest of your build is in git and you can
use a git submodule to fetch your forked git automatically.
3. Don't try to modify the buildroot package, create your own
custom-ssh package (copy of buildroot plus your patch) and maintain it
in a buildroot external (see the manual). Could be a pain to keep up to
date in the longer term.

I'm not in any way a buildroot maintainer however!

All of these are good reasons to get patches upstreamed (if possible)
into buildroot!

Richard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] Patching a BR package makefile

[Jacques Samoun]

[-- Attachment #1.1: Type: text/plain, Size: 2131 bytes --]

Hi Richard,
thanks for that.
I think option 3 is the way to go, at least till this openssh/openssl issue
has been fixed, which should happen (there is an PR at openssh already).
Thanks,
Jacques

On Sat, Jan 1, 2022 at 7:37 PM Richard Ash <richard@audacityteam.org> wrote:

> On Wed, 29 Dec 2021 14:57:54 +0200
> Jacques Samoun <jacques.samoun33@gmail.com> wrote:
>
> > I had to modify a OPENSSH_CONF_OPTS of the openssh.mk package
> > makefile to solve a known interoperability issue (openssh vs
> > libopenssl). Now the fix is verified, i would like to create a patch
> > to be applied to this openssh.mk .
> >
> > However, while I already did a couple of patches to other packages,
> > they were always so far applied to the course code of the packages. In
> > this specific case, I do not know how to make this on the
> > buildroot/package/<package>.mk file.
> >
> > Is there a preferred way to do so ?
>
> As far as I know, there isn't a way to do this within buildroot,
> because the buildroot tree is (has to be) immutable by the time
> buildroot runs. Put another way you can't patch what effectively
> becomes one vast Makefile from within that Makefile without badly
> upsetting make!
>
> The only options I have found are:
> 1. Write a wrapper script to unpack the buildroot tarball and apply
> your patches (note you may have problems if your patches change over
> time).
> 2. Have your own fork of buildroot git, and then your own branch from
> the relevant release tag with your changes on top. This means you can
> rebase your changes with git's help when you want to move to a newer
> buildroot. Convenient if the rest of your build is in git and you can
> use a git submodule to fetch your forked git automatically.
> 3. Don't try to modify the buildroot package, create your own
> custom-ssh package (copy of buildroot plus your patch) and maintain it
> in a buildroot external (see the manual). Could be a pain to keep up to
> date in the longer term.
>
> I'm not in any way a buildroot maintainer however!
>
> All of these are good reasons to get patches upstreamed (if possible)
> into buildroot!
>
> Richard
>

[-- Attachment #1.2: Type: text/html, Size: 2844 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot