* [PATCH 1/1] drm: mxsfb: Use dev_err_probe() helper
@ 2022-01-21 9:56 ` Alexander Stein
0 siblings, 0 replies; 4+ messages in thread
From: Alexander Stein @ 2022-01-21 9:56 UTC (permalink / raw)
To: Marek Vasut, Stefan Agner, David Airlie, Daniel Vetter,
Shawn Guo, Sascha Hauer, Fabio Estevam
Cc: Alexander Stein, linux-arm-kernel, dri-devel
Use the dev_err_probe() helper, instead of open-coding the same
operation. This also adds a nice hint in
/sys/kernel/debug/devices_deferred.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Based on next-20220120
drivers/gpu/drm/mxsfb/mxsfb_drv.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
index 86d78634a979..bc0d766d217b 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
@@ -258,8 +258,7 @@ static int mxsfb_load(struct drm_device *drm,
ret = mxsfb_attach_bridge(mxsfb);
if (ret) {
- if (ret != -EPROBE_DEFER)
- dev_err(drm->dev, "Cannot connect bridge: %d\n", ret);
+ dev_err_probe(drm->dev, ret, "Cannot connect bridge\n");
goto err_vblank;
}
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 1/1] drm: mxsfb: Use dev_err_probe() helper
@ 2022-01-21 9:56 ` Alexander Stein
0 siblings, 0 replies; 4+ messages in thread
From: Alexander Stein @ 2022-01-21 9:56 UTC (permalink / raw)
To: Marek Vasut, Stefan Agner, David Airlie, Daniel Vetter,
Shawn Guo, Sascha Hauer, Fabio Estevam
Cc: Alexander Stein, dri-devel, linux-arm-kernel
Use the dev_err_probe() helper, instead of open-coding the same
operation. This also adds a nice hint in
/sys/kernel/debug/devices_deferred.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Based on next-20220120
drivers/gpu/drm/mxsfb/mxsfb_drv.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
index 86d78634a979..bc0d766d217b 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
@@ -258,8 +258,7 @@ static int mxsfb_load(struct drm_device *drm,
ret = mxsfb_attach_bridge(mxsfb);
if (ret) {
- if (ret != -EPROBE_DEFER)
- dev_err(drm->dev, "Cannot connect bridge: %d\n", ret);
+ dev_err_probe(drm->dev, ret, "Cannot connect bridge\n");
goto err_vblank;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] drm: mxsfb: Use dev_err_probe() helper
2022-01-21 9:56 ` Alexander Stein
@ 2022-01-21 13:08 ` Marek Vasut
-1 siblings, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2022-01-21 13:08 UTC (permalink / raw)
To: Alexander Stein, Stefan Agner, David Airlie, Daniel Vetter,
Shawn Guo, Sascha Hauer, Fabio Estevam
Cc: dri-devel, linux-arm-kernel
On 1/21/22 10:56, Alexander Stein wrote:
> Use the dev_err_probe() helper, instead of open-coding the same
> operation. This also adds a nice hint in
> /sys/kernel/debug/devices_deferred.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Reviewed-by: Marek Vasut <marex@denx.de>
Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] drm: mxsfb: Use dev_err_probe() helper
@ 2022-01-21 13:08 ` Marek Vasut
0 siblings, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2022-01-21 13:08 UTC (permalink / raw)
To: Alexander Stein, Stefan Agner, David Airlie, Daniel Vetter,
Shawn Guo, Sascha Hauer, Fabio Estevam
Cc: linux-arm-kernel, dri-devel
On 1/21/22 10:56, Alexander Stein wrote:
> Use the dev_err_probe() helper, instead of open-coding the same
> operation. This also adds a nice hint in
> /sys/kernel/debug/devices_deferred.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Reviewed-by: Marek Vasut <marex@denx.de>
Thanks
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-21 13:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-21 9:56 [PATCH 1/1] drm: mxsfb: Use dev_err_probe() helper Alexander Stein
2022-01-21 9:56 ` Alexander Stein
2022-01-21 13:08 ` Marek Vasut
2022-01-21 13:08 ` Marek Vasut
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.