[PATCH 1/1] efi: correct struct grub_efi_boot_services

[PATCH 1/1] efi: correct struct grub_efi_boot_services

[Heinrich Schuchardt]

The UEFI specification defines that the EFI_BOOT_SERVICES.Exit(() service
may return EFI_SUCCESS or EFI_INVALID_PARAMETER. So it cannot be
__attribute__((noreturn)).

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 include/grub/efi/api.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/grub/efi/api.h b/include/grub/efi/api.h
index 46289878d..5980a7f95 100644
--- a/include/grub/efi/api.h
+++ b/include/grub/efi/api.h
@@ -1267,7 +1267,7 @@ struct grub_efi_boot_services
   (*exit) (grub_efi_handle_t image_handle,
 	   grub_efi_status_t exit_status,
 	   grub_efi_uintn_t exit_data_size,
-	   grub_efi_char16_t *exit_data) __attribute__((noreturn));
+	   grub_efi_char16_t *exit_data);
 
   grub_efi_status_t
   (*unload_image) (grub_efi_handle_t image_handle);
-- 
2.33.1

Re: [PATCH 1/1] efi: correct struct grub_efi_boot_services

[Daniel Kiper]

On Sat, Jan 22, 2022 at 11:27:54AM +0100, Heinrich Schuchardt wrote:
> The UEFI specification defines that the EFI_BOOT_SERVICES.Exit(() service
> may return EFI_SUCCESS or EFI_INVALID_PARAMETER. So it cannot be
> __attribute__((noreturn)).
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>...

Daniel