From: Nathan Chancellor <nathan@kernel.org> To: Peter Zijlstra <peterz@infradead.org>, x86@kernel.org Cc: Andy Lutomirski <luto@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>, Nick Desaulniers <ndesaulniers@google.com>, Masahiro Yamada <masahiroy@kernel.org>, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, llvm@lists.linux.dev, Nathan Chancellor <nathan@kernel.org> Subject: [PATCH 0/2] x86: Avoid CONFIG_X86_X32_ABI=y with llvm-objcopy Date: Mon, 14 Mar 2022 12:48:40 -0700 [thread overview] Message-ID: <20220314194842.3452-1-nathan@kernel.org> (raw) This series disables CONFIG_X86_X32_ABI=y with llvm-objcopy, which has had two outstanding issues, which are further outlined in the second patch: https://github.com/ClangBuiltLinux/linux/issues/514 https://github.com/ClangBuiltLinux/linux/issues/1141 The first patch is from Masahiro, which moves the CONFIG_X86_X32_ABI back into Kconfig proper. It was initially pushed as an RFC: https://lore.kernel.org/r/20210227183910.221873-1-masahiroy@kernel.org/ The conclusion of that thread was that the check was still needed because of the two issues above. However, with the introduction of IBT, specifically commit 41c5ef31ad71 ("x86/ibt: Base IBT bits"), the second issue linked above becomes visible with allmodconfig, which heavily impacts automated testing. The second patch builds on the first by just universally disabling CONFIG_X86_X32_ABI when using llvm-objcopy at configuration time so that neither issue is visible. While it is unlikely that these issues will be fixed in LLVM, this could eventually become a version check. This is based on -tip x86/core and I would like for both patches to go with the IBT changes so that there is no build breakage. Masahiro Yamada (1): x86: Remove toolchain check for X32 ABI capability Nathan Chancellor (1): x86/Kconfig: Do not allow CONFIG_X86_X32_ABI=y with llvm-objcopy arch/x86/Kconfig | 13 +++++++------ arch/x86/Makefile | 16 ---------------- arch/x86/entry/syscalls/Makefile | 2 +- arch/x86/include/asm/syscall_wrapper.h | 6 +++--- arch/x86/include/asm/vdso.h | 2 +- arch/x86/kernel/process_64.c | 2 +- fs/fuse/ioctl.c | 2 +- fs/xfs/xfs_ioctl32.c | 2 +- sound/core/control_compat.c | 16 ++++++++-------- sound/core/pcm_compat.c | 20 ++++++++++---------- 10 files changed, 33 insertions(+), 48 deletions(-) base-commit: f8afc9d88e65d189653f363eacc1f3131216ef7c -- 2.35.1
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <nathan@kernel.org> To: Peter Zijlstra <peterz@infradead.org>, x86@kernel.org Cc: Nathan Chancellor <nathan@kernel.org>, alsa-devel@alsa-project.org, Masahiro Yamada <masahiroy@kernel.org>, llvm@lists.linux.dev, Nick Desaulniers <ndesaulniers@google.com>, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, Andy Lutomirski <luto@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>, linux-fsdevel@vger.kernel.org Subject: [PATCH 0/2] x86: Avoid CONFIG_X86_X32_ABI=y with llvm-objcopy Date: Mon, 14 Mar 2022 12:48:40 -0700 [thread overview] Message-ID: <20220314194842.3452-1-nathan@kernel.org> (raw) This series disables CONFIG_X86_X32_ABI=y with llvm-objcopy, which has had two outstanding issues, which are further outlined in the second patch: https://github.com/ClangBuiltLinux/linux/issues/514 https://github.com/ClangBuiltLinux/linux/issues/1141 The first patch is from Masahiro, which moves the CONFIG_X86_X32_ABI back into Kconfig proper. It was initially pushed as an RFC: https://lore.kernel.org/r/20210227183910.221873-1-masahiroy@kernel.org/ The conclusion of that thread was that the check was still needed because of the two issues above. However, with the introduction of IBT, specifically commit 41c5ef31ad71 ("x86/ibt: Base IBT bits"), the second issue linked above becomes visible with allmodconfig, which heavily impacts automated testing. The second patch builds on the first by just universally disabling CONFIG_X86_X32_ABI when using llvm-objcopy at configuration time so that neither issue is visible. While it is unlikely that these issues will be fixed in LLVM, this could eventually become a version check. This is based on -tip x86/core and I would like for both patches to go with the IBT changes so that there is no build breakage. Masahiro Yamada (1): x86: Remove toolchain check for X32 ABI capability Nathan Chancellor (1): x86/Kconfig: Do not allow CONFIG_X86_X32_ABI=y with llvm-objcopy arch/x86/Kconfig | 13 +++++++------ arch/x86/Makefile | 16 ---------------- arch/x86/entry/syscalls/Makefile | 2 +- arch/x86/include/asm/syscall_wrapper.h | 6 +++--- arch/x86/include/asm/vdso.h | 2 +- arch/x86/kernel/process_64.c | 2 +- fs/fuse/ioctl.c | 2 +- fs/xfs/xfs_ioctl32.c | 2 +- sound/core/control_compat.c | 16 ++++++++-------- sound/core/pcm_compat.c | 20 ++++++++++---------- 10 files changed, 33 insertions(+), 48 deletions(-) base-commit: f8afc9d88e65d189653f363eacc1f3131216ef7c -- 2.35.1
next reply other threads:[~2022-03-14 19:50 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-14 19:48 Nathan Chancellor [this message] 2022-03-14 19:48 ` [PATCH 0/2] x86: Avoid CONFIG_X86_X32_ABI=y with llvm-objcopy Nathan Chancellor 2022-03-14 19:48 ` [PATCH 1/2] x86: Remove toolchain check for X32 ABI capability Nathan Chancellor 2022-03-14 19:48 ` Nathan Chancellor 2022-03-15 10:43 ` [tip: x86/core] " tip-bot2 for Masahiro Yamada 2022-03-14 19:48 ` [PATCH 2/2] x86/Kconfig: Do not allow CONFIG_X86_X32_ABI=y with llvm-objcopy Nathan Chancellor 2022-03-14 19:48 ` Nathan Chancellor 2022-03-15 10:43 ` [tip: x86/core] " tip-bot2 for Nathan Chancellor 2022-03-14 20:13 ` [PATCH 0/2] x86: Avoid " Peter Zijlstra 2022-03-14 20:13 ` Peter Zijlstra
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220314194842.3452-1-nathan@kernel.org \ --to=nathan@kernel.org \ --cc=alsa-devel@alsa-project.org \ --cc=hpa@zytor.com \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-xfs@vger.kernel.org \ --cc=llvm@lists.linux.dev \ --cc=luto@kernel.org \ --cc=masahiroy@kernel.org \ --cc=ndesaulniers@google.com \ --cc=peterz@infradead.org \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.