From: Lee Shawn C <shawn.c.lee@intel.com> To: dri-devel@lists.freedesktop.org Cc: cooper.chiou@intel.com, william.tseng@intel.com, jani.nikula@intel.com, intel-gfx@lists.freedesktop.org, Drew Davenport <ddavenport@chromium.org>, ankit.k.nautiyal@intel.com, Lee Shawn C <shawn.c.lee@intel.com> Subject: [v8 2/5] drm/edid: parse multiple CEA extension block Date: Thu, 17 Mar 2022 20:41:59 +0800 [thread overview] Message-ID: <20220317124202.14189-3-shawn.c.lee@intel.com> (raw) In-Reply-To: <20220317124202.14189-1-shawn.c.lee@intel.com> Try to find and parse more CEA ext blocks if edid->extensions is greater than one. v2: split prvious patch to two. And do CEA block parsing in this one. v3: simplify this patch based on previous change. v4: refine patch v3. v5: revert previous change. And check cea pointer return from drm_find_cea_extension(). If drvier got the same cea pointer then exit this routine. Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjala <ville.syrjala@linux.intel.com> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com> Cc: Drew Davenport <ddavenport@chromium.org> Cc: intel-gfx <intel-gfx@lists.freedesktop.org> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com> --- drivers/gpu/drm/drm_edid.c | 34 +++++++++++++++++++++------------- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 1251226d9284..ef65dd97d700 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -4319,16 +4319,24 @@ static void drm_parse_y420cmdb_bitmap(struct drm_connector *connector, static int add_cea_modes(struct drm_connector *connector, struct edid *edid) { - const u8 *cea, *db, *hdmi = NULL, *video = NULL; - u8 dbl, hdmi_len, video_len = 0; int modes = 0, ext_index = 0; + const u8 *cur_cea = NULL; - cea = drm_find_cea_extension(edid, &ext_index); - if (cea && cea_revision(cea) >= 3) { + for (;;) { + const u8 *cea, *db, *hdmi = NULL, *video = NULL; + u8 dbl, hdmi_len = 0, video_len = 0; int i, start, end; + cea = drm_find_cea_extension(edid, &ext_index); + if (!cea || cea == cur_cea) + break; + cur_cea = cea; + + if (cea_revision(cea) < 3) + continue; + if (cea_db_offsets(cea, &start, &end)) - return 0; + continue; for_each_cea_db(cea, i, start, end) { db = &cea[i]; @@ -4350,15 +4358,15 @@ add_cea_modes(struct drm_connector *connector, struct edid *edid) dbl - 1); } } - } - /* - * We parse the HDMI VSDB after having added the cea modes as we will - * be patching their flags when the sink supports stereo 3D. - */ - if (hdmi) - modes += do_hdmi_vsdb_modes(connector, hdmi, hdmi_len, video, - video_len); + /* + * We parse the HDMI VSDB after having added the cea modes as we will + * be patching their flags when the sink supports stereo 3D. + */ + if (hdmi) + modes += do_hdmi_vsdb_modes(connector, hdmi, hdmi_len, video, + video_len); + } return modes; } -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Lee Shawn C <shawn.c.lee@intel.com> To: dri-devel@lists.freedesktop.org Cc: cooper.chiou@intel.com, william.tseng@intel.com, jani.nikula@intel.com, intel-gfx@lists.freedesktop.org, Drew Davenport <ddavenport@chromium.org> Subject: [Intel-gfx] [v8 2/5] drm/edid: parse multiple CEA extension block Date: Thu, 17 Mar 2022 20:41:59 +0800 [thread overview] Message-ID: <20220317124202.14189-3-shawn.c.lee@intel.com> (raw) In-Reply-To: <20220317124202.14189-1-shawn.c.lee@intel.com> Try to find and parse more CEA ext blocks if edid->extensions is greater than one. v2: split prvious patch to two. And do CEA block parsing in this one. v3: simplify this patch based on previous change. v4: refine patch v3. v5: revert previous change. And check cea pointer return from drm_find_cea_extension(). If drvier got the same cea pointer then exit this routine. Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjala <ville.syrjala@linux.intel.com> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com> Cc: Drew Davenport <ddavenport@chromium.org> Cc: intel-gfx <intel-gfx@lists.freedesktop.org> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com> --- drivers/gpu/drm/drm_edid.c | 34 +++++++++++++++++++++------------- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 1251226d9284..ef65dd97d700 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -4319,16 +4319,24 @@ static void drm_parse_y420cmdb_bitmap(struct drm_connector *connector, static int add_cea_modes(struct drm_connector *connector, struct edid *edid) { - const u8 *cea, *db, *hdmi = NULL, *video = NULL; - u8 dbl, hdmi_len, video_len = 0; int modes = 0, ext_index = 0; + const u8 *cur_cea = NULL; - cea = drm_find_cea_extension(edid, &ext_index); - if (cea && cea_revision(cea) >= 3) { + for (;;) { + const u8 *cea, *db, *hdmi = NULL, *video = NULL; + u8 dbl, hdmi_len = 0, video_len = 0; int i, start, end; + cea = drm_find_cea_extension(edid, &ext_index); + if (!cea || cea == cur_cea) + break; + cur_cea = cea; + + if (cea_revision(cea) < 3) + continue; + if (cea_db_offsets(cea, &start, &end)) - return 0; + continue; for_each_cea_db(cea, i, start, end) { db = &cea[i]; @@ -4350,15 +4358,15 @@ add_cea_modes(struct drm_connector *connector, struct edid *edid) dbl - 1); } } - } - /* - * We parse the HDMI VSDB after having added the cea modes as we will - * be patching their flags when the sink supports stereo 3D. - */ - if (hdmi) - modes += do_hdmi_vsdb_modes(connector, hdmi, hdmi_len, video, - video_len); + /* + * We parse the HDMI VSDB after having added the cea modes as we will + * be patching their flags when the sink supports stereo 3D. + */ + if (hdmi) + modes += do_hdmi_vsdb_modes(connector, hdmi, hdmi_len, video, + video_len); + } return modes; } -- 2.17.1
next prev parent reply other threads:[~2022-03-17 12:28 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-17 12:41 [v8 0/5] enhanced edid driver compatibility Lee Shawn C 2022-03-17 12:41 ` [Intel-gfx] " Lee Shawn C 2022-03-17 12:41 ` [v8 1/5] drm/edid: seek for available CEA block from specific EDID block index Lee Shawn C 2022-03-17 12:41 ` [Intel-gfx] " Lee Shawn C 2022-03-17 12:41 ` Lee Shawn C [this message] 2022-03-17 12:41 ` [Intel-gfx] [v8 2/5] drm/edid: parse multiple CEA extension block Lee Shawn C 2022-03-17 12:42 ` [v8 3/5] drm/edid: read HF-EEODB ext block Lee Shawn C 2022-03-17 12:42 ` [Intel-gfx] " Lee Shawn C 2022-03-23 10:11 ` Jani Nikula 2022-03-23 10:11 ` [Intel-gfx] " Jani Nikula 2022-03-23 12:02 ` Jani Nikula 2022-03-23 12:02 ` [Intel-gfx] " Jani Nikula 2022-03-23 12:04 ` Simon Ser 2022-03-23 12:04 ` [Intel-gfx] " Simon Ser 2022-03-23 12:14 ` Jani Nikula 2022-03-23 12:14 ` [Intel-gfx] " Jani Nikula 2022-03-23 14:26 ` Ville Syrjälä 2022-03-23 14:26 ` [Intel-gfx] " Ville Syrjälä 2022-03-17 12:42 ` [v8 4/5] drm/edid: parse HF-EEODB CEA extension block Lee Shawn C 2022-03-17 12:42 ` [Intel-gfx] " Lee Shawn C 2022-03-17 12:42 ` [v8 5/5] drm/edid: check for HF-SCDB block Lee Shawn C 2022-03-17 12:42 ` [Intel-gfx] " Lee Shawn C 2022-03-17 12:53 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for enhanced edid driver compatibility (rev4) Patchwork 2022-03-17 12:55 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2022-03-17 13:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2022-03-17 15:05 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220317124202.14189-3-shawn.c.lee@intel.com \ --to=shawn.c.lee@intel.com \ --cc=ankit.k.nautiyal@intel.com \ --cc=cooper.chiou@intel.com \ --cc=ddavenport@chromium.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jani.nikula@intel.com \ --cc=william.tseng@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.