[virtio-comment] [PATCH v3] vsock: add documentation about len header field

[virtio-comment] [PATCH v3] vsock: add documentation about len header field

[Laura Loghin]

Signed-off-by: Laura Loghin <lauralg@amazon.com>
---
 virtio-vsock.tex | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/virtio-vsock.tex b/virtio-vsock.tex
index d79984d..1d6579b 100644
--- a/virtio-vsock.tex
+++ b/virtio-vsock.tex
@@ -107,6 +107,11 @@ \subsection{Device Operation}\label{sec:Device Types / Socket Device / Device Op
 #define VIRTIO_VSOCK_OP_CREDIT_REQUEST 7
 \end{lstlisting}
 
+\field{len} is the size of the payload, in bytes. However, the driver may
+provide buffer(s) for the payload that have a total size longer than
+\field{len}, in which case only the first \field{len} bytes will be used for
+the actual data.
+
 \subsubsection{Virtqueue Flow Control}\label{sec:Device Types / Socket Device / Device Operation / Virtqueue Flow Control}
 
 The tx virtqueue carries packets initiated by applications and replies to
-- 
2.17.1




Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

Re: [virtio-comment] [PATCH v3] vsock: add documentation about len header field

[Stefano Garzarella]

On Thu, Apr 07, 2022 at 11:13:30AM +0300, Laura Loghin wrote:
>Signed-off-by: Laura Loghin <lauralg@amazon.com>
>---
> virtio-vsock.tex | 5 +++++
> 1 file changed, 5 insertions(+)

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

>
>diff --git a/virtio-vsock.tex b/virtio-vsock.tex
>index d79984d..1d6579b 100644
>--- a/virtio-vsock.tex
>+++ b/virtio-vsock.tex
>@@ -107,6 +107,11 @@ \subsection{Device Operation}\label{sec:Device Types / Socket Device / Device Op
> #define VIRTIO_VSOCK_OP_CREDIT_REQUEST 7
> \end{lstlisting}
>
>+\field{len} is the size of the payload, in bytes. However, the driver may
>+provide buffer(s) for the payload that have a total size longer than
>+\field{len}, in which case only the first \field{len} bytes will be used for
>+the actual data.
>+
> \subsubsection{Virtqueue Flow Control}\label{sec:Device Types / Socket Device / Device Operation / Virtqueue Flow Control}
>
> The tx virtqueue carries packets initiated by applications and replies to
>-- 
>2.17.1
>
>
>
>
>Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.
>
>
>This publicly archived list offers a means to provide input to the
>OASIS Virtual I/O Device (VIRTIO) TC.
>
>In order to verify user consent to the Feedback License terms and
>to minimize spam in the list archive, subscription is required
>before posting.
>
>Subscribe: virtio-comment-subscribe@lists.oasis-open.org
>Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
>List help: virtio-comment-help@lists.oasis-open.org
>List archive: https://lists.oasis-open.org/archives/virtio-comment/
>Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
>List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
>Committee: https://www.oasis-open.org/committees/virtio/
>Join OASIS: https://www.oasis-open.org/join/
>


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

Re: [virtio-comment] [PATCH v3] vsock: add documentation about len header field

[Cornelia Huck]

On Thu, Apr 07 2022, Laura Loghin <lauralg@amazon.com> wrote:

> Signed-off-by: Laura Loghin <lauralg@amazon.com>
> ---
>  virtio-vsock.tex | 5 +++++
>  1 file changed, 5 insertions(+)

Reviewed-by: Cornelia Huck <cohuck@redhat.com>

I guess that needs an issue to be included in 1.3?


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

Re: [virtio-comment] [PATCH v3] vsock: add documentation about len header field

[Laura Loghin]

[-- Attachment #1: Type: text/plain, Size: 1591 bytes --]

On 4/11/22 16:53, Cornelia Huck wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
>
>
>
> On Thu, Apr 07 2022, Laura Loghin<lauralg@amazon.com>  wrote:
>
>> Signed-off-by: Laura Loghin<lauralg@amazon.com>
>> ---
>>   virtio-vsock.tex | 5 +++++
>>   1 file changed, 5 insertions(+)
> Reviewed-by: Cornelia Huck<cohuck@redhat.com>
>
> I guess that needs an issue to be included in 1.3?

I already openedhttps://github.com/oasis-tcs/virtio-spec/issues/137, is there anything else I should do?

Laura

>
>
> This publicly archived list offers a means to provide input to the
> OASIS Virtual I/O Device (VIRTIO) TC.
>
> In order to verify user consent to the Feedback License terms and
> to minimize spam in the list archive, subscription is required
> before posting.
>
> Subscribe:virtio-comment-subscribe@lists.oasis-open.org
> Unsubscribe:virtio-comment-unsubscribe@lists.oasis-open.org
> List help:virtio-comment-help@lists.oasis-open.org
> List archive:https://lists.oasis-open.org/archives/virtio-comment/
> Feedback License:https://www.oasis-open.org/who/ipr/feedback_license.pdf
> List Guidelines:https://www.oasis-open.org/policies-guidelines/mailing-lists
> Committee:https://www.oasis-open.org/committees/virtio/
> Join OASIS:https://www.oasis-open.org/join/
>



Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.

[-- Attachment #2: Type: text/html, Size: 3284 bytes --]

Re: [virtio-comment] [PATCH v3] vsock: add documentation about len header field

[Cornelia Huck]

On Mon, Apr 11 2022, Laura Loghin <lauralg@amazon.com> wrote:

> On 4/11/22 16:53, Cornelia Huck wrote:
>> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
>>
>>
>>
>> On Thu, Apr 07 2022, Laura Loghin<lauralg@amazon.com>  wrote:
>>
>>> Signed-off-by: Laura Loghin<lauralg@amazon.com>
>>> ---
>>>   virtio-vsock.tex | 5 +++++
>>>   1 file changed, 5 insertions(+)
>> Reviewed-by: Cornelia Huck<cohuck@redhat.com>
>>
>> I guess that needs an issue to be included in 1.3?
>
> I already openedhttps://github.com/oasis-tcs/virtio-spec/issues/137, is there anything else I should do?

The patch should have

Fixes: https://github.com/oasis-tcs/virtio-spec/issues/137

in it (no need to resend, we can include that before pushing as long as
it sits in a reply to the mail); also, please update the issue to point
to the v3 patch.

[We still need to open up the 1.3 branch after some editorial stuff has
been done; then we can hopefully flush the queue of outstanding issues.]


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

Re: [virtio-comment] [PATCH v3] vsock: add documentation about len header field

[Laura Loghin]

[-- Attachment #1: Type: text/plain, Size: 2371 bytes --]

On 4/11/22 17:32, Cornelia Huck wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
>
>
>
> On Mon, Apr 11 2022, Laura Loghin<lauralg@amazon.com>  wrote:
>
>> On 4/11/22 16:53, Cornelia Huck wrote:
>>> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
>>>
>>>
>>>
>>> On Thu, Apr 07 2022, Laura Loghin<lauralg@amazon.com>   wrote:
>>>
>>>> Signed-off-by: Laura Loghin<lauralg@amazon.com>
>>>> ---
>>>>    virtio-vsock.tex | 5 +++++
>>>>    1 file changed, 5 insertions(+)
>>> Reviewed-by: Cornelia Huck<cohuck@redhat.com>
>>>
>>> I guess that needs an issue to be included in 1.3?
>> I already openedhttps://github.com/oasis-tcs/virtio-spec/issues/137, is there anything else I should do?
> The patch should have
>
> Fixes:https://github.com/oasis-tcs/virtio-spec/issues/137
>
> in it (no need to resend, we can include that before pushing as long as
> it sits in a reply to the mail); also, please update the issue to point
> to the v3 patch.

I updated the link in the issue. Thanks for the guidance!

Laura

>
> [We still need to open up the 1.3 branch after some editorial stuff has
> been done; then we can hopefully flush the queue of outstanding issues.]
>
>
> This publicly archived list offers a means to provide input to the
> OASIS Virtual I/O Device (VIRTIO) TC.
>
> In order to verify user consent to the Feedback License terms and
> to minimize spam in the list archive, subscription is required
> before posting.
>
> Subscribe:virtio-comment-subscribe@lists.oasis-open.org
> Unsubscribe:virtio-comment-unsubscribe@lists.oasis-open.org
> List help:virtio-comment-help@lists.oasis-open.org
> List archive:https://lists.oasis-open.org/archives/virtio-comment/
> Feedback License:https://www.oasis-open.org/who/ipr/feedback_license.pdf
> List Guidelines:https://www.oasis-open.org/policies-guidelines/mailing-lists
> Committee:https://www.oasis-open.org/committees/virtio/
> Join OASIS:https://www.oasis-open.org/join/
>



Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.

[-- Attachment #2: Type: text/html, Size: 4407 bytes --]