[PATCH] misc: atsha204a: Fix big endian support

[PATCH] misc: atsha204a: Fix big endian support

[Pali Rohár]

Callers of function atsha204a_crc16() expect to return value in host cpu
endianity. So remove cpu_to_le16() conversion.

Signed-off-by: Pali Rohár <pali@kernel.org>
---
 drivers/misc/atsha204a-i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/atsha204a-i2c.c b/drivers/misc/atsha204a-i2c.c
index b89463babb56..63fe541dade3 100644
--- a/drivers/misc/atsha204a-i2c.c
+++ b/drivers/misc/atsha204a-i2c.c
@@ -146,7 +146,7 @@ static u16 atsha204a_crc16(const u8 *buffer, size_t len)
 	while (len--)
 		crc = crc16_byte(crc, *buffer++);
 
-	return cpu_to_le16(crc);
+	return crc;
 }
 
 static int atsha204a_send(struct udevice *dev, const u8 *buf, u8 len)
-- 
2.20.1

Re: [PATCH] misc: atsha204a: Fix big endian support

[Stefan Roese]

On 4/3/22 00:36, Pali Rohár wrote:
> Callers of function atsha204a_crc16() expect to return value in host cpu
> endianity. So remove cpu_to_le16() conversion.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   drivers/misc/atsha204a-i2c.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/atsha204a-i2c.c b/drivers/misc/atsha204a-i2c.c
> index b89463babb56..63fe541dade3 100644
> --- a/drivers/misc/atsha204a-i2c.c
> +++ b/drivers/misc/atsha204a-i2c.c
> @@ -146,7 +146,7 @@ static u16 atsha204a_crc16(const u8 *buffer, size_t len)
>   	while (len--)
>   		crc = crc16_byte(crc, *buffer++);
>   
> -	return cpu_to_le16(crc);
> +	return crc;
>   }
>   
>   static int atsha204a_send(struct udevice *dev, const u8 *buf, u8 len)

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

Re: [PATCH] misc: atsha204a: Fix big endian support

[Marek Behún]

On Sun,  3 Apr 2022 00:36:34 +0200
Pali Rohár <pali@kernel.org> wrote:

> Callers of function atsha204a_crc16() expect to return value in host cpu
> endianity. So remove cpu_to_le16() conversion.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
>  drivers/misc/atsha204a-i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/atsha204a-i2c.c b/drivers/misc/atsha204a-i2c.c
> index b89463babb56..63fe541dade3 100644
> --- a/drivers/misc/atsha204a-i2c.c
> +++ b/drivers/misc/atsha204a-i2c.c
> @@ -146,7 +146,7 @@ static u16 atsha204a_crc16(const u8 *buffer, size_t len)
>  	while (len--)
>  		crc = crc16_byte(crc, *buffer++);
>  
> -	return cpu_to_le16(crc);
> +	return crc;
>  }
>  
>  static int atsha204a_send(struct udevice *dev, const u8 *buf, u8 len)

Reviewed-by: Marek Behún <marek.behun@nic.cz>

Re: [PATCH] misc: atsha204a: Fix big endian support

[Pali Rohár]

On Monday 04 April 2022 09:43:21 Stefan Roese wrote:
> On 4/3/22 00:36, Pali Rohár wrote:
> > Callers of function atsha204a_crc16() expect to return value in host cpu
> > endianity. So remove cpu_to_le16() conversion.
> > 
> > Signed-off-by: Pali Rohár <pali@kernel.org>
> 
> Reviewed-by: Stefan Roese <sr@denx.de>

Hello Stefan! Would you or somebody else take this patch?

Because I have some other u-boot generic patches which touches this
driver and I'm waiting until this simple change would be merged first.

> Thanks,
> Stefan
> 
> > ---
> >   drivers/misc/atsha204a-i2c.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/misc/atsha204a-i2c.c b/drivers/misc/atsha204a-i2c.c
> > index b89463babb56..63fe541dade3 100644
> > --- a/drivers/misc/atsha204a-i2c.c
> > +++ b/drivers/misc/atsha204a-i2c.c
> > @@ -146,7 +146,7 @@ static u16 atsha204a_crc16(const u8 *buffer, size_t len)
> >   	while (len--)
> >   		crc = crc16_byte(crc, *buffer++);
> > -	return cpu_to_le16(crc);
> > +	return crc;
> >   }
> >   static int atsha204a_send(struct udevice *dev, const u8 *buf, u8 len)
> 
> Viele Grüße,
> Stefan Roese
> 
> -- 
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

Re: [PATCH] misc: atsha204a: Fix big endian support

[Stefan Roese]

Added Tom to To...

On 4/7/22 10:29, Pali Rohár wrote:
> On Monday 04 April 2022 09:43:21 Stefan Roese wrote:
>> On 4/3/22 00:36, Pali Rohár wrote:
>>> Callers of function atsha204a_crc16() expect to return value in host cpu
>>> endianity. So remove cpu_to_le16() conversion.
>>>
>>> Signed-off-by: Pali Rohár <pali@kernel.org>
>>
>> Reviewed-by: Stefan Roese <sr@denx.de>
> 
> Hello Stefan! Would you or somebody else take this patch?
> 
> Because I have some other u-boot generic patches which touches this
> driver and I'm waiting until this simple change would be merged first.

In general I could do this. But I'm leaving for a vacation in a few days
and I'm not sure, if I can squeeze enough "free time" to handle my
"U-Boot work".

Tom, could you please pull this patch directly?

Thanks,
Stefan

> 
>> Thanks,
>> Stefan
>>
>>> ---
>>>    drivers/misc/atsha204a-i2c.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/misc/atsha204a-i2c.c b/drivers/misc/atsha204a-i2c.c
>>> index b89463babb56..63fe541dade3 100644
>>> --- a/drivers/misc/atsha204a-i2c.c
>>> +++ b/drivers/misc/atsha204a-i2c.c
>>> @@ -146,7 +146,7 @@ static u16 atsha204a_crc16(const u8 *buffer, size_t len)
>>>    	while (len--)
>>>    		crc = crc16_byte(crc, *buffer++);
>>> -	return cpu_to_le16(crc);
>>> +	return crc;
>>>    }
>>>    static int atsha204a_send(struct udevice *dev, const u8 *buf, u8 len)
>>
>> Viele Grüße,
>> Stefan Roese
>>
>> -- 
>> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
>> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>> Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

Re: [PATCH] misc: atsha204a: Fix big endian support

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 989 bytes --]

On Thu, Apr 07, 2022 at 03:31:25PM +0200, Stefan Roese wrote:

> Added Tom to To...
> 
> On 4/7/22 10:29, Pali Rohár wrote:
> > On Monday 04 April 2022 09:43:21 Stefan Roese wrote:
> > > On 4/3/22 00:36, Pali Rohár wrote:
> > > > Callers of function atsha204a_crc16() expect to return value in host cpu
> > > > endianity. So remove cpu_to_le16() conversion.
> > > > 
> > > > Signed-off-by: Pali Rohár <pali@kernel.org>
> > > 
> > > Reviewed-by: Stefan Roese <sr@denx.de>
> > 
> > Hello Stefan! Would you or somebody else take this patch?
> > 
> > Because I have some other u-boot generic patches which touches this
> > driver and I'm waiting until this simple change would be merged first.
> 
> In general I could do this. But I'm leaving for a vacation in a few days
> and I'm not sure, if I can squeeze enough "free time" to handle my
> "U-Boot work".
> 
> Tom, could you please pull this patch directly?

OK, I'll assign it to myself in patchwork.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: [PATCH] misc: atsha204a: Fix big endian support

[Pali Rohár]

On Thursday 07 April 2022 09:47:09 Tom Rini wrote:
> On Thu, Apr 07, 2022 at 03:31:25PM +0200, Stefan Roese wrote:
> 
> > Added Tom to To...
> > 
> > On 4/7/22 10:29, Pali Rohár wrote:
> > > On Monday 04 April 2022 09:43:21 Stefan Roese wrote:
> > > > On 4/3/22 00:36, Pali Rohár wrote:
> > > > > Callers of function atsha204a_crc16() expect to return value in host cpu
> > > > > endianity. So remove cpu_to_le16() conversion.
> > > > > 
> > > > > Signed-off-by: Pali Rohár <pali@kernel.org>
> > > > 
> > > > Reviewed-by: Stefan Roese <sr@denx.de>
> > > 
> > > Hello Stefan! Would you or somebody else take this patch?
> > > 
> > > Because I have some other u-boot generic patches which touches this
> > > driver and I'm waiting until this simple change would be merged first.
> > 
> > In general I could do this. But I'm leaving for a vacation in a few days
> > and I'm not sure, if I can squeeze enough "free time" to handle my
> > "U-Boot work".
> > 
> > Tom, could you please pull this patch directly?
> 
> OK, I'll assign it to myself in patchwork.
> 
> -- 
> Tom

I sent crc16 patch series which depends on this particular patch:
https://patchwork.ozlabs.org/project/uboot/list/?series=294691&state=*

Re: [PATCH] misc: atsha204a: Fix big endian support

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

On Sun, Apr 03, 2022 at 12:36:34AM +0200, Pali Rohár wrote:

> Callers of function atsha204a_crc16() expect to return value in host cpu
> endianity. So remove cpu_to_le16() conversion.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Reviewed-by: Stefan Roese <sr@denx.de>
> Reviewed-by: Marek Behún <marek.behun@nic.cz>

Applied to u-boot/master, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]