* tools/image-host.c build error
@ 2022-04-19 19:02 Mark Kettenis
2022-04-19 19:05 ` Tom Rini
0 siblings, 1 reply; 2+ messages in thread
From: Mark Kettenis @ 2022-04-19 19:02 UTC (permalink / raw)
To: Philippe Reynes; +Cc: u-boot, sjg, trini
Hello Philippe,
commit 6e052d1cbafbedbfba73070da483111f2ae68e5a broke building u-boot
on OpenBSD:
tools/image-host.c:1208:10: error: use of undeclared identifier 'ENODATA'
The problem here is that ENODATA isn't in POSIX proper (it is part of
the obsolete XSI STREAMS option so typically absent on systems with
BSD heritage). So ENODATA should not be used in the host tools that
are part of U-Boot. I would simply replace it with EINVAL, but maybe
you have a different opinion.
I can send a proper patch if so desired.
Thanks,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: tools/image-host.c build error
2022-04-19 19:02 tools/image-host.c build error Mark Kettenis
@ 2022-04-19 19:05 ` Tom Rini
0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2022-04-19 19:05 UTC (permalink / raw)
To: Mark Kettenis; +Cc: Philippe Reynes, u-boot, sjg
[-- Attachment #1: Type: text/plain, Size: 765 bytes --]
On Tue, Apr 19, 2022 at 09:02:14PM +0200, Mark Kettenis wrote:
> Hello Philippe,
>
> commit 6e052d1cbafbedbfba73070da483111f2ae68e5a broke building u-boot
> on OpenBSD:
>
> tools/image-host.c:1208:10: error: use of undeclared identifier 'ENODATA'
>
> The problem here is that ENODATA isn't in POSIX proper (it is part of
> the obsolete XSI STREAMS option so typically absent on systems with
> BSD heritage). So ENODATA should not be used in the host tools that
> are part of U-Boot. I would simply replace it with EINVAL, but maybe
> you have a different opinion.
>
> I can send a proper patch if so desired.
Please do. Sadly, I don't see BSD host options in Azure, which is where
we have our Windows/macOS build tests done.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-19 19:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-19 19:02 tools/image-host.c build error Mark Kettenis
2022-04-19 19:05 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.