drivers/net/dsa/mt7530.c:1857:17: warning: Local variable 'irq' shadows outer argument [shadowArgument]

* drivers/net/dsa/mt7530.c:1857:17: warning: Local variable 'irq' shadows outer argument [shadowArgument]
@ 2022-04-21  6:42 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-04-21  6:42 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 7434 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: DENG Qingfang <dqfext@gmail.com>
CC: Andrew Lunn <andrew@lunn.ch>
CC: Florian Fainelli <f.fainelli@gmail.com>
CC: Vladimir Oltean <olteanv@gmail.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   b253435746d9a4a701b5f09211b9c14d3370d0da
commit: ba751e28d44255744a30190faad0ca09b455c44d net: dsa: mt7530: add interrupt support
date:   11 months ago
:::::: branch date: 2 hours ago
:::::: commit date: 11 months ago
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (cppcheck warning):
        # apt-get install cppcheck
        git checkout ba751e28d44255744a30190faad0ca09b455c44d
        cppcheck --quiet --enable=style,performance,portability --template=gcc FILE

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


cppcheck warnings: (new ones prefixed by >>)
>> net/ipv4/af_inet.c:484:8: warning: Redundant assignment of 'tb_id' to itself. [selfAssignment]
    tb_id = l3mdev_fib_table_by_index(net, sk->sk_bound_dev_if) ? : tb_id;
          ^

cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

>> net/ipv4/tcp_bpf.c:454:22: warning: Parameter 'base' can be declared with const [constParameter]
          struct proto *base)
                        ^
--
>> drivers/net/dsa/mt7530.c:1857:17: warning: Local variable 'irq' shadows outer argument [shadowArgument]
      unsigned int irq;
                   ^
   drivers/net/dsa/mt7530.c:1843:26: note: Shadowed declaration
   mt7530_irq_thread_fn(int irq, void *dev_id)
                            ^
   drivers/net/dsa/mt7530.c:1857:17: note: Shadow variable
      unsigned int irq;
                   ^
   drivers/net/dsa/mt7530.c:1199:23: warning: Parameter 'bridge' can be declared with const [constParameter]
      struct net_device *bridge)
                         ^
   drivers/net/dsa/mt7530.c:1305:24: warning: Parameter 'bridge' can be declared with const [constParameter]
       struct net_device *bridge)
                          ^
>> drivers/net/dsa/mt7530.c:1009:31: warning: Signed integer overflow for expression '((~0)&0xff)<<24'. [integerOverflow]
    mt7530_rmw(priv, MT7530_MFC, BC_FFP_MASK | UNM_FFP_MASK | UNU_FFP_MASK,
                                 ^
--
>> net/ipv4/fib_trie.c:991:11: warning: Uninitialized variable: fa->fa_slen [uninitvar]
     if (fa->fa_slen < slen)
             ^
   net/ipv4/fib_trie.c:987:6: note: Assuming condition is false
    if (!fah)
        ^
   net/ipv4/fib_trie.c:991:11: note: Uninitialized variable: fa->fa_slen
     if (fa->fa_slen < slen)
             ^
>> net/ipv4/fib_trie.c:1160:29: warning: Uninitialized variable: last->fa_slen [uninitvar]
      if (new->fa_slen < last->fa_slen)
                               ^
>> net/ipv4/fib_trie.c:2169:8: warning: Uninitialized variable: fi [uninitvar]
     if (!fi)
          ^
   net/ipv4/fib_trie.c:2167:27: note: Assignment 'fi=fa->fa_info', assigned value is <Uninit>
     struct fib_info *fi = fa->fa_info;
                             ^
   net/ipv4/fib_trie.c:2169:8: note: Uninitialized variable: fi
     if (!fi)
          ^
>> net/ipv4/fib_trie.c:2175:24: warning: Uninitialized variable: fa->tb_id [uninitvar]
     if (tb->tb_id != fa->tb_id)
                          ^
   net/ipv4/fib_trie.c:2169:7: note: Assuming condition is false
     if (!fi)
         ^
   net/ipv4/fib_trie.c:2175:24: note: Uninitialized variable: fa->tb_id
     if (tb->tb_id != fa->tb_id)
                          ^
>> net/ipv4/fib_trie.c:2894:61: warning: Parameter 'v' can be declared with const [constParameter]
   static void *fib_route_seq_next(struct seq_file *seq, void *v, loff_t *pos)
                                                               ^
   net/ipv4/fib_trie.c:2805:24: warning: Uninitialized variable: fa->fa_slen [uninitvar]
          KEYLENGTH - fa->fa_slen,
                          ^
   net/ipv4/fib_trie.c:2965:48: warning: Uninitialized variable: fa->fa_slen [uninitvar]
     __be32 mask = inet_make_mask(KEYLENGTH - fa->fa_slen);
                                                  ^
   net/ipv4/fib_trie.c:2954:8: note: Assuming condition is false
    if (v == SEQ_START_TOKEN) {
          ^
   net/ipv4/fib_trie.c:2965:48: note: Uninitialized variable: fa->fa_slen
     __be32 mask = inet_make_mask(KEYLENGTH - fa->fa_slen);
                                                  ^
--
>> net/ipv4/route.c:662:24: warning: The statement 'if (fnhe->fnhe_genid!=genid) fnhe->fnhe_genid=genid' is logically equivalent to 'fnhe->fnhe_genid=genid'. [duplicateConditionalAssign]
     if (fnhe->fnhe_genid != genid)
                          ^
   net/ipv4/route.c:663:21: note: Assignment 'fnhe->fnhe_genid=genid'
      fnhe->fnhe_genid = genid;
                       ^
   net/ipv4/route.c:662:24: note: Condition 'fnhe->fnhe_genid!=genid' is redundant
     if (fnhe->fnhe_genid != genid)
                          ^
>> net/ipv4/route.c:3390:13: warning: Uninitialized variable: fa->fa_slen [uninitvar]
       if (fa->fa_slen == slen &&
               ^
>> net/ipv4/route.c:221:58: warning: Parameter 'v' can be declared with const [constParameter]
   static int rt_cache_seq_show(struct seq_file *seq, void *v)
                                                            ^

vim +/irq +1857 drivers/net/dsa/mt7530.c

429a0edeefd88c DENG Qingfang 2021-01-25  1841  
ba751e28d44255 DENG Qingfang 2021-05-19  1842  static irqreturn_t
ba751e28d44255 DENG Qingfang 2021-05-19  1843  mt7530_irq_thread_fn(int irq, void *dev_id)
ba751e28d44255 DENG Qingfang 2021-05-19  1844  {
ba751e28d44255 DENG Qingfang 2021-05-19  1845  	struct mt7530_priv *priv = dev_id;
ba751e28d44255 DENG Qingfang 2021-05-19  1846  	bool handled = false;
ba751e28d44255 DENG Qingfang 2021-05-19  1847  	u32 val;
ba751e28d44255 DENG Qingfang 2021-05-19  1848  	int p;
ba751e28d44255 DENG Qingfang 2021-05-19  1849  
ba751e28d44255 DENG Qingfang 2021-05-19  1850  	mutex_lock_nested(&priv->bus->mdio_lock, MDIO_MUTEX_NESTED);
ba751e28d44255 DENG Qingfang 2021-05-19  1851  	val = mt7530_mii_read(priv, MT7530_SYS_INT_STS);
ba751e28d44255 DENG Qingfang 2021-05-19  1852  	mt7530_mii_write(priv, MT7530_SYS_INT_STS, val);
ba751e28d44255 DENG Qingfang 2021-05-19  1853  	mutex_unlock(&priv->bus->mdio_lock);
ba751e28d44255 DENG Qingfang 2021-05-19  1854  
ba751e28d44255 DENG Qingfang 2021-05-19  1855  	for (p = 0; p < MT7530_NUM_PHYS; p++) {
ba751e28d44255 DENG Qingfang 2021-05-19  1856  		if (BIT(p) & val) {
ba751e28d44255 DENG Qingfang 2021-05-19 @1857  			unsigned int irq;
ba751e28d44255 DENG Qingfang 2021-05-19  1858  
ba751e28d44255 DENG Qingfang 2021-05-19  1859  			irq = irq_find_mapping(priv->irq_domain, p);
ba751e28d44255 DENG Qingfang 2021-05-19  1860  			handle_nested_irq(irq);
ba751e28d44255 DENG Qingfang 2021-05-19  1861  			handled = true;
ba751e28d44255 DENG Qingfang 2021-05-19  1862  		}
ba751e28d44255 DENG Qingfang 2021-05-19  1863  	}
ba751e28d44255 DENG Qingfang 2021-05-19  1864  
ba751e28d44255 DENG Qingfang 2021-05-19  1865  	return IRQ_RETVAL(handled);
ba751e28d44255 DENG Qingfang 2021-05-19  1866  }
ba751e28d44255 DENG Qingfang 2021-05-19  1867  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] 2+ messages in thread