[Buildroot] [PATCH 1/1] package/gstreamer1/gst1-plugins-good: fix build with gcc 4.8

[Buildroot] [PATCH 1/1] package/gstreamer1/gst1-plugins-good: fix build with gcc 4.8

[Fabrice Fontaine]

Fix the following build failure with gcc 4.8 raised since bump to
version 1.20.0 in commit 34317969278d7b6d923d4889fb4235f112b2b201:

../ext/soup/gstsouploader.c: In function 'gst_soup_load_library':
../ext/soup/gstsouploader.c:219:3: error: 'for' loop initial declarations are only allowed in C99 mode
   for (guint i = 0; i < len; i++) {
   ^

Fixes:
 - http://autobuild.buildroot.org/results/21792a9839d9722815075569123df8747fc450e3

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
index 1168feb293..2b6cf769aa 100644
--- a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
+++ b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
@@ -10,6 +10,7 @@ GST1_PLUGINS_GOOD_SITE = https://gstreamer.freedesktop.org/src/gst-plugins-good
 GST1_PLUGINS_GOOD_LICENSE_FILES = COPYING
 GST1_PLUGINS_GOOD_LICENSE = LGPL-2.1+
 
+GST1_PLUGINS_GOOD_CFLAGS = $(TARGET_CFLAGS) -std=gnu99
 GST1_PLUGINS_GOOD_LDFLAGS = $(TARGET_LDFLAGS) $(TARGET_NLS_LIBS)
 
 GST1_PLUGINS_GOOD_CONF_OPTS = \
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/gstreamer1/gst1-plugins-good: fix build with gcc 4.8

[Arnout Vandecappelle]

On 22/04/2022 23:59, Fabrice Fontaine wrote:
> Fix the following build failure with gcc 4.8 raised since bump to
> version 1.20.0 in commit 34317969278d7b6d923d4889fb4235f112b2b201:
> 
> ../ext/soup/gstsouploader.c: In function 'gst_soup_load_library':
> ../ext/soup/gstsouploader.c:219:3: error: 'for' loop initial declarations are only allowed in C99 mode
>     for (guint i = 0; i < len; i++) {
>     ^
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/21792a9839d9722815075569123df8747fc450e3
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
> index 1168feb293..2b6cf769aa 100644
> --- a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
> +++ b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
> @@ -10,6 +10,7 @@ GST1_PLUGINS_GOOD_SITE = https://gstreamer.freedesktop.org/src/gst-plugins-good
>   GST1_PLUGINS_GOOD_LICENSE_FILES = COPYING
>   GST1_PLUGINS_GOOD_LICENSE = LGPL-2.1+
>   
> +GST1_PLUGINS_GOOD_CFLAGS = $(TARGET_CFLAGS) -std=gnu99
>   GST1_PLUGINS_GOOD_LDFLAGS = $(TARGET_LDFLAGS) $(TARGET_NLS_LIBS)
>   
>   GST1_PLUGINS_GOOD_CONF_OPTS = \
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/gstreamer1/gst1-plugins-good: fix build with gcc 4.8

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Fix the following build failure with gcc 4.8 raised since bump to
 > version 1.20.0 in commit 34317969278d7b6d923d4889fb4235f112b2b201:

 > ../ext/soup/gstsouploader.c: In function 'gst_soup_load_library':
 > ../ext/soup/gstsouploader.c:219:3: error: 'for' loop initial declarations are only allowed in C99 mode
 >    for (guint i = 0; i < len; i++) {
 >    ^

 > Fixes:
 >  - http://autobuild.buildroot.org/results/21792a9839d9722815075569123df8747fc450e3

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot