From: kernel test robot <lkp@intel.com> To: David Matlack <dmatlack@google.com>, Paolo Bonzini <pbonzini@redhat.com> Cc: kbuild-all@lists.01.org, Marc Zyngier <maz@kernel.org>, Huacai Chen <chenhuacai@kernel.org>, Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>, Anup Patel <anup@brainfault.org>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Sean Christopherson <seanjc@google.com>, Andrew Jones <drjones@redhat.com>, Ben Gardon <bgardon@google.com>, Peter Xu <peterx@redhat.com>, maciej.szmigiero@oracle.com, "moderated list:KERNEL VIRTUAL MACHINE FOR ARM64 (KVM/arm64)" <kvmarm@lists.cs.columbia.edu>, "open list:KERNEL VIRTUAL MACHINE FOR MIPS (KVM/mips)" <linux-mips@vger.kernel.org>, "open list:KERNEL VIRTUAL MACHINE FOR RISC-V (KVM/riscv)" <kvm-riscv@lists.infradead.org>, Peter Feiner <pfeiner@google.com>, David Matlack <dmatlack@google.com> Subject: Re: [PATCH v4 19/20] KVM: Allow for different capacities in kvm_mmu_memory_cache structs Date: Sat, 23 Apr 2022 16:08:10 +0800 [thread overview] Message-ID: <202204231516.bclimUe4-lkp@intel.com> (raw) In-Reply-To: <20220422210546.458943-20-dmatlack@google.com> Hi David, Thank you for the patch! Yet something to improve: [auto build test ERROR on 150866cd0ec871c765181d145aa0912628289c8a] url: https://github.com/intel-lab-lkp/linux/commits/David-Matlack/KVM-Extend-Eager-Page-Splitting-to-the-shadow-MMU/20220423-062108 base: 150866cd0ec871c765181d145aa0912628289c8a config: riscv-randconfig-r005-20220422 (https://download.01.org/0day-ci/archive/20220423/202204231516.bclimUe4-lkp@intel.com/config) compiler: riscv64-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/871c5afc76a6f414c03f433d06bacfd928910b1b git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review David-Matlack/KVM-Extend-Eager-Page-Splitting-to-the-shadow-MMU/20220423-062108 git checkout 871c5afc76a6f414c03f433d06bacfd928910b1b # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All error/warnings (new ones prefixed by >>): arch/riscv/kvm/mmu.c: In function 'stage2_ioremap': >> arch/riscv/kvm/mmu.c:364:56: error: 'struct kvm_mmu_memory_cache' has no member named 'cache' 364 | ret = kvm_mmu_topup_memory_cache(&cache.cache, stage2_pgd_levels); | ^ arch/riscv/kvm/mmu.c:369:52: error: 'struct kvm_mmu_memory_cache' has no member named 'cache' 369 | ret = stage2_set_pte(kvm, 0, &cache.cache, addr, &pte); | ^ arch/riscv/kvm/mmu.c:378:41: error: 'struct kvm_mmu_memory_cache' has no member named 'cache' 378 | kvm_mmu_free_memory_cache(&cache.cache); | ^ >> arch/riscv/kvm/mmu.c:350:37: warning: variable 'cache' set but not used [-Wunused-but-set-variable] 350 | struct kvm_mmu_memory_cache cache = { | ^~~~~ vim +364 arch/riscv/kvm/mmu.c 342 343 static int stage2_ioremap(struct kvm *kvm, gpa_t gpa, phys_addr_t hpa, 344 unsigned long size, bool writable) 345 { 346 pte_t pte; 347 int ret = 0; 348 unsigned long pfn; 349 phys_addr_t addr, end; > 350 struct kvm_mmu_memory_cache cache = { 351 .capacity = KVM_ARCH_NR_OBJS_PER_MEMORY_CACHE, 352 .gfp_zero = __GFP_ZERO, 353 }; 354 355 end = (gpa + size + PAGE_SIZE - 1) & PAGE_MASK; 356 pfn = __phys_to_pfn(hpa); 357 358 for (addr = gpa; addr < end; addr += PAGE_SIZE) { 359 pte = pfn_pte(pfn, PAGE_KERNEL); 360 361 if (!writable) 362 pte = pte_wrprotect(pte); 363 > 364 ret = kvm_mmu_topup_memory_cache(&cache.cache, stage2_pgd_levels); 365 if (ret) 366 goto out; 367 368 spin_lock(&kvm->mmu_lock); 369 ret = stage2_set_pte(kvm, 0, &cache.cache, addr, &pte); 370 spin_unlock(&kvm->mmu_lock); 371 if (ret) 372 goto out; 373 374 pfn++; 375 } 376 377 out: 378 kvm_mmu_free_memory_cache(&cache.cache); 379 return ret; 380 } 381 -- 0-DAY CI Kernel Test Service https://01.org/lkp
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: David Matlack <dmatlack@google.com>, Paolo Bonzini <pbonzini@redhat.com> Cc: Albert Ou <aou@eecs.berkeley.edu>, kbuild-all@lists.01.org, Marc Zyngier <maz@kernel.org>, Huacai Chen <chenhuacai@kernel.org>, "open list:KERNEL VIRTUAL MACHINE FOR MIPS \(KVM/mips\)" <linux-mips@vger.kernel.org>, David Matlack <dmatlack@google.com>, Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>, Palmer Dabbelt <palmer@dabbelt.com>, "open list:KERNEL VIRTUAL MACHINE FOR RISC-V \(KVM/riscv\)" <kvm-riscv@lists.infradead.org>, Paul Walmsley <paul.walmsley@sifive.com>, Ben Gardon <bgardon@google.com>, maciej.szmigiero@oracle.com, "moderated list:KERNEL VIRTUAL MACHINE FOR ARM64 \(KVM/arm64\)" <kvmarm@lists.cs.columbia.edu>, Peter Feiner <pfeiner@google.com> Subject: Re: [PATCH v4 19/20] KVM: Allow for different capacities in kvm_mmu_memory_cache structs Date: Sat, 23 Apr 2022 16:08:10 +0800 [thread overview] Message-ID: <202204231516.bclimUe4-lkp@intel.com> (raw) In-Reply-To: <20220422210546.458943-20-dmatlack@google.com> Hi David, Thank you for the patch! Yet something to improve: [auto build test ERROR on 150866cd0ec871c765181d145aa0912628289c8a] url: https://github.com/intel-lab-lkp/linux/commits/David-Matlack/KVM-Extend-Eager-Page-Splitting-to-the-shadow-MMU/20220423-062108 base: 150866cd0ec871c765181d145aa0912628289c8a config: riscv-randconfig-r005-20220422 (https://download.01.org/0day-ci/archive/20220423/202204231516.bclimUe4-lkp@intel.com/config) compiler: riscv64-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/871c5afc76a6f414c03f433d06bacfd928910b1b git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review David-Matlack/KVM-Extend-Eager-Page-Splitting-to-the-shadow-MMU/20220423-062108 git checkout 871c5afc76a6f414c03f433d06bacfd928910b1b # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All error/warnings (new ones prefixed by >>): arch/riscv/kvm/mmu.c: In function 'stage2_ioremap': >> arch/riscv/kvm/mmu.c:364:56: error: 'struct kvm_mmu_memory_cache' has no member named 'cache' 364 | ret = kvm_mmu_topup_memory_cache(&cache.cache, stage2_pgd_levels); | ^ arch/riscv/kvm/mmu.c:369:52: error: 'struct kvm_mmu_memory_cache' has no member named 'cache' 369 | ret = stage2_set_pte(kvm, 0, &cache.cache, addr, &pte); | ^ arch/riscv/kvm/mmu.c:378:41: error: 'struct kvm_mmu_memory_cache' has no member named 'cache' 378 | kvm_mmu_free_memory_cache(&cache.cache); | ^ >> arch/riscv/kvm/mmu.c:350:37: warning: variable 'cache' set but not used [-Wunused-but-set-variable] 350 | struct kvm_mmu_memory_cache cache = { | ^~~~~ vim +364 arch/riscv/kvm/mmu.c 342 343 static int stage2_ioremap(struct kvm *kvm, gpa_t gpa, phys_addr_t hpa, 344 unsigned long size, bool writable) 345 { 346 pte_t pte; 347 int ret = 0; 348 unsigned long pfn; 349 phys_addr_t addr, end; > 350 struct kvm_mmu_memory_cache cache = { 351 .capacity = KVM_ARCH_NR_OBJS_PER_MEMORY_CACHE, 352 .gfp_zero = __GFP_ZERO, 353 }; 354 355 end = (gpa + size + PAGE_SIZE - 1) & PAGE_MASK; 356 pfn = __phys_to_pfn(hpa); 357 358 for (addr = gpa; addr < end; addr += PAGE_SIZE) { 359 pte = pfn_pte(pfn, PAGE_KERNEL); 360 361 if (!writable) 362 pte = pte_wrprotect(pte); 363 > 364 ret = kvm_mmu_topup_memory_cache(&cache.cache, stage2_pgd_levels); 365 if (ret) 366 goto out; 367 368 spin_lock(&kvm->mmu_lock); 369 ret = stage2_set_pte(kvm, 0, &cache.cache, addr, &pte); 370 spin_unlock(&kvm->mmu_lock); 371 if (ret) 372 goto out; 373 374 pfn++; 375 } 376 377 out: 378 kvm_mmu_free_memory_cache(&cache.cache); 379 return ret; 380 } 381 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2022-04-23 8:09 UTC|newest] Thread overview: 120+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-22 21:05 [PATCH v4 00/20] KVM: Extend Eager Page Splitting to the shadow MMU David Matlack 2022-04-22 21:05 ` David Matlack 2022-04-22 21:05 ` [PATCH v4 01/20] KVM: x86/mmu: Optimize MMU page cache lookup for all direct SPs David Matlack 2022-04-22 21:05 ` David Matlack 2022-05-07 7:46 ` Lai Jiangshan 2022-05-07 7:46 ` Lai Jiangshan 2022-04-22 21:05 ` [PATCH v4 02/20] KVM: x86/mmu: Use a bool for direct David Matlack 2022-04-22 21:05 ` David Matlack 2022-05-07 7:46 ` Lai Jiangshan 2022-05-07 7:46 ` Lai Jiangshan 2022-04-22 21:05 ` [PATCH v4 03/20] KVM: x86/mmu: Derive shadow MMU page role from parent David Matlack 2022-04-22 21:05 ` David Matlack 2022-05-05 21:50 ` Sean Christopherson 2022-05-05 21:50 ` Sean Christopherson 2022-05-09 22:10 ` David Matlack 2022-05-09 22:10 ` David Matlack 2022-05-10 2:38 ` Lai Jiangshan 2022-05-10 2:38 ` Lai Jiangshan 2022-05-07 8:28 ` Lai Jiangshan 2022-05-07 8:28 ` Lai Jiangshan 2022-05-09 21:04 ` David Matlack 2022-05-09 21:04 ` David Matlack 2022-05-10 2:58 ` Lai Jiangshan 2022-05-10 2:58 ` Lai Jiangshan 2022-05-10 13:31 ` Sean Christopherson 2022-05-10 13:31 ` Sean Christopherson 2022-05-12 16:10 ` David Matlack 2022-05-12 16:10 ` David Matlack 2022-05-13 18:26 ` David Matlack 2022-05-13 18:26 ` David Matlack 2022-04-22 21:05 ` [PATCH v4 04/20] KVM: x86/mmu: Decompose kvm_mmu_get_page() into separate functions David Matlack 2022-04-22 21:05 ` David Matlack 2022-05-05 21:58 ` Sean Christopherson 2022-05-05 21:58 ` Sean Christopherson 2022-04-22 21:05 ` [PATCH v4 05/20] KVM: x86/mmu: Consolidate shadow page allocation and initialization David Matlack 2022-04-22 21:05 ` David Matlack 2022-05-05 22:10 ` Sean Christopherson 2022-05-05 22:10 ` Sean Christopherson 2022-05-09 20:53 ` David Matlack 2022-05-09 20:53 ` David Matlack 2022-04-22 21:05 ` [PATCH v4 06/20] KVM: x86/mmu: Rename shadow MMU functions that deal with shadow pages David Matlack 2022-04-22 21:05 ` David Matlack 2022-05-05 22:15 ` Sean Christopherson 2022-05-05 22:15 ` Sean Christopherson 2022-04-22 21:05 ` [PATCH v4 07/20] KVM: x86/mmu: Move guest PT write-protection to account_shadowed() David Matlack 2022-04-22 21:05 ` David Matlack 2022-05-05 22:51 ` Sean Christopherson 2022-05-05 22:51 ` Sean Christopherson 2022-05-09 21:18 ` David Matlack 2022-05-09 21:18 ` David Matlack 2022-04-22 21:05 ` [PATCH v4 08/20] KVM: x86/mmu: Pass memory caches to allocate SPs separately David Matlack 2022-04-22 21:05 ` David Matlack 2022-05-05 23:00 ` Sean Christopherson 2022-05-05 23:00 ` Sean Christopherson 2022-04-22 21:05 ` [PATCH v4 09/20] KVM: x86/mmu: Replace vcpu with kvm in kvm_mmu_alloc_shadow_page() David Matlack 2022-04-22 21:05 ` David Matlack 2022-04-22 21:05 ` [PATCH v4 10/20] KVM: x86/mmu: Pass kvm pointer separately from vcpu to kvm_mmu_find_shadow_page() David Matlack 2022-04-22 21:05 ` David Matlack 2022-04-22 21:05 ` [PATCH v4 11/20] KVM: x86/mmu: Allow for NULL vcpu pointer in __kvm_mmu_get_shadow_page() David Matlack 2022-04-22 21:05 ` David Matlack 2022-05-05 23:33 ` Sean Christopherson 2022-05-05 23:33 ` Sean Christopherson 2022-05-09 21:26 ` David Matlack 2022-05-09 21:26 ` David Matlack 2022-05-09 22:56 ` Sean Christopherson 2022-05-09 22:56 ` Sean Christopherson 2022-05-09 23:59 ` David Matlack 2022-05-09 23:59 ` David Matlack 2022-04-22 21:05 ` [PATCH v4 12/20] KVM: x86/mmu: Pass const memslot to rmap_add() David Matlack 2022-04-22 21:05 ` David Matlack 2022-04-22 21:05 ` [PATCH v4 13/20] KVM: x86/mmu: Decouple rmap_add() and link_shadow_page() from kvm_vcpu David Matlack 2022-04-22 21:05 ` David Matlack 2022-05-05 23:46 ` Sean Christopherson 2022-05-05 23:46 ` Sean Christopherson 2022-05-09 21:27 ` David Matlack 2022-05-09 21:27 ` David Matlack 2022-04-22 21:05 ` [PATCH v4 14/20] KVM: x86/mmu: Update page stats in __rmap_add() David Matlack 2022-04-22 21:05 ` David Matlack 2022-04-22 21:05 ` [PATCH v4 15/20] KVM: x86/mmu: Cache the access bits of shadowed translations David Matlack 2022-04-22 21:05 ` David Matlack 2022-05-06 19:47 ` Sean Christopherson 2022-05-06 19:47 ` Sean Christopherson 2022-05-09 16:10 ` Sean Christopherson 2022-05-09 16:10 ` Sean Christopherson 2022-05-09 21:29 ` David Matlack 2022-05-09 21:29 ` David Matlack 2022-04-22 21:05 ` [PATCH v4 16/20] KVM: x86/mmu: Extend make_huge_page_split_spte() for the shadow MMU David Matlack 2022-04-22 21:05 ` David Matlack 2022-05-09 16:22 ` Sean Christopherson 2022-05-09 16:22 ` Sean Christopherson 2022-05-09 21:31 ` David Matlack 2022-05-09 21:31 ` David Matlack 2022-04-22 21:05 ` [PATCH v4 17/20] KVM: x86/mmu: Zap collapsible SPTEs at all levels in " David Matlack 2022-04-22 21:05 ` David Matlack 2022-05-09 16:31 ` Sean Christopherson 2022-05-09 16:31 ` Sean Christopherson 2022-05-09 21:34 ` David Matlack 2022-05-09 21:34 ` David Matlack 2022-04-22 21:05 ` [PATCH v4 18/20] KVM: x86/mmu: Refactor drop_large_spte() David Matlack 2022-04-22 21:05 ` David Matlack 2022-05-09 16:36 ` Sean Christopherson 2022-05-09 16:36 ` Sean Christopherson 2022-04-22 21:05 ` [PATCH v4 19/20] KVM: Allow for different capacities in kvm_mmu_memory_cache structs David Matlack 2022-04-22 21:05 ` David Matlack 2022-04-23 8:08 ` kernel test robot [this message] 2022-04-23 8:08 ` kernel test robot 2022-04-24 15:21 ` kernel test robot 2022-04-24 15:21 ` kernel test robot 2022-04-22 21:05 ` [PATCH v4 20/20] KVM: x86/mmu: Extend Eager Page Splitting to nested MMUs David Matlack 2022-04-22 21:05 ` David Matlack 2022-05-07 7:51 ` Lai Jiangshan 2022-05-07 7:51 ` Lai Jiangshan 2022-05-09 21:40 ` David Matlack 2022-05-09 21:40 ` David Matlack 2022-05-09 16:48 ` Sean Christopherson 2022-05-09 16:48 ` Sean Christopherson 2022-05-09 21:44 ` David Matlack 2022-05-09 21:44 ` David Matlack 2022-05-09 22:47 ` Sean Christopherson 2022-05-09 22:47 ` Sean Christopherson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202204231516.bclimUe4-lkp@intel.com \ --to=lkp@intel.com \ --cc=aleksandar.qemu.devel@gmail.com \ --cc=anup@brainfault.org \ --cc=aou@eecs.berkeley.edu \ --cc=bgardon@google.com \ --cc=chenhuacai@kernel.org \ --cc=dmatlack@google.com \ --cc=drjones@redhat.com \ --cc=kbuild-all@lists.01.org \ --cc=kvm-riscv@lists.infradead.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-mips@vger.kernel.org \ --cc=maciej.szmigiero@oracle.com \ --cc=maz@kernel.org \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=pbonzini@redhat.com \ --cc=peterx@redhat.com \ --cc=pfeiner@google.com \ --cc=seanjc@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.