[Buildroot] [PATCH 1/1] package/argp-standalone: fix NLS build

[Buildroot] [PATCH 1/1] package/argp-standalone: fix NLS build

[Fabrice Fontaine]

Fix the following build failure raised since bump to version 1.4.1 in
commit 0fe85041bc9e0b4ade4d71dd10b61c3b9ec8945d and
https://github.com/ericonr/argp-standalone/commit/e5fe9ad9e83e6765cf8fa787f903d4c6792338b5:

/home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/10.3.0/../../../../mipsel-buildroot-linux-uclibc/bin/ld: libargp.a(argp-parse.o): in function `argp_version_parser':
/home/buildroot/autobuild/instance-2/output-1/build/argp-standalone-1.4.1/argp-parse.c:181: undefined reference to `libintl_dgettext'

Fixes:
 - http://autobuild.buildroot.org/results/adb9c4b747352497adbc9df866709b17fe0f9755

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/argp-standalone/argp-standalone.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/argp-standalone/argp-standalone.mk b/package/argp-standalone/argp-standalone.mk
index 80ca04046d..269239fa5b 100644
--- a/package/argp-standalone/argp-standalone.mk
+++ b/package/argp-standalone/argp-standalone.mk
@@ -12,9 +12,11 @@ ARGP_STANDALONE_LICENSE = LGPL-2.1+
 ARGP_STANDALONE_LICENSE_FILES = README.md
 # From git
 ARGP_STANDALONE_AUTORECONF = YES
+ARGP_STANDALONE_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES)
 
 ARGP_STANDALONE_CONF_ENV = \
-	CFLAGS="$(TARGET_CFLAGS) -fPIC -fgnu89-inline"
+	CFLAGS="$(TARGET_CFLAGS) -fPIC -fgnu89-inline" \
+	LIBS=$(TARGET_NLS_LIBS)
 
 define ARGP_STANDALONE_INSTALL_STAGING_CMDS
 	$(INSTALL) -D $(@D)/libargp.a $(STAGING_DIR)/usr/lib/libargp.a
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/argp-standalone: fix NLS build

[Arnout Vandecappelle]

On 23/04/2022 22:54, Fabrice Fontaine wrote:
> Fix the following build failure raised since bump to version 1.4.1 in
> commit 0fe85041bc9e0b4ade4d71dd10b61c3b9ec8945d and
> https://github.com/ericonr/argp-standalone/commit/e5fe9ad9e83e6765cf8fa787f903d4c6792338b5:
> 
> /home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/10.3.0/../../../../mipsel-buildroot-linux-uclibc/bin/ld: libargp.a(argp-parse.o): in function `argp_version_parser':
> /home/buildroot/autobuild/instance-2/output-1/build/argp-standalone-1.4.1/argp-parse.c:181: undefined reference to `libintl_dgettext'
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/adb9c4b747352497adbc9df866709b17fe0f9755
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/argp-standalone/argp-standalone.mk | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/package/argp-standalone/argp-standalone.mk b/package/argp-standalone/argp-standalone.mk
> index 80ca04046d..269239fa5b 100644
> --- a/package/argp-standalone/argp-standalone.mk
> +++ b/package/argp-standalone/argp-standalone.mk
> @@ -12,9 +12,11 @@ ARGP_STANDALONE_LICENSE = LGPL-2.1+
>   ARGP_STANDALONE_LICENSE_FILES = README.md
>   # From git
>   ARGP_STANDALONE_AUTORECONF = YES
> +ARGP_STANDALONE_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES)
>   
>   ARGP_STANDALONE_CONF_ENV = \
> -	CFLAGS="$(TARGET_CFLAGS) -fPIC -fgnu89-inline"
> +	CFLAGS="$(TARGET_CFLAGS) -fPIC -fgnu89-inline" \
> +	LIBS=$(TARGET_NLS_LIBS)
>   
>   define ARGP_STANDALONE_INSTALL_STAGING_CMDS
>   	$(INSTALL) -D $(@D)/libargp.a $(STAGING_DIR)/usr/lib/libargp.a
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot