All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: sbabic@denx.de, festevam@gmail.com,
	ariel.dalessandro@collabora.com, michael@amarulasolutions.com,
	tharvey@gateworks.com, sjg@chromium.org,
	alpernebiyasak@gmail.com, marek.behun@nic.cz, pali@kernel.org,
	sr@denx.de, ricardo@foundries.io, patrick.delaunay@foss.st.com,
	trini@konsulko.com
Cc: u-boot@lists.denx.de, Peng Fan <peng.fan@nxp.com>
Subject: [PATCH V2 4/7] tools: binman: section: replace @ with -
Date: Sat,  7 May 2022 19:03:58 +0800	[thread overview]
Message-ID: <20220507110402.21355-5-peng.fan@oss.nxp.com> (raw)
In-Reply-To: <20220507110402.21355-1-peng.fan@oss.nxp.com>

From: Peng Fan <peng.fan@nxp.com>

In arch/arm/dts/imx8mp-u-boot.dtsi, there are blob-ext@1, blob-ext@2 and
etc which is for packing ddr phy firmware. However we could not declare
symbol name such as 'binman_sym_declare(ulong, blob_ext@1, image_pos)',
because '@' is not allowed, so we choose to declare the symbol
'binman_sym_declare(ulong, blob_ext_1, image_pos);' with '@' replaced with
'_'. It does not impact if there is no '@' in section name.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 tools/binman/etype/section.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/binman/etype/section.py b/tools/binman/etype/section.py
index bd67238b919..e3f362b442b 100644
--- a/tools/binman/etype/section.py
+++ b/tools/binman/etype/section.py
@@ -875,7 +875,7 @@ class Entry_section(Entry):
                 entries[entry.GetPath()] = entry
             for entry in to_add.values():
                 self._CollectEntries(entries, entries_by_name, entry)
-        entries_by_name[add_entry.name] = add_entry
+        entries_by_name[add_entry.name.replace('@', '-')] = add_entry
 
     def MissingArgs(self, entry, missing):
         """Report a missing argument, if enabled
-- 
2.36.0


  parent reply	other threads:[~2022-05-07 10:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-07 11:03 [PATCH V2 0/7] arm64: binman: use binman symbols for imx Peng Fan (OSS)
2022-05-07 11:03 ` [PATCH V2 1/7] spl: guard u_boot_any with X86 Peng Fan (OSS)
2022-05-07 11:03 ` [PATCH V2 2/7] arm: dts: imx8m: update binman ddr firmware node name Peng Fan (OSS)
2022-05-07 11:03 ` [PATCH V2 3/7] armv8: u-boot-spl.lds: mark __image_copy_start as symbol Peng Fan (OSS)
2022-05-07 11:03 ` Peng Fan (OSS) [this message]
2022-05-08 15:30   ` [PATCH V2 4/7] tools: binman: section: replace @ with - Tom Rini
2022-05-07 11:03 ` [PATCH V2 5/7] ddr: imx8m: helper: load ddr firmware according to binman symbols Peng Fan (OSS)
2022-05-09 17:32   ` Tim Harvey
2022-05-10  9:26     ` Peng Fan (OSS)
2022-05-07 11:04 ` [PATCH V2 6/7] arm: dts: imx8m: shrink ddr firmware size to actual file size Peng Fan (OSS)
2022-05-07 11:04 ` [PATCH V2 7/7] binman_sym: guard with CONFIG_SPL_BINMAN_SYMBOLS Peng Fan (OSS)
2022-05-08 15:30   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220507110402.21355-5-peng.fan@oss.nxp.com \
    --to=peng.fan@oss.nxp.com \
    --cc=alpernebiyasak@gmail.com \
    --cc=ariel.dalessandro@collabora.com \
    --cc=festevam@gmail.com \
    --cc=marek.behun@nic.cz \
    --cc=michael@amarulasolutions.com \
    --cc=pali@kernel.org \
    --cc=patrick.delaunay@foss.st.com \
    --cc=peng.fan@nxp.com \
    --cc=ricardo@foundries.io \
    --cc=sbabic@denx.de \
    --cc=sjg@chromium.org \
    --cc=sr@denx.de \
    --cc=tharvey@gateworks.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.