From: Tom Rini <trini@konsulko.com>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: sbabic@denx.de, festevam@gmail.com,
ariel.dalessandro@collabora.com, michael@amarulasolutions.com,
tharvey@gateworks.com, sjg@chromium.org,
alpernebiyasak@gmail.com, marek.behun@nic.cz, pali@kernel.org,
sr@denx.de, ricardo@foundries.io, patrick.delaunay@foss.st.com,
u-boot@lists.denx.de, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH V2 7/7] binman_sym: guard with CONFIG_SPL_BINMAN_SYMBOLS
Date: Sun, 8 May 2022 11:30:58 -0400 [thread overview]
Message-ID: <20220508153058.GE3901321@bill-the-cat> (raw)
In-Reply-To: <20220507110402.21355-8-peng.fan@oss.nxp.com>
[-- Attachment #1: Type: text/plain, Size: 474 bytes --]
On Sat, May 07, 2022 at 07:04:01PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> There is case that CONFIG_BINMAN is defined, but
> CONFIG_SPL_BINMAN_SYMBOLS is not defined. In that case, there will be
> build failure. So use CONFIG_SPL_BINMAN_SYMBOLS to guard the macros, and
> define CONFIG_SPL_BINMAN_SYMBOLS in binman syms test.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2022-05-08 15:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-07 11:03 [PATCH V2 0/7] arm64: binman: use binman symbols for imx Peng Fan (OSS)
2022-05-07 11:03 ` [PATCH V2 1/7] spl: guard u_boot_any with X86 Peng Fan (OSS)
2022-05-07 11:03 ` [PATCH V2 2/7] arm: dts: imx8m: update binman ddr firmware node name Peng Fan (OSS)
2022-05-07 11:03 ` [PATCH V2 3/7] armv8: u-boot-spl.lds: mark __image_copy_start as symbol Peng Fan (OSS)
2022-05-07 11:03 ` [PATCH V2 4/7] tools: binman: section: replace @ with - Peng Fan (OSS)
2022-05-08 15:30 ` Tom Rini
2022-05-07 11:03 ` [PATCH V2 5/7] ddr: imx8m: helper: load ddr firmware according to binman symbols Peng Fan (OSS)
2022-05-09 17:32 ` Tim Harvey
2022-05-10 9:26 ` Peng Fan (OSS)
2022-05-07 11:04 ` [PATCH V2 6/7] arm: dts: imx8m: shrink ddr firmware size to actual file size Peng Fan (OSS)
2022-05-07 11:04 ` [PATCH V2 7/7] binman_sym: guard with CONFIG_SPL_BINMAN_SYMBOLS Peng Fan (OSS)
2022-05-08 15:30 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220508153058.GE3901321@bill-the-cat \
--to=trini@konsulko.com \
--cc=alpernebiyasak@gmail.com \
--cc=ariel.dalessandro@collabora.com \
--cc=festevam@gmail.com \
--cc=marek.behun@nic.cz \
--cc=michael@amarulasolutions.com \
--cc=pali@kernel.org \
--cc=patrick.delaunay@foss.st.com \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=ricardo@foundries.io \
--cc=sbabic@denx.de \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=tharvey@gateworks.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.