From: Steven Rostedt <rostedt@goodmis.org>
To: Vasily Averin <vvs@openvz.org>
Cc: YoPOhRctb8wwbmY5@carbon, Shakeel Butt <shakeelb@google.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
Vlastimil Babka <vbabka@suse.cz>,
Matthew Wilcox <willy@infradead.org>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
Muchun Song <songmuchun@bytedance.com>,
kernel@openvz.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Joonsoo Kim <iamjoonsoo.kim@lge.com>,
David Rientjes <rientjes@google.com>,
Pekka Enberg <penberg@kernel.org>,
Christoph Lameter <cl@linux.com>, Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH v3] tracing: add 'accounted' entry into output of allocation tracepoints
Date: Thu, 19 May 2022 12:32:55 -0400 [thread overview]
Message-ID: <20220519123255.543b8db6@gandalf.local.home> (raw)
In-Reply-To: <e018be81-f4f2-a26f-7c5a-7adddd9c56c4@openvz.org>
On Thu, 19 May 2022 19:29:36 +0300
Vasily Averin <vvs@openvz.org> wrote:
> Frankly speaking I vote for performance with both hands.
> However I'm still would like to avoid new sparse warnings.
> Christoph Hellwig just recently taught me, "never add '__force' before
> thinking hard about them", but in this case I would need to use it three times.
>
> I found that bitwise typecasts can be avoided by using translation unions.
>
> What do you think about following trick?
It's really up to you memory management folks. Although I may need to
update libtraceevent to handle the union case. That may be a bit tricky.
-- Steve
WARNING: multiple messages have this Message-ID (diff)
From: Steven Rostedt <rostedt@goodmis.org>
To: Vasily Averin <vvs@openvz.org>
Cc: YoPOhRctb8wwbmY5@carbon.kvack.org,
Shakeel Butt <shakeelb@google.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
Vlastimil Babka <vbabka@suse.cz>,
Matthew Wilcox <willy@infradead.org>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
Muchun Song <songmuchun@bytedance.com>,
kernel@openvz.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Joonsoo Kim <iamjoonsoo.kim@lge.com>,
David Rientjes <rientjes@google.com>,
Pekka Enberg <penberg@kernel.org>,
Christoph Lameter <cl@linux.com>, Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH v3] tracing: add 'accounted' entry into output of allocation tracepoints
Date: Thu, 19 May 2022 12:32:55 -0400 [thread overview]
Message-ID: <20220519123255.543b8db6@gandalf.local.home> (raw)
In-Reply-To: <e018be81-f4f2-a26f-7c5a-7adddd9c56c4@openvz.org>
On Thu, 19 May 2022 19:29:36 +0300
Vasily Averin <vvs@openvz.org> wrote:
> Frankly speaking I vote for performance with both hands.
> However I'm still would like to avoid new sparse warnings.
> Christoph Hellwig just recently taught me, "never add '__force' before
> thinking hard about them", but in this case I would need to use it three times.
>
> I found that bitwise typecasts can be avoided by using translation unions.
>
> What do you think about following trick?
It's really up to you memory management folks. Although I may need to
update libtraceevent to handle the union case. That may be a bit tricky.
-- Steve
next prev parent reply other threads:[~2022-05-19 16:33 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 6:24 [PATCH v3] tracing: add 'accounted' entry into output of allocation tracepoints Vasily Averin
2022-05-18 15:09 ` Shakeel Butt
2022-05-18 15:45 ` Vasily Averin
2022-05-18 20:04 ` Steven Rostedt
2022-05-18 20:04 ` Steven Rostedt
2022-05-19 11:35 ` Vasily Averin
2022-05-19 11:35 ` Vasily Averin
2022-05-19 14:03 ` Steven Rostedt
2022-05-19 14:03 ` Steven Rostedt
2022-05-19 16:29 ` Vasily Averin
2022-05-19 16:29 ` Vasily Averin
2022-05-19 16:32 ` Steven Rostedt [this message]
2022-05-19 16:32 ` Steven Rostedt
2022-05-21 18:32 ` Vasily Averin
2022-05-21 18:32 ` Vasily Averin
2022-05-21 18:36 ` [PATCH v4] " Vasily Averin
2022-05-22 3:51 ` Hyeonggon Yoo
2022-05-22 4:33 ` Vasily Averin
2022-05-22 5:19 ` Hyeonggon Yoo
2022-05-22 5:42 ` Shakeel Butt
2022-05-22 18:53 ` Vasily Averin
2022-05-22 20:09 ` Steven Rostedt
2022-05-23 4:03 ` Vasily Averin
2022-05-23 13:12 ` Vlastimil Babka
2022-05-30 7:47 ` [PATCH v5] " Vasily Averin
2022-05-30 8:25 ` Muchun Song
2022-05-31 11:46 ` Hyeonggon Yoo
2022-05-31 16:58 ` Vasily Averin
2022-06-03 3:21 ` [PATCH mm v6] mm/tracing: " Vasily Averin
2022-06-03 3:21 ` Vasily Averin
2022-06-15 9:41 ` Vlastimil Babka
2022-06-15 9:41 ` Vlastimil Babka
2022-05-25 1:34 ` [PATCH v4] tracing: " Roman Gushchin
2022-05-25 7:33 ` Hyeonggon Yoo
2022-05-25 8:24 ` Vasily Averin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220519123255.543b8db6@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=42.hyeyoo@gmail.com \
--cc=YoPOhRctb8wwbmY5@carbon \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kernel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=songmuchun@bytedance.com \
--cc=vbabka@suse.cz \
--cc=vvs@openvz.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.