* [PATCH v2] drm/msm: use for_each_sgtable_sg to iterate over scatterlist
@ 2022-06-13 22:10 ` Jonathan Marek
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Marek @ 2022-06-13 22:10 UTC (permalink / raw)
To: freedreno
Cc: Rob Clark, Sean Paul, Abhinav Kumar, David Airlie, Daniel Vetter,
Jordan Crouse, Bjorn Andersson,
open list:DRM DRIVER FOR MSM ADRENO GPU,
open list:DRM DRIVER FOR MSM ADRENO GPU, open list
The dma_map_sgtable() call (used to invalidate cache) overwrites sgt->nents
with 1, so msm_iommu_pagetable_map maps only the first physical segment.
To fix this problem use for_each_sgtable_sg(), which uses orig_nents.
Fixes: b145c6e65eb0 ("drm/msm: Add support to create a local pagetable")
Signed-off-by: Jonathan Marek <jonathan@marek.ca>
---
v2: use for_each_sgtable_sg and update commit message
drivers/gpu/drm/msm/msm_iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/msm_iommu.c b/drivers/gpu/drm/msm/msm_iommu.c
index bcaddbba564df..a54ed354578b5 100644
--- a/drivers/gpu/drm/msm/msm_iommu.c
+++ b/drivers/gpu/drm/msm/msm_iommu.c
@@ -58,7 +58,7 @@ static int msm_iommu_pagetable_map(struct msm_mmu *mmu, u64 iova,
u64 addr = iova;
unsigned int i;
- for_each_sg(sgt->sgl, sg, sgt->nents, i) {
+ for_each_sgtable_sg(sgt, sg, i) {
size_t size = sg->length;
phys_addr_t phys = sg_phys(sg);
--
2.26.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH v2] drm/msm: use for_each_sgtable_sg to iterate over scatterlist
@ 2022-06-13 22:10 ` Jonathan Marek
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Marek @ 2022-06-13 22:10 UTC (permalink / raw)
To: freedreno
Cc: David Airlie, open list:DRM DRIVER FOR MSM ADRENO GPU,
Abhinav Kumar, open list:DRM DRIVER FOR MSM ADRENO GPU,
Jordan Crouse, Bjorn Andersson, Sean Paul, open list
The dma_map_sgtable() call (used to invalidate cache) overwrites sgt->nents
with 1, so msm_iommu_pagetable_map maps only the first physical segment.
To fix this problem use for_each_sgtable_sg(), which uses orig_nents.
Fixes: b145c6e65eb0 ("drm/msm: Add support to create a local pagetable")
Signed-off-by: Jonathan Marek <jonathan@marek.ca>
---
v2: use for_each_sgtable_sg and update commit message
drivers/gpu/drm/msm/msm_iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/msm_iommu.c b/drivers/gpu/drm/msm/msm_iommu.c
index bcaddbba564df..a54ed354578b5 100644
--- a/drivers/gpu/drm/msm/msm_iommu.c
+++ b/drivers/gpu/drm/msm/msm_iommu.c
@@ -58,7 +58,7 @@ static int msm_iommu_pagetable_map(struct msm_mmu *mmu, u64 iova,
u64 addr = iova;
unsigned int i;
- for_each_sg(sgt->sgl, sg, sgt->nents, i) {
+ for_each_sgtable_sg(sgt, sg, i) {
size_t size = sg->length;
phys_addr_t phys = sg_phys(sg);
--
2.26.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-13 22:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-13 22:10 [PATCH v2] drm/msm: use for_each_sgtable_sg to iterate over scatterlist Jonathan Marek
2022-06-13 22:10 ` Jonathan Marek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.