From: kernel test robot <lkp@intel.com>
To: Stefan Berger <stefanb@linux.ibm.com>,
kexec@lists.infradead.org, devicetree@vger.kernel.org
Cc: kbuild-all@lists.01.org, nayna@linux.ibm.com,
nasastry@in.ibm.com, Stefan Berger <stefanb@linux.ibm.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Eric Biederman <ebiederm@xmission.com>
Subject: Re: [PATCH 2/3] tpm/kexec: Duplicate TPM measurement log in of-tree for kexec
Date: Wed, 15 Jun 2022 08:54:02 +0800 [thread overview]
Message-ID: <202206150856.h2psJLGs-lkp@intel.com> (raw)
In-Reply-To: <20220614161258.1741427-3-stefanb@linux.ibm.com>
Hi Stefan,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on linus/master v5.19-rc2 next-20220614]
[cannot apply to robh/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Stefan-Berger/tpm-Preserve-TPM-measurement-log-across-kexec/20220615-001510
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 0a35780c755ccec097d15c6b4ff8b246a89f1689
config: x86_64-randconfig-r022-20220613 (https://download.01.org/0day-ci/archive/20220615/202206150856.h2psJLGs-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/c42b5be1ad82e8a991a3d35417c9e495e7eb4c93
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Stefan-Berger/tpm-Preserve-TPM-measurement-log-across-kexec/20220615-001510
git checkout c42b5be1ad82e8a991a3d35417c9e495e7eb4c93
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/of/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/of/kexec.c:306: warning: expecting prototype for tpm_free_kexec_buffer(). Prototype was for tpm_of_remove_kexec_buffer() instead
vim +306 drivers/of/kexec.c
301
302 /**
303 * tpm_free_kexec_buffer - free memory used by the IMA buffer
304 */
305 static int tpm_of_remove_kexec_buffer(void)
> 306 {
307 struct property *prop;
308
309 prop = of_find_property(of_chosen, "linux,tpm-kexec-buffer", NULL);
310 if (!prop)
311 return -ENOENT;
312
313 return of_remove_property(of_chosen, prop);
314 }
315
--
0-DAY CI Kernel Test Service
https://01.org/lkp
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Stefan Berger <stefanb@linux.ibm.com>,
kexec@lists.infradead.org, devicetree@vger.kernel.org
Cc: kbuild-all@lists.01.org, nayna@linux.ibm.com,
nasastry@in.ibm.com, Stefan Berger <stefanb@linux.ibm.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Eric Biederman <ebiederm@xmission.com>
Subject: Re: [PATCH 2/3] tpm/kexec: Duplicate TPM measurement log in of-tree for kexec
Date: Wed, 15 Jun 2022 08:54:02 +0800 [thread overview]
Message-ID: <202206150856.h2psJLGs-lkp@intel.com> (raw)
In-Reply-To: <20220614161258.1741427-3-stefanb@linux.ibm.com>
Hi Stefan,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on linus/master v5.19-rc2 next-20220614]
[cannot apply to robh/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Stefan-Berger/tpm-Preserve-TPM-measurement-log-across-kexec/20220615-001510
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 0a35780c755ccec097d15c6b4ff8b246a89f1689
config: x86_64-randconfig-r022-20220613 (https://download.01.org/0day-ci/archive/20220615/202206150856.h2psJLGs-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/c42b5be1ad82e8a991a3d35417c9e495e7eb4c93
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Stefan-Berger/tpm-Preserve-TPM-measurement-log-across-kexec/20220615-001510
git checkout c42b5be1ad82e8a991a3d35417c9e495e7eb4c93
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/of/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/of/kexec.c:306: warning: expecting prototype for tpm_free_kexec_buffer(). Prototype was for tpm_of_remove_kexec_buffer() instead
vim +306 drivers/of/kexec.c
301
302 /**
303 * tpm_free_kexec_buffer - free memory used by the IMA buffer
304 */
305 static int tpm_of_remove_kexec_buffer(void)
> 306 {
307 struct property *prop;
308
309 prop = of_find_property(of_chosen, "linux,tpm-kexec-buffer", NULL);
310 if (!prop)
311 return -ENOENT;
312
313 return of_remove_property(of_chosen, prop);
314 }
315
--
0-DAY CI Kernel Test Service
https://01.org/lkp
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2022-06-15 0:55 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 16:12 [PATCH 0/3] tpm: Preserve TPM measurement log across kexec Stefan Berger
2022-06-14 16:12 ` Stefan Berger
2022-06-14 16:12 ` [PATCH 1/3] of: kexec: Refactor IMA buffer related functions to make them reusable Stefan Berger
2022-06-14 16:12 ` Stefan Berger
2022-06-14 16:35 ` Nageswara R Sastry
2022-06-14 16:35 ` Nageswara R Sastry
2022-06-14 16:12 ` [PATCH 2/3] tpm/kexec: Duplicate TPM measurement log in of-tree for kexec Stefan Berger
2022-06-14 16:12 ` Stefan Berger
2022-06-14 16:46 ` Nageswara R Sastry
2022-06-14 16:46 ` Nageswara R Sastry
2022-06-14 17:48 ` Rob Herring
2022-06-14 17:48 ` Rob Herring
2022-06-15 13:08 ` Stefan Berger
2022-06-15 13:08 ` Stefan Berger
2022-06-15 20:14 ` Rob Herring
2022-06-15 20:14 ` Rob Herring
2022-06-15 21:45 ` Stefan Berger
2022-06-15 21:45 ` Stefan Berger
2022-06-15 20:18 ` Rob Herring
2022-06-15 20:18 ` Rob Herring
2022-06-14 18:58 ` kernel test robot
2022-06-14 18:58 ` kernel test robot
2022-06-15 0:54 ` kernel test robot [this message]
2022-06-15 0:54 ` kernel test robot
2022-06-15 9:42 ` kernel test robot
2022-06-15 9:42 ` kernel test robot
2022-06-14 16:12 ` [PATCH 3/3] tpm: of: Call of_tpm_get_sml_parameters() to get base and size of log Stefan Berger
2022-06-14 16:12 ` Stefan Berger
2022-06-14 16:47 ` Nageswara R Sastry
2022-06-14 16:47 ` Nageswara R Sastry
2022-06-15 21:25 ` Jarkko Sakkinen
2022-06-15 21:25 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202206150856.h2psJLGs-lkp@intel.com \
--to=lkp@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=ebiederm@xmission.com \
--cc=frowand.list@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=kexec@lists.infradead.org \
--cc=nasastry@in.ibm.com \
--cc=nayna@linux.ibm.com \
--cc=robh+dt@kernel.org \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.