[PATCH] accel: kvm: Fix memory leak in find_stats_descriptors

* [PATCH] accel: kvm: Fix memory leak in find_stats_descriptors
@ 2022-06-24  6:31 Miaoqian Lin
  2022-06-24  8:19 ` Paolo Bonzini
  0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2022-06-24  6:31 UTC (permalink / raw)
  To: Paolo Bonzini, kvm, qemu-devel; +Cc: linmq006

This function doesn't release descriptors in one error path,
result in memory leak. Call g_free() to release it.

Fixes: cc01a3f4cadd ("kvm: Support for querying fd-based stats")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
 accel/kvm/kvm-all.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index ba3210b1c10d..ed8b6b896ed3 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -3891,6 +3891,7 @@ static StatsDescriptors *find_stats_descriptors(StatsTarget target, int stats_fd
         error_setg(errp, "KVM stats: failed to read stats header: "
                    "expected %zu actual %zu",
                    sizeof(*kvm_stats_header), ret);
+        g_free(descriptors);
         return NULL;
     }
     size_desc = sizeof(*kvm_stats_desc) + kvm_stats_header->name_size;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread