* [PATCH] drm/amd: Add debug mask for subviewport mclk switch
@ 2022-06-28 21:26 Aurabindo Pillai
2022-06-30 18:24 ` Aurabindo Pillai
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Aurabindo Pillai @ 2022-06-28 21:26 UTC (permalink / raw)
To: alexdeucher, amd-gfx; +Cc: aurabindo.pillai, harry.wentland
[Why&How]
Expose a new debugfs enum to force a subviewport memory clock switch
to facilitate easy testing.
Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +++
drivers/gpu/drm/amd/include/amd_shared.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index c9145864ed2b..7a034ca95be2 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -1559,6 +1559,9 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
if (amdgpu_dc_debug_mask & DC_DISABLE_CLOCK_GATING)
adev->dm.dc->debug.disable_clock_gate = true;
+ if (amdgpu_dc_debug_mask & DC_FORCE_SUBVP_MCLK_SWITCH)
+ adev->dm.dc->debug.force_subvp_mclk_switch = true;
+
r = dm_dmub_hw_init(adev);
if (r) {
DRM_ERROR("DMUB interface failed to initialize: status=%d\n", r);
diff --git a/drivers/gpu/drm/amd/include/amd_shared.h b/drivers/gpu/drm/amd/include/amd_shared.h
index bcdf7453a403..b1c55dd7b498 100644
--- a/drivers/gpu/drm/amd/include/amd_shared.h
+++ b/drivers/gpu/drm/amd/include/amd_shared.h
@@ -247,6 +247,7 @@ enum DC_DEBUG_MASK {
DC_DISABLE_DSC = 0x4,
DC_DISABLE_CLOCK_GATING = 0x8,
DC_DISABLE_PSR = 0x10,
+ DC_FORCE_SUBVP_MCLK_SWITCH = 0x20,
};
enum amd_dpm_forced_level;
--
2.36.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/amd: Add debug mask for subviewport mclk switch
2022-06-28 21:26 [PATCH] drm/amd: Add debug mask for subviewport mclk switch Aurabindo Pillai
@ 2022-06-30 18:24 ` Aurabindo Pillai
2022-06-30 18:28 ` Alex Deucher
2022-07-05 19:53 ` Harry Wentland
2 siblings, 0 replies; 8+ messages in thread
From: Aurabindo Pillai @ 2022-06-30 18:24 UTC (permalink / raw)
To: alexdeucher, amd-gfx; +Cc: harry.wentland
Ping
On 2022-06-28 17:26, Aurabindo Pillai wrote:
> [Why&How]
> Expose a new debugfs enum to force a subviewport memory clock switch
> to facilitate easy testing.
>
> Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +++
> drivers/gpu/drm/amd/include/amd_shared.h | 1 +
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index c9145864ed2b..7a034ca95be2 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -1559,6 +1559,9 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
> if (amdgpu_dc_debug_mask & DC_DISABLE_CLOCK_GATING)
> adev->dm.dc->debug.disable_clock_gate = true;
>
> + if (amdgpu_dc_debug_mask & DC_FORCE_SUBVP_MCLK_SWITCH)
> + adev->dm.dc->debug.force_subvp_mclk_switch = true;
> +
> r = dm_dmub_hw_init(adev);
> if (r) {
> DRM_ERROR("DMUB interface failed to initialize: status=%d\n", r);
> diff --git a/drivers/gpu/drm/amd/include/amd_shared.h b/drivers/gpu/drm/amd/include/amd_shared.h
> index bcdf7453a403..b1c55dd7b498 100644
> --- a/drivers/gpu/drm/amd/include/amd_shared.h
> +++ b/drivers/gpu/drm/amd/include/amd_shared.h
> @@ -247,6 +247,7 @@ enum DC_DEBUG_MASK {
> DC_DISABLE_DSC = 0x4,
> DC_DISABLE_CLOCK_GATING = 0x8,
> DC_DISABLE_PSR = 0x10,
> + DC_FORCE_SUBVP_MCLK_SWITCH = 0x20,
> };
>
> enum amd_dpm_forced_level;
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/amd: Add debug mask for subviewport mclk switch
2022-06-28 21:26 [PATCH] drm/amd: Add debug mask for subviewport mclk switch Aurabindo Pillai
2022-06-30 18:24 ` Aurabindo Pillai
@ 2022-06-30 18:28 ` Alex Deucher
2022-06-30 19:28 ` Aurabindo Pillai
2022-07-05 19:53 ` Harry Wentland
2 siblings, 1 reply; 8+ messages in thread
From: Alex Deucher @ 2022-06-30 18:28 UTC (permalink / raw)
To: Aurabindo Pillai; +Cc: Wentland, Harry, amd-gfx list
On Tue, Jun 28, 2022 at 5:26 PM Aurabindo Pillai
<aurabindo.pillai@amd.com> wrote:
>
> [Why&How]
> Expose a new debugfs enum to force a subviewport memory clock switch
> to facilitate easy testing.
>
Is the debugfs support already plumbed in and this just enables you to
use it? If it's in debugfs, do we really need a module parameter to
enable it or can it just be enabled by default and used via debugfs
when needed?
Alex
> Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +++
> drivers/gpu/drm/amd/include/amd_shared.h | 1 +
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index c9145864ed2b..7a034ca95be2 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -1559,6 +1559,9 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
> if (amdgpu_dc_debug_mask & DC_DISABLE_CLOCK_GATING)
> adev->dm.dc->debug.disable_clock_gate = true;
>
> + if (amdgpu_dc_debug_mask & DC_FORCE_SUBVP_MCLK_SWITCH)
> + adev->dm.dc->debug.force_subvp_mclk_switch = true;
> +
> r = dm_dmub_hw_init(adev);
> if (r) {
> DRM_ERROR("DMUB interface failed to initialize: status=%d\n", r);
> diff --git a/drivers/gpu/drm/amd/include/amd_shared.h b/drivers/gpu/drm/amd/include/amd_shared.h
> index bcdf7453a403..b1c55dd7b498 100644
> --- a/drivers/gpu/drm/amd/include/amd_shared.h
> +++ b/drivers/gpu/drm/amd/include/amd_shared.h
> @@ -247,6 +247,7 @@ enum DC_DEBUG_MASK {
> DC_DISABLE_DSC = 0x4,
> DC_DISABLE_CLOCK_GATING = 0x8,
> DC_DISABLE_PSR = 0x10,
> + DC_FORCE_SUBVP_MCLK_SWITCH = 0x20,
> };
>
> enum amd_dpm_forced_level;
> --
> 2.36.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/amd: Add debug mask for subviewport mclk switch
2022-06-30 18:28 ` Alex Deucher
@ 2022-06-30 19:28 ` Aurabindo Pillai
2022-06-30 19:33 ` Alex Deucher
0 siblings, 1 reply; 8+ messages in thread
From: Aurabindo Pillai @ 2022-06-30 19:28 UTC (permalink / raw)
To: Alex Deucher; +Cc: Wentland, Harry, amd-gfx list
On 2022-06-30 14:28, Alex Deucher wrote:
> On Tue, Jun 28, 2022 at 5:26 PM Aurabindo Pillai
> <aurabindo.pillai@amd.com> wrote:
>>
>> [Why&How]
>> Expose a new debugfs enum to force a subviewport memory clock switch
>> to facilitate easy testing.
>>
>
> Is the debugfs support already plumbed in and this just enables you to
> use it? If it's in debugfs, do we really need a module parameter to
> enable it or can it just be enabled by default and used via debugfs
> when needed?
Sorry, I meant to put in debug mask, like in the title. Will fix that.
There is no debugfs associated with this change. The change in DM is
enough to enable this.
>
> Alex
>
>> Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
>> ---
>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +++
>> drivers/gpu/drm/amd/include/amd_shared.h | 1 +
>> 2 files changed, 4 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> index c9145864ed2b..7a034ca95be2 100644
>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> @@ -1559,6 +1559,9 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
>> if (amdgpu_dc_debug_mask & DC_DISABLE_CLOCK_GATING)
>> adev->dm.dc->debug.disable_clock_gate = true;
>>
>> + if (amdgpu_dc_debug_mask & DC_FORCE_SUBVP_MCLK_SWITCH)
>> + adev->dm.dc->debug.force_subvp_mclk_switch = true;
>> +
>> r = dm_dmub_hw_init(adev);
>> if (r) {
>> DRM_ERROR("DMUB interface failed to initialize: status=%d\n", r);
>> diff --git a/drivers/gpu/drm/amd/include/amd_shared.h b/drivers/gpu/drm/amd/include/amd_shared.h
>> index bcdf7453a403..b1c55dd7b498 100644
>> --- a/drivers/gpu/drm/amd/include/amd_shared.h
>> +++ b/drivers/gpu/drm/amd/include/amd_shared.h
>> @@ -247,6 +247,7 @@ enum DC_DEBUG_MASK {
>> DC_DISABLE_DSC = 0x4,
>> DC_DISABLE_CLOCK_GATING = 0x8,
>> DC_DISABLE_PSR = 0x10,
>> + DC_FORCE_SUBVP_MCLK_SWITCH = 0x20,
>> };
>>
>> enum amd_dpm_forced_level;
>> --
>> 2.36.1
>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/amd: Add debug mask for subviewport mclk switch
2022-06-30 19:28 ` Aurabindo Pillai
@ 2022-06-30 19:33 ` Alex Deucher
0 siblings, 0 replies; 8+ messages in thread
From: Alex Deucher @ 2022-06-30 19:33 UTC (permalink / raw)
To: Aurabindo Pillai; +Cc: Wentland, Harry, amd-gfx list
On Thu, Jun 30, 2022 at 3:28 PM Aurabindo Pillai
<aurabindo.pillai@amd.com> wrote:
>
>
>
> On 2022-06-30 14:28, Alex Deucher wrote:
> > On Tue, Jun 28, 2022 at 5:26 PM Aurabindo Pillai
> > <aurabindo.pillai@amd.com> wrote:
> >>
> >> [Why&How]
> >> Expose a new debugfs enum to force a subviewport memory clock switch
> >> to facilitate easy testing.
> >>
> >
> > Is the debugfs support already plumbed in and this just enables you to
> > use it? If it's in debugfs, do we really need a module parameter to
> > enable it or can it just be enabled by default and used via debugfs
> > when needed?
>
> Sorry, I meant to put in debug mask, like in the title. Will fix that.
> There is no debugfs associated with this change. The change in DM is
> enough to enable this.
> >
Thanks. With that fixed,
Acked-by: Alex Deucher <alexander.deucher@amd.com>
> > Alex
> >
> >> Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
> >> ---
> >> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +++
> >> drivers/gpu/drm/amd/include/amd_shared.h | 1 +
> >> 2 files changed, 4 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> >> index c9145864ed2b..7a034ca95be2 100644
> >> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> >> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> >> @@ -1559,6 +1559,9 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
> >> if (amdgpu_dc_debug_mask & DC_DISABLE_CLOCK_GATING)
> >> adev->dm.dc->debug.disable_clock_gate = true;
> >>
> >> + if (amdgpu_dc_debug_mask & DC_FORCE_SUBVP_MCLK_SWITCH)
> >> + adev->dm.dc->debug.force_subvp_mclk_switch = true;
> >> +
> >> r = dm_dmub_hw_init(adev);
> >> if (r) {
> >> DRM_ERROR("DMUB interface failed to initialize: status=%d\n", r);
> >> diff --git a/drivers/gpu/drm/amd/include/amd_shared.h b/drivers/gpu/drm/amd/include/amd_shared.h
> >> index bcdf7453a403..b1c55dd7b498 100644
> >> --- a/drivers/gpu/drm/amd/include/amd_shared.h
> >> +++ b/drivers/gpu/drm/amd/include/amd_shared.h
> >> @@ -247,6 +247,7 @@ enum DC_DEBUG_MASK {
> >> DC_DISABLE_DSC = 0x4,
> >> DC_DISABLE_CLOCK_GATING = 0x8,
> >> DC_DISABLE_PSR = 0x10,
> >> + DC_FORCE_SUBVP_MCLK_SWITCH = 0x20,
> >> };
> >>
> >> enum amd_dpm_forced_level;
> >> --
> >> 2.36.1
> >>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/amd: Add debug mask for subviewport mclk switch
2022-06-28 21:26 [PATCH] drm/amd: Add debug mask for subviewport mclk switch Aurabindo Pillai
2022-06-30 18:24 ` Aurabindo Pillai
2022-06-30 18:28 ` Alex Deucher
@ 2022-07-05 19:53 ` Harry Wentland
2022-07-05 20:24 ` Aurabindo Pillai
2 siblings, 1 reply; 8+ messages in thread
From: Harry Wentland @ 2022-07-05 19:53 UTC (permalink / raw)
To: Aurabindo Pillai, alexdeucher, amd-gfx
On 2022-06-28 17:26, Aurabindo Pillai wrote:
> [Why&How]
> Expose a new debugfs enum to force a subviewport memory clock switch
> to facilitate easy testing.
>
Does this force a single switch? Or at regular intervals?
It would be useful to describe a bit better what it does.
> Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
Either way, since this is for debug purposes only this is
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +++
> drivers/gpu/drm/amd/include/amd_shared.h | 1 +
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index c9145864ed2b..7a034ca95be2 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -1559,6 +1559,9 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
> if (amdgpu_dc_debug_mask & DC_DISABLE_CLOCK_GATING)
> adev->dm.dc->debug.disable_clock_gate = true;
>
> + if (amdgpu_dc_debug_mask & DC_FORCE_SUBVP_MCLK_SWITCH)
> + adev->dm.dc->debug.force_subvp_mclk_switch = true;
> +
> r = dm_dmub_hw_init(adev);
> if (r) {
> DRM_ERROR("DMUB interface failed to initialize: status=%d\n", r);
> diff --git a/drivers/gpu/drm/amd/include/amd_shared.h b/drivers/gpu/drm/amd/include/amd_shared.h
> index bcdf7453a403..b1c55dd7b498 100644
> --- a/drivers/gpu/drm/amd/include/amd_shared.h
> +++ b/drivers/gpu/drm/amd/include/amd_shared.h
> @@ -247,6 +247,7 @@ enum DC_DEBUG_MASK {
> DC_DISABLE_DSC = 0x4,
> DC_DISABLE_CLOCK_GATING = 0x8,
> DC_DISABLE_PSR = 0x10,
> + DC_FORCE_SUBVP_MCLK_SWITCH = 0x20,
> };
>
> enum amd_dpm_forced_level;
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/amd: Add debug mask for subviewport mclk switch
2022-07-05 19:53 ` Harry Wentland
@ 2022-07-05 20:24 ` Aurabindo Pillai
2022-07-05 21:22 ` Harry Wentland
0 siblings, 1 reply; 8+ messages in thread
From: Aurabindo Pillai @ 2022-07-05 20:24 UTC (permalink / raw)
To: Harry Wentland, alexdeucher, amd-gfx
On 2022-07-05 15:53, Harry Wentland wrote:
>
>
> On 2022-06-28 17:26, Aurabindo Pillai wrote:
>> [Why&How]
>> Expose a new debugfs enum to force a subviewport memory clock switch
>> to facilitate easy testing.
>>
>
> Does this force a single switch? Or at regular intervals?
If this debug option is set, each time a MCLK switch happens, a SubVP
sequences shall be initiated. That is, during the MCLK switch the
scanout shall be from the Subviewport memory. Setting this option doesnt
trigger an MCLK switch though.
>
> It would be useful to describe a bit better what it does.
Will keep that in mind, thanks! Unfortunately I merged it already since
I got the ack last week.
>
>> Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
>
> Either way, since this is for debug purposes only this is
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
>> ---
>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +++
>> drivers/gpu/drm/amd/include/amd_shared.h | 1 +
>> 2 files changed, 4 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> index c9145864ed2b..7a034ca95be2 100644
>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> @@ -1559,6 +1559,9 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
>> if (amdgpu_dc_debug_mask & DC_DISABLE_CLOCK_GATING)
>> adev->dm.dc->debug.disable_clock_gate = true;
>>
>> + if (amdgpu_dc_debug_mask & DC_FORCE_SUBVP_MCLK_SWITCH)
>> + adev->dm.dc->debug.force_subvp_mclk_switch = true;
>> +
>> r = dm_dmub_hw_init(adev);
>> if (r) {
>> DRM_ERROR("DMUB interface failed to initialize: status=%d\n", r);
>> diff --git a/drivers/gpu/drm/amd/include/amd_shared.h b/drivers/gpu/drm/amd/include/amd_shared.h
>> index bcdf7453a403..b1c55dd7b498 100644
>> --- a/drivers/gpu/drm/amd/include/amd_shared.h
>> +++ b/drivers/gpu/drm/amd/include/amd_shared.h
>> @@ -247,6 +247,7 @@ enum DC_DEBUG_MASK {
>> DC_DISABLE_DSC = 0x4,
>> DC_DISABLE_CLOCK_GATING = 0x8,
>> DC_DISABLE_PSR = 0x10,
>> + DC_FORCE_SUBVP_MCLK_SWITCH = 0x20,
>> };
>>
>> enum amd_dpm_forced_level;
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/amd: Add debug mask for subviewport mclk switch
2022-07-05 20:24 ` Aurabindo Pillai
@ 2022-07-05 21:22 ` Harry Wentland
0 siblings, 0 replies; 8+ messages in thread
From: Harry Wentland @ 2022-07-05 21:22 UTC (permalink / raw)
To: Aurabindo Pillai, Harry Wentland, alexdeucher, amd-gfx
On 7/5/22 16:24, Aurabindo Pillai wrote:
>
>
> On 2022-07-05 15:53, Harry Wentland wrote:
>>
>>
>> On 2022-06-28 17:26, Aurabindo Pillai wrote:
>>> [Why&How]
>>> Expose a new debugfs enum to force a subviewport memory clock switch
>>> to facilitate easy testing.
>>>
>>
>> Does this force a single switch? Or at regular intervals?
>
> If this debug option is set, each time a MCLK switch happens, a SubVP sequences shall be initiated. That is, during the MCLK switch the scanout shall be from the Subviewport memory. Setting this option doesnt trigger an MCLK switch though.
>
>>
>> It would be useful to describe a bit better what it does.
>
> Will keep that in mind, thanks! Unfortunately I merged it already since I got the ack last week.
> No worries :)
Harry
>>
>>> Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
>>
>> Either way, since this is for debug purposes only this is
>> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>>
>> Harry
>>
>>> ---
>>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +++
>>> drivers/gpu/drm/amd/include/amd_shared.h | 1 +
>>> 2 files changed, 4 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>>> index c9145864ed2b..7a034ca95be2 100644
>>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>>> @@ -1559,6 +1559,9 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
>>> if (amdgpu_dc_debug_mask & DC_DISABLE_CLOCK_GATING)
>>> adev->dm.dc->debug.disable_clock_gate = true;
>>> + if (amdgpu_dc_debug_mask & DC_FORCE_SUBVP_MCLK_SWITCH)
>>> + adev->dm.dc->debug.force_subvp_mclk_switch = true;
>>> +
>>> r = dm_dmub_hw_init(adev);
>>> if (r) {
>>> DRM_ERROR("DMUB interface failed to initialize: status=%d\n", r);
>>> diff --git a/drivers/gpu/drm/amd/include/amd_shared.h b/drivers/gpu/drm/amd/include/amd_shared.h
>>> index bcdf7453a403..b1c55dd7b498 100644
>>> --- a/drivers/gpu/drm/amd/include/amd_shared.h
>>> +++ b/drivers/gpu/drm/amd/include/amd_shared.h
>>> @@ -247,6 +247,7 @@ enum DC_DEBUG_MASK {
>>> DC_DISABLE_DSC = 0x4,
>>> DC_DISABLE_CLOCK_GATING = 0x8,
>>> DC_DISABLE_PSR = 0x10,
>>> + DC_FORCE_SUBVP_MCLK_SWITCH = 0x20,
>>> };
>>> enum amd_dpm_forced_level;
>>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-07-05 21:22 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-28 21:26 [PATCH] drm/amd: Add debug mask for subviewport mclk switch Aurabindo Pillai
2022-06-30 18:24 ` Aurabindo Pillai
2022-06-30 18:28 ` Alex Deucher
2022-06-30 19:28 ` Aurabindo Pillai
2022-06-30 19:33 ` Alex Deucher
2022-07-05 19:53 ` Harry Wentland
2022-07-05 20:24 ` Aurabindo Pillai
2022-07-05 21:22 ` Harry Wentland
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.