* [PATCH -next resend] media: ar0521: fix error return code in ar0521_power_on()
@ 2022-09-17 7:14 Yang Yingliang
2022-09-20 11:49 ` Sakari Ailus
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2022-09-17 7:14 UTC (permalink / raw)
To: linux-media; +Cc: khalasa, mchehab, sakari.ailus
Return error code if ar0521_write_regs() fails in ar0521_power_on().
Fixes: 852b50aeed15 ("media: On Semi AR0521 sensor driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Acked-by: Krzysztof Hałasa <khalasa@piap.pl>
---
+cc: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/media/i2c/ar0521.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/ar0521.c b/drivers/media/i2c/ar0521.c
index c7bdfc69b9be..e850c92d847e 100644
--- a/drivers/media/i2c/ar0521.c
+++ b/drivers/media/i2c/ar0521.c
@@ -757,8 +757,9 @@ static int ar0521_power_on(struct device *dev)
usleep_range(4500, 5000); /* min 45000 clocks */
for (cnt = 0; cnt < ARRAY_SIZE(initial_regs); cnt++)
- if (ar0521_write_regs(sensor, initial_regs[cnt].data,
- initial_regs[cnt].count))
+ ret = ar0521_write_regs(sensor, initial_regs[cnt].data,
+ initial_regs[cnt].count);
+ if (ret)
goto off;
ret = ar0521_write_reg(sensor, AR0521_REG_SERIAL_FORMAT,
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next resend] media: ar0521: fix error return code in ar0521_power_on()
2022-09-17 7:14 [PATCH -next resend] media: ar0521: fix error return code in ar0521_power_on() Yang Yingliang
@ 2022-09-20 11:49 ` Sakari Ailus
0 siblings, 0 replies; 2+ messages in thread
From: Sakari Ailus @ 2022-09-20 11:49 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-media, khalasa, mchehab, sakari.ailus
On Sat, Sep 17, 2022 at 03:14:32PM +0800, Yang Yingliang wrote:
> Return error code if ar0521_write_regs() fails in ar0521_power_on().
>
> Fixes: 852b50aeed15 ("media: On Semi AR0521 sensor driver")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> Acked-by: Krzysztof Hałasa <khalasa@piap.pl>
This is already in my pull request to Mauro.
--
Sakari Ailus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-20 11:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-17 7:14 [PATCH -next resend] media: ar0521: fix error return code in ar0521_power_on() Yang Yingliang
2022-09-20 11:49 ` Sakari Ailus
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.