* [PATCH 1/2] dt-bindings: mfd: qcom,spmi-pmic: adjust pwm node validation
@ 2022-09-25 21:17 Luca Weiss
2022-09-25 21:17 ` [PATCH 2/2] dt-bindings: mfd: qcom,spmi-pmic: support more types Luca Weiss
2022-09-26 8:49 ` [PATCH 1/2] dt-bindings: mfd: qcom,spmi-pmic: adjust pwm node validation Krzysztof Kozlowski
0 siblings, 2 replies; 6+ messages in thread
From: Luca Weiss @ 2022-09-25 21:17 UTC (permalink / raw)
To: linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Luca Weiss, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Lee Jones, Rob Herring,
Krzysztof Kozlowski, Stephen Boyd, devicetree, linux-kernel
The LPG node doesn't use reg, so adjust the documentation to match that.
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index 6a3e3ede1ede..16ade0fa2d33 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -94,6 +94,10 @@ properties:
type: object
$ref: /schemas/regulator/qcom-labibb-regulator.yaml#
+ pwm:
+ type: object
+ $ref: /schemas/leds/leds-qcom-lpg.yaml#
+
regulators:
type: object
$ref: /schemas/regulator/qcom,spmi-regulator.yaml#
@@ -123,10 +127,6 @@ patternProperties:
type: object
$ref: /schemas/power/reset/qcom,pon.yaml#
- "pwm@[0-9a-f]+$":
- type: object
- $ref: /schemas/leds/leds-qcom-lpg.yaml#
-
"^rtc@[0-9a-f]+$":
type: object
$ref: /schemas/rtc/qcom-pm8xxx-rtc.yaml#
--
2.37.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] dt-bindings: mfd: qcom,spmi-pmic: support more types
2022-09-25 21:17 [PATCH 1/2] dt-bindings: mfd: qcom,spmi-pmic: adjust pwm node validation Luca Weiss
@ 2022-09-25 21:17 ` Luca Weiss
2022-09-26 8:51 ` Krzysztof Kozlowski
2022-09-26 8:49 ` [PATCH 1/2] dt-bindings: mfd: qcom,spmi-pmic: adjust pwm node validation Krzysztof Kozlowski
1 sibling, 1 reply; 6+ messages in thread
From: Luca Weiss @ 2022-09-25 21:17 UTC (permalink / raw)
To: linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Luca Weiss, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Lee Jones, Rob Herring,
Krzysztof Kozlowski, Stephen Boyd, devicetree, linux-kernel
* 'adc@' is either spmi-iadc or spmi-vadc
* 'charger@' is either pm8941-charger or pm8941-coincell
* 'dcdc@' is usb-vbus-regulator
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
.../devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index 16ade0fa2d33..e54fb5d64ef8 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -105,7 +105,9 @@ properties:
patternProperties:
"^adc@[0-9a-f]+$":
type: object
- $ref: /schemas/iio/adc/qcom,spmi-vadc.yaml#
+ oneOf:
+ - $ref: /schemas/iio/adc/qcom,spmi-iadc.yaml#
+ - $ref: /schemas/iio/adc/qcom,spmi-vadc.yaml#
"^adc-tm@[0-9a-f]+$":
type: object
@@ -115,6 +117,16 @@ patternProperties:
type: object
additionalProperties: true # FIXME qcom,pm8916-wcd-analog-codec binding not converted yet
+ "charger@[0-9a-f]+$":
+ type: object
+ oneOf:
+ - $ref: /schemas/power/supply/qcom,pm8941-charger.yaml#
+ - $ref: /schemas/power/supply/qcom,pm8941-coincell.yaml#
+
+ "^dcdc@[0-9a-f]+$":
+ type: object
+ $ref: /schemas/regulator/qcom,usb-vbus-regulator.yaml#
+
"extcon@[0-9a-f]+$":
type: object
$ref: /schemas/extcon/qcom,pm8941-misc.yaml#
--
2.37.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: mfd: qcom,spmi-pmic: adjust pwm node validation
2022-09-25 21:17 [PATCH 1/2] dt-bindings: mfd: qcom,spmi-pmic: adjust pwm node validation Luca Weiss
2022-09-25 21:17 ` [PATCH 2/2] dt-bindings: mfd: qcom,spmi-pmic: support more types Luca Weiss
@ 2022-09-26 8:49 ` Krzysztof Kozlowski
2022-09-26 14:59 ` Luca Weiss
1 sibling, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 8:49 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Lee Jones, Rob Herring,
Krzysztof Kozlowski, Stephen Boyd, devicetree, linux-kernel
On 25/09/2022 23:17, Luca Weiss wrote:
> The LPG node doesn't use reg, so adjust the documentation to match that.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 8 ++++----
Already sent:
https://lore.kernel.org/all/20220828132648.3624126-2-bryan.odonoghue@linaro.org/
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] dt-bindings: mfd: qcom,spmi-pmic: support more types
2022-09-25 21:17 ` [PATCH 2/2] dt-bindings: mfd: qcom,spmi-pmic: support more types Luca Weiss
@ 2022-09-26 8:51 ` Krzysztof Kozlowski
2022-09-26 15:00 ` Luca Weiss
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 8:51 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Lee Jones, Rob Herring,
Krzysztof Kozlowski, Stephen Boyd, devicetree, linux-kernel
On 25/09/2022 23:17, Luca Weiss wrote:
Thank you for your patch. There is something to discuss/improve.
> additionalProperties: true # FIXME qcom,pm8916-wcd-analog-codec binding not converted yet
>
> + "charger@[0-9a-f]+$":
> + type: object
> + oneOf:
> + - $ref: /schemas/power/supply/qcom,pm8941-charger.yaml#
> + - $ref: /schemas/power/supply/qcom,pm8941-coincell.yaml#
> +
> + "^dcdc@[0-9a-f]+$":
> + type: object
How about renaming this one to usb-vbus-regulator?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: mfd: qcom,spmi-pmic: adjust pwm node validation
2022-09-26 8:49 ` [PATCH 1/2] dt-bindings: mfd: qcom,spmi-pmic: adjust pwm node validation Krzysztof Kozlowski
@ 2022-09-26 14:59 ` Luca Weiss
0 siblings, 0 replies; 6+ messages in thread
From: Luca Weiss @ 2022-09-26 14:59 UTC (permalink / raw)
To: linux-arm-msm, Krzysztof Kozlowski
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Lee Jones, Rob Herring,
Krzysztof Kozlowski, Stephen Boyd, devicetree, linux-kernel
On Montag, 26. September 2022 10:49:11 CEST Krzysztof Kozlowski wrote:
> On 25/09/2022 23:17, Luca Weiss wrote:
> > The LPG node doesn't use reg, so adjust the documentation to match that.
> >
> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > ---
> >
> > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 8 ++++----
>
> Already sent:
>
> https://lore.kernel.org/all/20220828132648.3624126-2-bryan.odonoghue@linaro.
> org/
Thanks for spotting! I retract my patch then :)
Any idea who will merge the other patch then? It's been a month since sending
and it hasn't been applied yet / not in linux-next yet.
Regards
Luca
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] dt-bindings: mfd: qcom,spmi-pmic: support more types
2022-09-26 8:51 ` Krzysztof Kozlowski
@ 2022-09-26 15:00 ` Luca Weiss
0 siblings, 0 replies; 6+ messages in thread
From: Luca Weiss @ 2022-09-26 15:00 UTC (permalink / raw)
To: linux-arm-msm, Krzysztof Kozlowski
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Lee Jones, Rob Herring,
Krzysztof Kozlowski, Stephen Boyd, devicetree, linux-kernel
On Montag, 26. September 2022 10:51:45 CEST Krzysztof Kozlowski wrote:
> On 25/09/2022 23:17, Luca Weiss wrote:
>
> Thank you for your patch. There is something to discuss/improve.
>
> > additionalProperties: true # FIXME qcom,pm8916-wcd-analog-codec
> > binding not converted yet>
> > + "charger@[0-9a-f]+$":
> > + type: object
> > + oneOf:
> > + - $ref: /schemas/power/supply/qcom,pm8941-charger.yaml#
> > + - $ref: /schemas/power/supply/qcom,pm8941-coincell.yaml#
> > +
> > + "^dcdc@[0-9a-f]+$":
> > + type: object
>
> How about renaming this one to usb-vbus-regulator?
Sounds good to me. I was actually hoping somebody would suggest a better name.
Should I wait a bit to see if anybody else has a better suggestion or send a
v2 now?
Regards
Luca
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-26 16:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-25 21:17 [PATCH 1/2] dt-bindings: mfd: qcom,spmi-pmic: adjust pwm node validation Luca Weiss
2022-09-25 21:17 ` [PATCH 2/2] dt-bindings: mfd: qcom,spmi-pmic: support more types Luca Weiss
2022-09-26 8:51 ` Krzysztof Kozlowski
2022-09-26 15:00 ` Luca Weiss
2022-09-26 8:49 ` [PATCH 1/2] dt-bindings: mfd: qcom,spmi-pmic: adjust pwm node validation Krzysztof Kozlowski
2022-09-26 14:59 ` Luca Weiss
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.