* [PATCH net] octeontx2-af: cn10k: mcs: Fix error return code in mcs_register_interrupts()
@ 2022-10-09 1:51 Yang Yingliang
2022-10-10 7:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2022-10-09 1:51 UTC (permalink / raw)
To: netdev; +Cc: gakula, vattunuru, sgoutham, sbhatta, davem
If alloc_mem() fails in mcs_register_interrupts(), it should return error
code.
Fixes: 6c635f78c474 ("octeontx2-af: cn10k: mcs: Handle MCS block interrupts")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/net/ethernet/marvell/octeontx2/af/mcs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/mcs.c b/drivers/net/ethernet/marvell/octeontx2/af/mcs.c
index 5ba618aed6ad..4a343f853b28 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/mcs.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/mcs.c
@@ -1182,8 +1182,10 @@ static int mcs_register_interrupts(struct mcs *mcs)
mcs_reg_write(mcs, MCSX_PAB_TX_SLAVE_PAB_INT_ENB, 0xff);
mcs->tx_sa_active = alloc_mem(mcs, mcs->hw->sc_entries);
- if (!mcs->tx_sa_active)
+ if (!mcs->tx_sa_active) {
+ ret = -ENOMEM;
goto exit;
+ }
return ret;
exit:
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] octeontx2-af: cn10k: mcs: Fix error return code in mcs_register_interrupts()
2022-10-09 1:51 [PATCH net] octeontx2-af: cn10k: mcs: Fix error return code in mcs_register_interrupts() Yang Yingliang
@ 2022-10-10 7:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-10-10 7:40 UTC (permalink / raw)
To: Yang Yingliang; +Cc: netdev, gakula, vattunuru, sgoutham, sbhatta, davem
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Sun, 9 Oct 2022 09:51:26 +0800 you wrote:
> If alloc_mem() fails in mcs_register_interrupts(), it should return error
> code.
>
> Fixes: 6c635f78c474 ("octeontx2-af: cn10k: mcs: Handle MCS block interrupts")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/net/ethernet/marvell/octeontx2/af/mcs.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Here is the summary with links:
- [net] octeontx2-af: cn10k: mcs: Fix error return code in mcs_register_interrupts()
https://git.kernel.org/netdev/net/c/b2cf5d902ec1
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-10 7:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-09 1:51 [PATCH net] octeontx2-af: cn10k: mcs: Fix error return code in mcs_register_interrupts() Yang Yingliang
2022-10-10 7:40 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.