From: Christoph Hellwig via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Dave Kleikamp <shaggy@kernel.org>,
jfs-discussion@lists.sourceforge.net,
Evgeniy Dushistov <dushistov@mail.ru>,
Josef Bacik <josef@toxicpanda.com>,
linux-mm@kvack.org, Chris Mason <clm@fb.com>,
ocfs2-devel@oss.oracle.com, David Sterba <dsterba@suse.com>,
linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [Ocfs2-devel] [PATCH 4/7] sysv: don't flush page immediately for DIRSYNC directories
Date: Tue, 10 Jan 2023 09:24:28 +0100 [thread overview]
Message-ID: <20230110082428.GC11947@lst.de> (raw)
In-Reply-To: <Y7szWmUKSwcxsaMu@casper.infradead.org>
On Sun, Jan 08, 2023 at 09:19:22PM +0000, Matthew Wilcox wrote:
> On Sun, Jan 08, 2023 at 05:56:42PM +0100, Christoph Hellwig wrote:
> > We do not need to writeout modified directory blocks immediately when
> > modifying them while the page is locked. It is enough to do the flush
> > somewhat later which has the added benefit that inode times can be
> > flushed as well. It also allows us to stop depending on
> > write_one_page() function.
>
> Similar concerns to the minix patch here ... missing assignments to
> 'err'.
Fixed.
_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>,
Andrew Morton <akpm@linux-foundation.org>,
Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
Dave Kleikamp <shaggy@kernel.org>, Mark Fasheh <mark@fasheh.com>,
Joel Becker <jlbec@evilplan.org>,
Joseph Qi <joseph.qi@linux.alibaba.com>,
Evgeniy Dushistov <dushistov@mail.ru>,
linux-btrfs@vger.kernel.org,
jfs-discussion@lists.sourceforge.net, ocfs2-devel@oss.oracle.com,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 4/7] sysv: don't flush page immediately for DIRSYNC directories
Date: Tue, 10 Jan 2023 09:24:28 +0100 [thread overview]
Message-ID: <20230110082428.GC11947@lst.de> (raw)
In-Reply-To: <Y7szWmUKSwcxsaMu@casper.infradead.org>
On Sun, Jan 08, 2023 at 09:19:22PM +0000, Matthew Wilcox wrote:
> On Sun, Jan 08, 2023 at 05:56:42PM +0100, Christoph Hellwig wrote:
> > We do not need to writeout modified directory blocks immediately when
> > modifying them while the page is locked. It is enough to do the flush
> > somewhat later which has the added benefit that inode times can be
> > flushed as well. It also allows us to stop depending on
> > write_one_page() function.
>
> Similar concerns to the minix patch here ... missing assignments to
> 'err'.
Fixed.
next prev parent reply other threads:[~2023-01-10 8:24 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-08 16:56 remove write_one_page / folio_write_one Christoph Hellwig
2023-01-08 16:56 ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2023-01-08 16:56 ` [PATCH 1/7] btrfs: don't read the disk superblock for zoned devices in btrfs_scratch_superblocks Christoph Hellwig
2023-01-08 16:56 ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2023-01-08 16:56 ` [PATCH 2/7] btrfs: stop using write_one_page in btrfs_scratch_superblock Christoph Hellwig
2023-01-08 16:56 ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2023-01-08 21:13 ` Matthew Wilcox via Ocfs2-devel
2023-01-08 21:13 ` Matthew Wilcox
2023-01-08 16:56 ` [PATCH 3/7] minix: don't flush page immediately for DIRSYNC directories Christoph Hellwig
2023-01-08 16:56 ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2023-01-08 21:17 ` Matthew Wilcox
2023-01-08 21:17 ` [Ocfs2-devel] " Matthew Wilcox via Ocfs2-devel
2023-01-10 8:22 ` Christoph Hellwig
2023-01-10 8:22 ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2023-01-11 2:20 ` Al Viro
2023-01-11 2:20 ` [Ocfs2-devel] " Al Viro via Ocfs2-devel
2023-01-11 4:26 ` Christoph Hellwig via Ocfs2-devel
2023-01-11 4:26 ` Christoph Hellwig
2023-01-11 4:58 ` Al Viro
2023-01-11 4:58 ` [Ocfs2-devel] " Al Viro via Ocfs2-devel
2023-01-08 16:56 ` [PATCH 4/7] sysv: " Christoph Hellwig
2023-01-08 16:56 ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2023-01-08 21:19 ` Matthew Wilcox
2023-01-08 21:19 ` [Ocfs2-devel] " Matthew Wilcox via Ocfs2-devel
2023-01-10 8:24 ` Christoph Hellwig via Ocfs2-devel [this message]
2023-01-10 8:24 ` Christoph Hellwig
2023-01-08 16:56 ` [PATCH 5/7] ufs: " Christoph Hellwig
2023-01-08 16:56 ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2023-01-08 16:56 ` [PATCH 6/7] ocfs2: don't use write_one_page in ocfs2_duplicate_clusters_by_page Christoph Hellwig
2023-01-08 16:56 ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2023-01-09 17:03 ` Jan Kara via Ocfs2-devel
2023-01-09 17:03 ` Jan Kara
2023-01-10 3:03 ` [Ocfs2-devel] " Joseph Qi via Ocfs2-devel
2023-01-10 3:03 ` Joseph Qi
2023-01-08 16:56 ` [PATCH 7/7] mm,jfs: move write_one_page/folio_write_one to jfs Christoph Hellwig
2023-01-08 16:56 ` [Ocfs2-devel] [PATCH 7/7] mm, jfs: " Christoph Hellwig via Ocfs2-devel
2023-01-08 21:31 ` remove write_one_page / folio_write_one Matthew Wilcox
2023-01-08 21:31 ` [Ocfs2-devel] " Matthew Wilcox via Ocfs2-devel
2023-01-09 19:53 ` David Sterba
2023-01-09 19:53 ` [Ocfs2-devel] " David Sterba via Ocfs2-devel
2023-01-10 8:16 ` Christoph Hellwig
2023-01-10 8:16 ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2023-01-10 13:00 ` David Sterba
2023-01-10 13:00 ` [Ocfs2-devel] " David Sterba via Ocfs2-devel
2023-01-10 15:32 ` Christoph Hellwig via Ocfs2-devel
2023-01-10 15:32 ` Christoph Hellwig
2023-01-11 19:20 ` David Sterba
2023-01-11 19:20 ` [Ocfs2-devel] " David Sterba via Ocfs2-devel
2023-01-12 8:02 ` Christoph Hellwig
2023-01-12 8:02 ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230110082428.GC11947@lst.de \
--to=ocfs2-devel@oss.oracle.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=dushistov@mail.ru \
--cc=hch@lst.de \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shaggy@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.