From: Nathan Chancellor <nathan@kernel.org> To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Cc: djakov@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, matthias.bgg@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, keescook@chromium.org, gustavoars@kernel.org, henryc.chen@mediatek.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com, wenst@chromium.org, amergnat@baylibre.com, Dawei Chien <dawei.chien@mediatek.com> Subject: Re: [PATCH v5 4/7] soc: mediatek: Add MediaTek DVFS Resource Collector (DVFSRC) driver Date: Wed, 24 Apr 2024 12:04:05 -0700 [thread overview] Message-ID: <20240424190405.GA2803128@dev-arch.thelio-3990X> (raw) In-Reply-To: <20240424095416.1105639-5-angelogioacchino.delregno@collabora.com> Hi Angelo, On Wed, Apr 24, 2024 at 11:54:13AM +0200, AngeloGioacchino Del Regno wrote: > The Dynamic Voltage and Frequency Scaling Resource Collector (DVFSRC) is a > Hardware module used to collect all the requests from both software and the > various remote processors embedded into the SoC and decide about a minimum > operating voltage and a minimum DRAM frequency to fulfill those requests in > an effort to provide the best achievable performance per watt. > > This hardware IP is capable of transparently performing direct register R/W > on all of the DVFSRC-controlled regulators and SoC bandwidth knobs. > > This driver includes support for MT8183, MT8192 and MT8195. > > Co-Developed-by: Dawei Chien <dawei.chien@mediatek.com> > [Angelo: Partial refactoring and cleanups] > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> ... > drivers/soc/mediatek/mtk-dvfsrc.c | 551 +++++++++++++++++++++++ ... > +#define KBPS_TO_MBPS(x) ((x) / 1000) ... > +static void __dvfsrc_set_dram_bw_v1(struct mtk_dvfsrc *dvfsrc, u32 reg, > + u16 max_bw, u16 min_bw, u64 bw) > +{ > + u32 new_bw = (u32)div_u64(KBPS_TO_MBPS(bw), 100); > + > + /* If bw constraints (in mbps) are defined make sure to respect them */ > + if (max_bw) > + new_bw = min(new_bw, max_bw); > + if (min_bw && new_bw > 0) > + new_bw = max(new_bw, min_bw); > + > + dvfsrc_writel(dvfsrc, reg, new_bw); > +} Using KBPS_TO_MBPS here results in ERROR: modpost: "__aeabi_uldivmod" [drivers/soc/mediatek/mtk-dvfsrc.ko] undefined! when building ARCH=arm allmodconfig with clang. I did not check to see if this is visible with GCC but if it is not, it is only because GCC implements certain transformations for constant division that clang may or may not have implemented (there was some work on getting all transformations that GCC has supported in clang as well but I do not think was ever completed). Perhaps KBPS_TO_MBPS() should be dropped and the new_bw assignement turned into u32 new_bw = (u32)div_u64(bw, 100 * 1000); /* Multiply divisor by 1000 to convert bw from Kbps to Mbps */ or something like that. Cheers, Nathan
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <nathan@kernel.org> To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Cc: djakov@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, matthias.bgg@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, keescook@chromium.org, gustavoars@kernel.org, henryc.chen@mediatek.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com, wenst@chromium.org, amergnat@baylibre.com, Dawei Chien <dawei.chien@mediatek.com> Subject: Re: [PATCH v5 4/7] soc: mediatek: Add MediaTek DVFS Resource Collector (DVFSRC) driver Date: Wed, 24 Apr 2024 12:04:05 -0700 [thread overview] Message-ID: <20240424190405.GA2803128@dev-arch.thelio-3990X> (raw) In-Reply-To: <20240424095416.1105639-5-angelogioacchino.delregno@collabora.com> Hi Angelo, On Wed, Apr 24, 2024 at 11:54:13AM +0200, AngeloGioacchino Del Regno wrote: > The Dynamic Voltage and Frequency Scaling Resource Collector (DVFSRC) is a > Hardware module used to collect all the requests from both software and the > various remote processors embedded into the SoC and decide about a minimum > operating voltage and a minimum DRAM frequency to fulfill those requests in > an effort to provide the best achievable performance per watt. > > This hardware IP is capable of transparently performing direct register R/W > on all of the DVFSRC-controlled regulators and SoC bandwidth knobs. > > This driver includes support for MT8183, MT8192 and MT8195. > > Co-Developed-by: Dawei Chien <dawei.chien@mediatek.com> > [Angelo: Partial refactoring and cleanups] > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> ... > drivers/soc/mediatek/mtk-dvfsrc.c | 551 +++++++++++++++++++++++ ... > +#define KBPS_TO_MBPS(x) ((x) / 1000) ... > +static void __dvfsrc_set_dram_bw_v1(struct mtk_dvfsrc *dvfsrc, u32 reg, > + u16 max_bw, u16 min_bw, u64 bw) > +{ > + u32 new_bw = (u32)div_u64(KBPS_TO_MBPS(bw), 100); > + > + /* If bw constraints (in mbps) are defined make sure to respect them */ > + if (max_bw) > + new_bw = min(new_bw, max_bw); > + if (min_bw && new_bw > 0) > + new_bw = max(new_bw, min_bw); > + > + dvfsrc_writel(dvfsrc, reg, new_bw); > +} Using KBPS_TO_MBPS here results in ERROR: modpost: "__aeabi_uldivmod" [drivers/soc/mediatek/mtk-dvfsrc.ko] undefined! when building ARCH=arm allmodconfig with clang. I did not check to see if this is visible with GCC but if it is not, it is only because GCC implements certain transformations for constant division that clang may or may not have implemented (there was some work on getting all transformations that GCC has supported in clang as well but I do not think was ever completed). Perhaps KBPS_TO_MBPS() should be dropped and the new_bw assignement turned into u32 new_bw = (u32)div_u64(bw, 100 * 1000); /* Multiply divisor by 1000 to convert bw from Kbps to Mbps */ or something like that. Cheers, Nathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-04-24 19:04 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-04-24 9:54 [PATCH v5 0/7] MediaTek DVFSRC Bus Bandwidth and Regulator knobs AngeloGioacchino Del Regno 2024-04-24 9:54 ` AngeloGioacchino Del Regno 2024-04-24 9:54 ` [PATCH v5 1/7] dt-bindings: regulator: Add bindings for MediaTek DVFSRC Regulators AngeloGioacchino Del Regno 2024-04-24 9:54 ` AngeloGioacchino Del Regno 2024-04-24 9:54 ` [PATCH v5 2/7] dt-bindings: interconnect: Add MediaTek EMI Interconnect bindings AngeloGioacchino Del Regno 2024-04-24 9:54 ` AngeloGioacchino Del Regno 2024-04-24 9:54 ` [PATCH v5 3/7] dt-bindings: soc: mediatek: Add DVFSRC bindings for MT8183 and MT8195 AngeloGioacchino Del Regno 2024-04-24 9:54 ` AngeloGioacchino Del Regno 2024-04-24 9:54 ` [PATCH v5 4/7] soc: mediatek: Add MediaTek DVFS Resource Collector (DVFSRC) driver AngeloGioacchino Del Regno 2024-04-24 9:54 ` AngeloGioacchino Del Regno 2024-04-24 19:04 ` Nathan Chancellor [this message] 2024-04-24 19:04 ` Nathan Chancellor 2024-04-29 8:08 ` AngeloGioacchino Del Regno 2024-04-29 8:08 ` AngeloGioacchino Del Regno 2024-04-29 14:13 ` Georgi Djakov 2024-04-29 14:13 ` Georgi Djakov 2024-04-24 9:54 ` [PATCH v5 5/7] regulator: Remove mtk-dvfsrc-regulator.c AngeloGioacchino Del Regno 2024-04-24 9:54 ` AngeloGioacchino Del Regno 2024-04-24 9:54 ` [PATCH v5 6/7] regulator: Add refactored mtk-dvfsrc-regulator driver AngeloGioacchino Del Regno 2024-04-24 9:54 ` AngeloGioacchino Del Regno 2024-04-24 10:35 ` Christophe JAILLET 2024-04-24 10:35 ` Christophe JAILLET 2024-04-24 12:53 ` AngeloGioacchino Del Regno 2024-04-24 12:53 ` AngeloGioacchino Del Regno 2024-04-24 12:54 ` AngeloGioacchino Del Regno 2024-04-24 12:54 ` AngeloGioacchino Del Regno 2024-04-24 9:54 ` [PATCH v5 7/7] interconnect: mediatek: Add MediaTek MT8183/8195 EMI Interconnect driver AngeloGioacchino Del Regno 2024-04-24 9:54 ` AngeloGioacchino Del Regno 2024-05-03 11:53 ` Georgi Djakov 2024-05-03 11:53 ` Georgi Djakov 2024-05-06 10:49 ` AngeloGioacchino Del Regno 2024-05-06 10:49 ` AngeloGioacchino Del Regno
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240424190405.GA2803128@dev-arch.thelio-3990X \ --to=nathan@kernel.org \ --cc=amergnat@baylibre.com \ --cc=angelogioacchino.delregno@collabora.com \ --cc=broonie@kernel.org \ --cc=conor+dt@kernel.org \ --cc=dawei.chien@mediatek.com \ --cc=devicetree@vger.kernel.org \ --cc=djakov@kernel.org \ --cc=gustavoars@kernel.org \ --cc=henryc.chen@mediatek.com \ --cc=keescook@chromium.org \ --cc=kernel@collabora.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=matthias.bgg@gmail.com \ --cc=robh@kernel.org \ --cc=wenst@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.