All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Dominique MARTINET'" <dominique.martinet@atmark-techno.com>,
	"'Jianxiong Gao'" <jxgao@google.com>
Cc: "'Christoph Hellwig'" <hch@lst.de>,
	"'Konrad Rzeszutek Wilk'" <konrad@darnok.org>,
	"'Konrad Rzeszutek Wilk'" <konrad.wilk@oracle.com>,
	"'Linus Torvalds'" <torvalds@linux-foundation.org>,
	"'Horia Geantă'" <horia.geanta@nxp.com>,
	linux-kernel@vger.kernel.org,
	"'Lukas Hartmann'" <lukas@mntmn.com>,
	"'Aymen Sghaier'" <aymen.sghaier@nxp.com>,
	"'Herbert Xu'" <herbert@gondor.apana.org.au>,
	"'David S. Miller'" <davem@davemloft.net>,
	linux-crypto@vger.kernel.org, iommu@lists.linux-foundation.org,
	"'Marc Orr'" <marcorr@google.com>,
	"'Erdem Aktas'" <erdemaktas@google.com>,
	"'Peter Gonda'" <pgonda@google.com>,
	"'Bumyong Lee'" <bumyong.lee@samsung.com>
Subject: RE: swiotlb/caamjr regression (Was: [GIT PULL] (swiotlb) stable/for-linus-5.12)
Date: Mon, 21 Jun 2021 11:55:22 +0900	[thread overview]
Message-ID: <2038148563.21624247281621.JavaMail.epsvc@epcpadp4> (raw)
In-Reply-To: <YM/zWyZlk1bzHWgI@atmark-techno.com>

+ Bumyong who is the original author of the patch. 

Hi Dominique,

> Thanks!
> (a bit late, but added Chanho Park in Cc...)
> 
> I can confirm it also works for our caam problem, as Horia said.
> 
> I've also come to term with the use of swiotlb_align_offset() through
> testing, or rather many devices seem to have a 0 mask so it will almost
> always be cancelled out, so if it works for Jianxiong then it's probably
> good enough and I'll just assume that's how the orig_addr has been
> designed...
> 
> I think it's missing a couple of checks like the one Linus had in his
> patch, and would be comfortable with something like the attached patch (in
> practice for me exactly the same as the original patch, except I've added
> two checks: offsets smaller than orig addr offset are refused as well as
> offsets bigger than the mapping size)
> 
> I'm sorry Jianxiong but would you be willing to take the time to test
> again just to make sure there were no such offsets in your case?
> 
> 
> If we're good with that I'll send it as an official v2 keeping Chanho's
> from, unless he wants to.
> 

Sure. No problem. But, the patch was already stacked on Konrad's tree
and linux-next as well.

https://git.kernel.org/pub/scm/linux/kernel/git/konrad/swiotlb.git/commit/?h=devel/for-linus-5.14&id=33d1641f38f0c327bc3e5c21de585c77a6512bc6 

Best Regards, 
Chanho Park



WARNING: multiple messages have this Message-ID (diff)
From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Dominique MARTINET'" <dominique.martinet@atmark-techno.com>,
	"'Jianxiong Gao'" <jxgao@google.com>
Cc: "'Aymen Sghaier'" <aymen.sghaier@nxp.com>,
	"'Herbert Xu'" <herbert@gondor.apana.org.au>,
	"'Horia Geantă'" <horia.geanta@nxp.com>,
	"'Konrad Rzeszutek Wilk'" <konrad.wilk@oracle.com>,
	"'Marc Orr'" <marcorr@google.com>,
	"'Lukas Hartmann'" <lukas@mntmn.com>,
	linux-kernel@vger.kernel.org,
	"'David S. Miller'" <davem@davemloft.net>,
	iommu@lists.linux-foundation.org, linux-crypto@vger.kernel.org,
	"'Peter Gonda'" <pgonda@google.com>,
	"'Konrad Rzeszutek Wilk'" <konrad@darnok.org>,
	"'Bumyong Lee'" <bumyong.lee@samsung.com>,
	"'Linus Torvalds'" <torvalds@linux-foundation.org>,
	"'Christoph Hellwig'" <hch@lst.de>
Subject: RE: swiotlb/caamjr regression (Was: [GIT PULL] (swiotlb) stable/for-linus-5.12)
Date: Mon, 21 Jun 2021 11:55:22 +0900	[thread overview]
Message-ID: <2038148563.21624247281621.JavaMail.epsvc@epcpadp4> (raw)
In-Reply-To: <YM/zWyZlk1bzHWgI@atmark-techno.com>

+ Bumyong who is the original author of the patch. 

Hi Dominique,

> Thanks!
> (a bit late, but added Chanho Park in Cc...)
> 
> I can confirm it also works for our caam problem, as Horia said.
> 
> I've also come to term with the use of swiotlb_align_offset() through
> testing, or rather many devices seem to have a 0 mask so it will almost
> always be cancelled out, so if it works for Jianxiong then it's probably
> good enough and I'll just assume that's how the orig_addr has been
> designed...
> 
> I think it's missing a couple of checks like the one Linus had in his
> patch, and would be comfortable with something like the attached patch (in
> practice for me exactly the same as the original patch, except I've added
> two checks: offsets smaller than orig addr offset are refused as well as
> offsets bigger than the mapping size)
> 
> I'm sorry Jianxiong but would you be willing to take the time to test
> again just to make sure there were no such offsets in your case?
> 
> 
> If we're good with that I'll send it as an official v2 keeping Chanho's
> from, unless he wants to.
> 

Sure. No problem. But, the patch was already stacked on Konrad's tree
and linux-next as well.

https://git.kernel.org/pub/scm/linux/kernel/git/konrad/swiotlb.git/commit/?h=devel/for-linus-5.14&id=33d1641f38f0c327bc3e5c21de585c77a6512bc6 

Best Regards, 
Chanho Park


_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

  reply	other threads:[~2021-06-21  3:48 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-26 16:00 [GIT PULL] (swiotlb) stable/for-linus-5.12 Konrad Rzeszutek Wilk
2021-02-26 22:24 ` pr-tracker-bot
2021-06-08  2:35 ` swiotlb/caamjr regression (Was: [GIT PULL] (swiotlb) stable/for-linus-5.12) Dominique MARTINET
2021-06-10 14:52   ` Horia Geantă
2021-06-10 14:52     ` Horia Geantă
2021-06-10 19:41     ` Linus Torvalds
2021-06-10 19:41       ` Linus Torvalds
2021-06-10 23:20       ` Horia Geantă
2021-06-10 23:20         ` Horia Geantă
2021-06-11  6:21     ` Christoph Hellwig
2021-06-11  6:21       ` Christoph Hellwig
2021-06-11 10:34       ` Konrad Rzeszutek Wilk
2021-06-11 10:34         ` Konrad Rzeszutek Wilk
2021-06-11 10:59         ` Horia Geantă
2021-06-11 10:59           ` Horia Geantă
2021-06-11 16:21         ` Linus Torvalds
2021-06-11 16:21           ` Linus Torvalds
2021-06-16 20:49         ` Jianxiong Gao
2021-06-16 20:49           ` Jianxiong Gao via iommu
2021-06-17  0:27           ` Konrad Rzeszutek Wilk
2021-06-17  0:27             ` Konrad Rzeszutek Wilk
2021-06-17  0:39             ` Dominique MARTINET
2021-06-17  0:39               ` Dominique MARTINET
2021-06-17  5:12               ` Christoph Hellwig
2021-06-17  5:12                 ` Christoph Hellwig
2021-06-17  5:36                 ` Dominique MARTINET
2021-06-17  5:36                   ` Dominique MARTINET
2021-06-18 18:01                   ` Jianxiong Gao
2021-06-18 18:01                     ` Jianxiong Gao via iommu
2021-06-21  2:03                     ` Dominique MARTINET
2021-06-21  2:03                       ` Dominique MARTINET
2021-06-21  2:55                       ` Chanho Park [this message]
2021-06-21  2:55                         ` Chanho Park
2021-06-21  4:14                         ` 'Dominique MARTINET'
2021-06-21  4:14                           ` 'Dominique MARTINET'
2021-06-21 13:16                           ` Konrad Rzeszutek Wilk
2021-06-21 13:16                             ` Konrad Rzeszutek Wilk
2021-06-22  7:48                             ` 'Dominique MARTINET'
2021-06-22  7:48                               ` 'Dominique MARTINET'
2021-06-22 21:58                               ` Konrad Rzeszutek Wilk
2021-06-22 21:58                                 ` Konrad Rzeszutek Wilk
2021-06-22 23:04                                 ` 'Dominique MARTINET'
2021-06-22 23:04                                   ` 'Dominique MARTINET'
2021-06-17 11:33             ` Christoph Hellwig
2021-06-17 11:33               ` Christoph Hellwig
2021-06-11 16:01       ` Linus Torvalds
2021-06-11 16:01         ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2038148563.21624247281621.JavaMail.epsvc@epcpadp4 \
    --to=chanho61.park@samsung.com \
    --cc=aymen.sghaier@nxp.com \
    --cc=bumyong.lee@samsung.com \
    --cc=davem@davemloft.net \
    --cc=dominique.martinet@atmark-techno.com \
    --cc=erdemaktas@google.com \
    --cc=hch@lst.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=horia.geanta@nxp.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jxgao@google.com \
    --cc=konrad.wilk@oracle.com \
    --cc=konrad@darnok.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas@mntmn.com \
    --cc=marcorr@google.com \
    --cc=pgonda@google.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.