* [PATCH] arm: mach-omap2: gpmc: ignore non-available nodes
@ 2014-06-26 15:02 ` Guido Martínez
0 siblings, 0 replies; 13+ messages in thread
From: Guido Martínez @ 2014-06-26 15:02 UTC (permalink / raw)
To: Tony Lindgren
Cc: pekon, Ezequiel García, linux-omap, linux-kernel,
linux-arm-kernel, Guido Martínez
Currently, child nodes of the gpmc node are iterated and probed
regardless of their 'status' property. This means adding 'status =
"disabled";' has no effect.
This patch changes the iteration to only probe nodes marked as
available.
Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
---
arch/arm/mach-omap2/gpmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index 2c0c281..8bc1338 100644
--- a/arch/arm/mach-omap2/gpmc.c
+++ b/arch/arm/mach-omap2/gpmc.c
@@ -1615,7 +1615,7 @@ static int gpmc_probe_dt(struct platform_device *pdev)
return ret;
}
- for_each_child_of_node(pdev->dev.of_node, child) {
+ for_each_available_child_of_node(pdev->dev.of_node, child) {
if (!child->name)
continue;
--
2.0.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH] arm: mach-omap2: gpmc: ignore non-available nodes
@ 2014-06-26 15:02 ` Guido Martínez
0 siblings, 0 replies; 13+ messages in thread
From: Guido Martínez @ 2014-06-26 15:02 UTC (permalink / raw)
To: Tony Lindgren
Cc: pekon, Ezequiel García, linux-omap, linux-kernel,
linux-arm-kernel, Guido Martínez
Currently, child nodes of the gpmc node are iterated and probed
regardless of their 'status' property. This means adding 'status =
"disabled";' has no effect.
This patch changes the iteration to only probe nodes marked as
available.
Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
---
arch/arm/mach-omap2/gpmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index 2c0c281..8bc1338 100644
--- a/arch/arm/mach-omap2/gpmc.c
+++ b/arch/arm/mach-omap2/gpmc.c
@@ -1615,7 +1615,7 @@ static int gpmc_probe_dt(struct platform_device *pdev)
return ret;
}
- for_each_child_of_node(pdev->dev.of_node, child) {
+ for_each_available_child_of_node(pdev->dev.of_node, child) {
if (!child->name)
continue;
--
2.0.0
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH] arm: mach-omap2: gpmc: ignore non-available nodes
@ 2014-06-26 15:02 ` Guido Martínez
0 siblings, 0 replies; 13+ messages in thread
From: Guido Martínez @ 2014-06-26 15:02 UTC (permalink / raw)
To: linux-arm-kernel
Currently, child nodes of the gpmc node are iterated and probed
regardless of their 'status' property. This means adding 'status =
"disabled";' has no effect.
This patch changes the iteration to only probe nodes marked as
available.
Signed-off-by: Guido Mart?nez <guido@vanguardiasur.com.ar>
---
arch/arm/mach-omap2/gpmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index 2c0c281..8bc1338 100644
--- a/arch/arm/mach-omap2/gpmc.c
+++ b/arch/arm/mach-omap2/gpmc.c
@@ -1615,7 +1615,7 @@ static int gpmc_probe_dt(struct platform_device *pdev)
return ret;
}
- for_each_child_of_node(pdev->dev.of_node, child) {
+ for_each_available_child_of_node(pdev->dev.of_node, child) {
if (!child->name)
continue;
--
2.0.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] arm: mach-omap2: gpmc: ignore non-available nodes
2014-06-26 15:02 ` Guido Martínez
@ 2014-06-26 16:37 ` Ezequiel García
-1 siblings, 0 replies; 13+ messages in thread
From: Ezequiel García @ 2014-06-26 16:37 UTC (permalink / raw)
To: Guido Martínez
Cc: Tony Lindgren, pekon, linux-omap, linux-kernel, linux-arm-kernel
On 26 Jun 12:02 PM, Guido Martínez wrote:
> Currently, child nodes of the gpmc node are iterated and probed
> regardless of their 'status' property. This means adding 'status =
> "disabled";' has no effect.
>
> This patch changes the iteration to only probe nodes marked as
> available.
>
> Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
Just a nit: the commit title doesn't match the recent commits. If you
run "git log" on this file, you'll find the pattern should be something
like:
"ARM: OMAP2+: GPMC should only probe enabled devices"
Other than this, the patch looks correct.
Thanks,
--
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] arm: mach-omap2: gpmc: ignore non-available nodes
@ 2014-06-26 16:37 ` Ezequiel García
0 siblings, 0 replies; 13+ messages in thread
From: Ezequiel García @ 2014-06-26 16:37 UTC (permalink / raw)
To: linux-arm-kernel
On 26 Jun 12:02 PM, Guido Mart?nez wrote:
> Currently, child nodes of the gpmc node are iterated and probed
> regardless of their 'status' property. This means adding 'status =
> "disabled";' has no effect.
>
> This patch changes the iteration to only probe nodes marked as
> available.
>
> Signed-off-by: Guido Mart?nez <guido@vanguardiasur.com.ar>
Just a nit: the commit title doesn't match the recent commits. If you
run "git log" on this file, you'll find the pattern should be something
like:
"ARM: OMAP2+: GPMC should only probe enabled devices"
Other than this, the patch looks correct.
Thanks,
--
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH] arm: mach-omap2: gpmc: ignore non-available nodes
2014-06-26 16:37 ` Ezequiel García
(?)
@ 2014-07-02 5:33 ` Gupta, Pekon
-1 siblings, 0 replies; 13+ messages in thread
From: Gupta, Pekon @ 2014-07-02 5:33 UTC (permalink / raw)
To: Ezequiel García, Guido Martínez
Cc: Tony Lindgren, linux-omap, linux-kernel, linux-arm-kernel
>From: Ezequiel García [mailto:ezequiel@vanguardiasur.com.ar]
>>On 26 Jun 12:02 PM, Guido Martínez wrote:
>> Currently, child nodes of the gpmc node are iterated and probed
>> regardless of their 'status' property. This means adding 'status =
>> "disabled";' has no effect.
>>
>> This patch changes the iteration to only probe nodes marked as
>> available.
>>
>> Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
>
>Just a nit: the commit title doesn't match the recent commits. If you
>run "git log" on this file, you'll find the pattern should be something
>like:
>
>"ARM: OMAP2+: GPMC should only probe enabled devices"
>
>Other than this, the patch looks correct.
>
Yes, plz keep patch title consistent as in other gpmc.c patches.
And thanks for this fix.
Tested-by: Pekon Gupta <pekon@ti.com>
with regards, pekon
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH] arm: mach-omap2: gpmc: ignore non-available nodes
@ 2014-07-02 5:33 ` Gupta, Pekon
0 siblings, 0 replies; 13+ messages in thread
From: Gupta, Pekon @ 2014-07-02 5:33 UTC (permalink / raw)
To: Ezequiel García, Guido Martínez
Cc: Tony Lindgren, linux-omap, linux-kernel, linux-arm-kernel
>From: Ezequiel García [mailto:ezequiel@vanguardiasur.com.ar]
>>On 26 Jun 12:02 PM, Guido Martínez wrote:
>> Currently, child nodes of the gpmc node are iterated and probed
>> regardless of their 'status' property. This means adding 'status =
>> "disabled";' has no effect.
>>
>> This patch changes the iteration to only probe nodes marked as
>> available.
>>
>> Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
>
>Just a nit: the commit title doesn't match the recent commits. If you
>run "git log" on this file, you'll find the pattern should be something
>like:
>
>"ARM: OMAP2+: GPMC should only probe enabled devices"
>
>Other than this, the patch looks correct.
>
Yes, plz keep patch title consistent as in other gpmc.c patches.
And thanks for this fix.
Tested-by: Pekon Gupta <pekon@ti.com>
with regards, pekon
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] arm: mach-omap2: gpmc: ignore non-available nodes
@ 2014-07-02 5:33 ` Gupta, Pekon
0 siblings, 0 replies; 13+ messages in thread
From: Gupta, Pekon @ 2014-07-02 5:33 UTC (permalink / raw)
To: linux-arm-kernel
>From: Ezequiel Garc?a [mailto:ezequiel at vanguardiasur.com.ar]
>>On 26 Jun 12:02 PM, Guido Mart?nez wrote:
>> Currently, child nodes of the gpmc node are iterated and probed
>> regardless of their 'status' property. This means adding 'status =
>> "disabled";' has no effect.
>>
>> This patch changes the iteration to only probe nodes marked as
>> available.
>>
>> Signed-off-by: Guido Mart?nez <guido@vanguardiasur.com.ar>
>
>Just a nit: the commit title doesn't match the recent commits. If you
>run "git log" on this file, you'll find the pattern should be something
>like:
>
>"ARM: OMAP2+: GPMC should only probe enabled devices"
>
>Other than this, the patch looks correct.
>
Yes, plz keep patch title consistent as in other gpmc.c patches.
And thanks for this fix.
Tested-by: Pekon Gupta <pekon@ti.com>
with regards, pekon
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2] ARM: OMAP2+: Make GPMC skip disabled devices
2014-07-02 5:33 ` Gupta, Pekon
(?)
@ 2014-07-02 13:35 ` Guido Martínez
-1 siblings, 0 replies; 13+ messages in thread
From: Guido Martínez @ 2014-07-02 13:35 UTC (permalink / raw)
To: Tony Lindgren
Cc: linux-kernel, linux-arm-kernel, linux-omap, Ezequiel García,
pekon, Guido Martínez
Currently, child nodes of the gpmc node are iterated and probed
regardless of their 'status' property. This means adding 'status =
"disabled";' has no effect.
This patch changes the iteration to only probe nodes marked as
available.
Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
---
v2: Make patch title consistent with previous gpmc patches
arch/arm/mach-omap2/gpmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index 2c0c281..8bc1338 100644
--- a/arch/arm/mach-omap2/gpmc.c
+++ b/arch/arm/mach-omap2/gpmc.c
@@ -1615,7 +1615,7 @@ static int gpmc_probe_dt(struct platform_device *pdev)
return ret;
}
- for_each_child_of_node(pdev->dev.of_node, child) {
+ for_each_available_child_of_node(pdev->dev.of_node, child) {
if (!child->name)
continue;
--
2.0.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v2] ARM: OMAP2+: Make GPMC skip disabled devices
@ 2014-07-02 13:35 ` Guido Martínez
0 siblings, 0 replies; 13+ messages in thread
From: Guido Martínez @ 2014-07-02 13:35 UTC (permalink / raw)
To: Tony Lindgren
Cc: linux-kernel, linux-arm-kernel, linux-omap, Ezequiel García,
pekon, Guido Martínez
Currently, child nodes of the gpmc node are iterated and probed
regardless of their 'status' property. This means adding 'status =
"disabled";' has no effect.
This patch changes the iteration to only probe nodes marked as
available.
Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
---
v2: Make patch title consistent with previous gpmc patches
arch/arm/mach-omap2/gpmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index 2c0c281..8bc1338 100644
--- a/arch/arm/mach-omap2/gpmc.c
+++ b/arch/arm/mach-omap2/gpmc.c
@@ -1615,7 +1615,7 @@ static int gpmc_probe_dt(struct platform_device *pdev)
return ret;
}
- for_each_child_of_node(pdev->dev.of_node, child) {
+ for_each_available_child_of_node(pdev->dev.of_node, child) {
if (!child->name)
continue;
--
2.0.0
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v2] ARM: OMAP2+: Make GPMC skip disabled devices
@ 2014-07-02 13:35 ` Guido Martínez
0 siblings, 0 replies; 13+ messages in thread
From: Guido Martínez @ 2014-07-02 13:35 UTC (permalink / raw)
To: linux-arm-kernel
Currently, child nodes of the gpmc node are iterated and probed
regardless of their 'status' property. This means adding 'status =
"disabled";' has no effect.
This patch changes the iteration to only probe nodes marked as
available.
Signed-off-by: Guido Mart?nez <guido@vanguardiasur.com.ar>
---
v2: Make patch title consistent with previous gpmc patches
arch/arm/mach-omap2/gpmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index 2c0c281..8bc1338 100644
--- a/arch/arm/mach-omap2/gpmc.c
+++ b/arch/arm/mach-omap2/gpmc.c
@@ -1615,7 +1615,7 @@ static int gpmc_probe_dt(struct platform_device *pdev)
return ret;
}
- for_each_child_of_node(pdev->dev.of_node, child) {
+ for_each_available_child_of_node(pdev->dev.of_node, child) {
if (!child->name)
continue;
--
2.0.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v2] ARM: OMAP2+: Make GPMC skip disabled devices
2014-07-02 13:35 ` Guido Martínez
@ 2014-07-07 10:51 ` Tony Lindgren
-1 siblings, 0 replies; 13+ messages in thread
From: Tony Lindgren @ 2014-07-07 10:51 UTC (permalink / raw)
To: Guido Martínez
Cc: linux-kernel, linux-arm-kernel, linux-omap, Ezequiel García, pekon
* Guido Martínez <guido@vanguardiasur.com.ar> [140702 06:34]:
> Currently, child nodes of the gpmc node are iterated and probed
> regardless of their 'status' property. This means adding 'status =
> "disabled";' has no effect.
>
> This patch changes the iteration to only probe nodes marked as
> available.
>
> Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
> ---
> v2: Make patch title consistent with previous gpmc patches
Thanks applying into omap-for-v3.16/fixes.
Tony
> arch/arm/mach-omap2/gpmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
> index 2c0c281..8bc1338 100644
> --- a/arch/arm/mach-omap2/gpmc.c
> +++ b/arch/arm/mach-omap2/gpmc.c
> @@ -1615,7 +1615,7 @@ static int gpmc_probe_dt(struct platform_device *pdev)
> return ret;
> }
>
> - for_each_child_of_node(pdev->dev.of_node, child) {
> + for_each_available_child_of_node(pdev->dev.of_node, child) {
>
> if (!child->name)
> continue;
> --
> 2.0.0
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2] ARM: OMAP2+: Make GPMC skip disabled devices
@ 2014-07-07 10:51 ` Tony Lindgren
0 siblings, 0 replies; 13+ messages in thread
From: Tony Lindgren @ 2014-07-07 10:51 UTC (permalink / raw)
To: linux-arm-kernel
* Guido Mart?nez <guido@vanguardiasur.com.ar> [140702 06:34]:
> Currently, child nodes of the gpmc node are iterated and probed
> regardless of their 'status' property. This means adding 'status =
> "disabled";' has no effect.
>
> This patch changes the iteration to only probe nodes marked as
> available.
>
> Signed-off-by: Guido Mart?nez <guido@vanguardiasur.com.ar>
> ---
> v2: Make patch title consistent with previous gpmc patches
Thanks applying into omap-for-v3.16/fixes.
Tony
> arch/arm/mach-omap2/gpmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
> index 2c0c281..8bc1338 100644
> --- a/arch/arm/mach-omap2/gpmc.c
> +++ b/arch/arm/mach-omap2/gpmc.c
> @@ -1615,7 +1615,7 @@ static int gpmc_probe_dt(struct platform_device *pdev)
> return ret;
> }
>
> - for_each_child_of_node(pdev->dev.of_node, child) {
> + for_each_available_child_of_node(pdev->dev.of_node, child) {
>
> if (!child->name)
> continue;
> --
> 2.0.0
>
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2014-07-07 10:51 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-26 15:02 [PATCH] arm: mach-omap2: gpmc: ignore non-available nodes Guido Martínez
2014-06-26 15:02 ` Guido Martínez
2014-06-26 15:02 ` Guido Martínez
2014-06-26 16:37 ` Ezequiel García
2014-06-26 16:37 ` Ezequiel García
2014-07-02 5:33 ` Gupta, Pekon
2014-07-02 5:33 ` Gupta, Pekon
2014-07-02 5:33 ` Gupta, Pekon
2014-07-02 13:35 ` [PATCH v2] ARM: OMAP2+: Make GPMC skip disabled devices Guido Martínez
2014-07-02 13:35 ` Guido Martínez
2014-07-02 13:35 ` Guido Martínez
2014-07-07 10:51 ` Tony Lindgren
2014-07-07 10:51 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.