* [PATCH v2] ARM: SAMSUNG: S5P: If detected device tree skip irq init
@ 2013-09-24 15:59 ` Mateusz Krawczuk
0 siblings, 0 replies; 6+ messages in thread
From: Mateusz Krawczuk @ 2013-09-24 15:59 UTC (permalink / raw)
To: kgene.kim
Cc: ben-linux, linux, linux-arm-kernel, linux-samsung-soc,
linux-kernel, t.figa, s.nawrocki, m.szyprowski, b.zolnierkie,
t.stanislaws, Mateusz Krawczuk, Kyungmin Park
It prevents from executing things already handled by pinctrl-exynos driver,
when device tree is available.
Signed-off-by: Mateusz Krawczuk <m.krawczuk@partner.samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
arch/arm/plat-samsung/s5p-irq-eint.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/plat-samsung/s5p-irq-eint.c b/arch/arm/plat-samsung/s5p-irq-eint.c
index faa6516..ebee4dc 100644
--- a/arch/arm/plat-samsung/s5p-irq-eint.c
+++ b/arch/arm/plat-samsung/s5p-irq-eint.c
@@ -16,6 +16,7 @@
#include <linux/device.h>
#include <linux/gpio.h>
#include <linux/irqchip/arm-vic.h>
+#include <linux/of.h>
#include <plat/regs-irqtype.h>
@@ -202,6 +203,9 @@ static int __init s5p_init_irq_eint(void)
{
int irq;
+ if (of_have_populated_dt())
+ return -ENODEV;
+
for (irq = IRQ_EINT(0); irq <= IRQ_EINT(15); irq++)
irq_set_chip(irq, &s5p_irq_vic_eint);
--
1.8.1.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] ARM: SAMSUNG: S5P: If detected device tree skip irq init
@ 2013-09-24 15:59 ` Mateusz Krawczuk
0 siblings, 0 replies; 6+ messages in thread
From: Mateusz Krawczuk @ 2013-09-24 15:59 UTC (permalink / raw)
To: linux-arm-kernel
It prevents from executing things already handled by pinctrl-exynos driver,
when device tree is available.
Signed-off-by: Mateusz Krawczuk <m.krawczuk@partner.samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
arch/arm/plat-samsung/s5p-irq-eint.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/plat-samsung/s5p-irq-eint.c b/arch/arm/plat-samsung/s5p-irq-eint.c
index faa6516..ebee4dc 100644
--- a/arch/arm/plat-samsung/s5p-irq-eint.c
+++ b/arch/arm/plat-samsung/s5p-irq-eint.c
@@ -16,6 +16,7 @@
#include <linux/device.h>
#include <linux/gpio.h>
#include <linux/irqchip/arm-vic.h>
+#include <linux/of.h>
#include <plat/regs-irqtype.h>
@@ -202,6 +203,9 @@ static int __init s5p_init_irq_eint(void)
{
int irq;
+ if (of_have_populated_dt())
+ return -ENODEV;
+
for (irq = IRQ_EINT(0); irq <= IRQ_EINT(15); irq++)
irq_set_chip(irq, &s5p_irq_vic_eint);
--
1.8.1.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] ARM: SAMSUNG: S5P: If detected device tree skip irq init
2013-09-24 15:59 ` Mateusz Krawczuk
@ 2013-09-24 19:19 ` Tomasz Figa
-1 siblings, 0 replies; 6+ messages in thread
From: Tomasz Figa @ 2013-09-24 19:19 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Mateusz Krawczuk, kgene.kim, t.stanislaws, linux-samsung-soc,
linux, s.nawrocki, b.zolnierkie, t.figa, linux-kernel,
Kyungmin Park, ben-linux, m.szyprowski
Hi Mateusz,
On Tuesday 24 of September 2013 17:59:23 Mateusz Krawczuk wrote:
> It prevents from executing things already handled by pinctrl-exynos
> driver, when device tree is available.
>
> Signed-off-by: Mateusz Krawczuk <m.krawczuk@partner.samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/plat-samsung/s5p-irq-eint.c | 4 ++++
> 1 file changed, 4 insertions(+)
Acked-by: Tomasz Figa <t.figa@samsung.com>
[as a temporary solution until we move all the users of this code to
device tree]
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] ARM: SAMSUNG: S5P: If detected device tree skip irq init
@ 2013-09-24 19:19 ` Tomasz Figa
0 siblings, 0 replies; 6+ messages in thread
From: Tomasz Figa @ 2013-09-24 19:19 UTC (permalink / raw)
To: linux-arm-kernel
Hi Mateusz,
On Tuesday 24 of September 2013 17:59:23 Mateusz Krawczuk wrote:
> It prevents from executing things already handled by pinctrl-exynos
> driver, when device tree is available.
>
> Signed-off-by: Mateusz Krawczuk <m.krawczuk@partner.samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/plat-samsung/s5p-irq-eint.c | 4 ++++
> 1 file changed, 4 insertions(+)
Acked-by: Tomasz Figa <t.figa@samsung.com>
[as a temporary solution until we move all the users of this code to
device tree]
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v2] ARM: SAMSUNG: S5P: If detected device tree skip irq init
2013-09-24 19:19 ` Tomasz Figa
@ 2013-09-26 5:29 ` Kukjin Kim
-1 siblings, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2013-09-26 5:29 UTC (permalink / raw)
To: 'Tomasz Figa', linux-arm-kernel
Cc: 'Mateusz Krawczuk',
t.stanislaws, linux-samsung-soc, linux, s.nawrocki, b.zolnierkie,
t.figa, linux-kernel, 'Kyungmin Park',
ben-linux, m.szyprowski
Tomasz Figa wrote:
>
> Hi Mateusz,
>
> On Tuesday 24 of September 2013 17:59:23 Mateusz Krawczuk wrote:
> > It prevents from executing things already handled by pinctrl-exynos
> > driver, when device tree is available.
> >
> > Signed-off-by: Mateusz Krawczuk <m.krawczuk@partner.samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > ---
> > arch/arm/plat-samsung/s5p-irq-eint.c | 4 ++++
> > 1 file changed, 4 insertions(+)
>
> Acked-by: Tomasz Figa <t.figa@samsung.com>
>
> [as a temporary solution until we move all the users of this code to
> device tree]
>
Yes, agreed.
The 'skip irq init' in subject would be changed to 'skip eint init' for
clear meaning.
Applied.
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] ARM: SAMSUNG: S5P: If detected device tree skip irq init
@ 2013-09-26 5:29 ` Kukjin Kim
0 siblings, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2013-09-26 5:29 UTC (permalink / raw)
To: linux-arm-kernel
Tomasz Figa wrote:
>
> Hi Mateusz,
>
> On Tuesday 24 of September 2013 17:59:23 Mateusz Krawczuk wrote:
> > It prevents from executing things already handled by pinctrl-exynos
> > driver, when device tree is available.
> >
> > Signed-off-by: Mateusz Krawczuk <m.krawczuk@partner.samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > ---
> > arch/arm/plat-samsung/s5p-irq-eint.c | 4 ++++
> > 1 file changed, 4 insertions(+)
>
> Acked-by: Tomasz Figa <t.figa@samsung.com>
>
> [as a temporary solution until we move all the users of this code to
> device tree]
>
Yes, agreed.
The 'skip irq init' in subject would be changed to 'skip eint init' for
clear meaning.
Applied.
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-09-26 5:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-24 15:59 [PATCH v2] ARM: SAMSUNG: S5P: If detected device tree skip irq init Mateusz Krawczuk
2013-09-24 15:59 ` Mateusz Krawczuk
2013-09-24 19:19 ` Tomasz Figa
2013-09-24 19:19 ` Tomasz Figa
2013-09-26 5:29 ` Kukjin Kim
2013-09-26 5:29 ` Kukjin Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.