* Re: Re: [PATCH 02/11] xfsprogs: fix integer overflow in xlog_find_verify_cycle
@ 2015-12-04 12:01 VIVEK TRIVEDI
0 siblings, 0 replies; only message in thread
From: VIVEK TRIVEDI @ 2015-12-04 12:01 UTC (permalink / raw)
To: Dave Chinner; +Cc: AMIT SAHRAWAT, PANKAJ MISHRA, xfs
> Ummm, in isolation that change is technically correct, but when you
> look at what bufblks contains it is clearly wrong. nbblks is an
> int, so "1 << ffs(nbblks)" should not be larger than an int.
> i.e. bufblks is simply a count of blocks in the log, which by
> definition cannot be more than an int (in fact, 2^31 / 2^9 is the
> largest legal value it can have). Hence it can't be larger than an
> int, and all the functions it is passed to expect it to be an
> int...
>
>Hence the use of xfs_daddr_t is wrong, and that's the first thing
>that needs fixing....
thanks for review!
I will resend updated patch.
thanks!
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-12-04 12:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-04 12:01 Re: [PATCH 02/11] xfsprogs: fix integer overflow in xlog_find_verify_cycle VIVEK TRIVEDI
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.