All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Matthew Wilcox <willy@infradead.org>,
	Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc: linux-doc@vger.kernel.org, lukas.bulwahn@gmail.com,
	linux-kernel-mentees@lists.linuxfoundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC v3 2/3] docs: add documentation for checkpatch
Date: Mon, 15 Feb 2021 10:11:03 -0800	[thread overview]
Message-ID: <2162334bdf4d635f1414ffef52378c0f423366a7.camel@perches.com> (raw)
In-Reply-To: <20210214121501.GC2858050@casper.infradead.org>

On Sun, 2021-02-14 at 12:15 +0000, Matthew Wilcox wrote:
> On Sat, Feb 13, 2021 at 06:45:12PM +0530, Dwaipayan Ray wrote:
> > +Checkpatch (scripts/checkpatch.pl) is a perl script which checks for trivial style
> 
> It's quite amusing that this patch contains lines > 80 columns.

Then you could amuse yourself further by looking at the existing
line lengths of .rst files.

$ git ls-files -- '*.rst' | \
  xargs cat | \
  awk '{print length($0);}' | \
  sort -n | \
  uniq -c | \
  tail -20
      2 226
      1 230
      1 233
      1 234
     48 246
      1 253
      2 257
      1 263
      1 270
      1 275
      1 276
      1 293
      1 294
      1 308
      2 324
      1 359
      1 360
      5 369
      1 370
      2 409

Other than testing whether or not an SPDX license line exists,
checkpatch doesn't inspect .rst files.

There are better tools for that.



WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Matthew Wilcox <willy@infradead.org>,
	Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [Linux-kernel-mentees] [PATCH RFC v3 2/3] docs: add documentation for checkpatch
Date: Mon, 15 Feb 2021 10:11:03 -0800	[thread overview]
Message-ID: <2162334bdf4d635f1414ffef52378c0f423366a7.camel@perches.com> (raw)
In-Reply-To: <20210214121501.GC2858050@casper.infradead.org>

On Sun, 2021-02-14 at 12:15 +0000, Matthew Wilcox wrote:
> On Sat, Feb 13, 2021 at 06:45:12PM +0530, Dwaipayan Ray wrote:
> > +Checkpatch (scripts/checkpatch.pl) is a perl script which checks for trivial style
> 
> It's quite amusing that this patch contains lines > 80 columns.

Then you could amuse yourself further by looking at the existing
line lengths of .rst files.

$ git ls-files -- '*.rst' | \
  xargs cat | \
  awk '{print length($0);}' | \
  sort -n | \
  uniq -c | \
  tail -20
      2 226
      1 230
      1 233
      1 234
     48 246
      1 253
      2 257
      1 263
      1 270
      1 275
      1 276
      1 293
      1 294
      1 308
      2 324
      1 359
      1 360
      5 369
      1 370
      2 409

Other than testing whether or not an SPDX license line exists,
checkpatch doesn't inspect .rst files.

There are better tools for that.


_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

  reply	other threads:[~2021-02-15 18:12 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-13 13:15 [PATCH RFC v3 0/3] checkpatch: add verbose mode Dwaipayan Ray
2021-02-13 13:15 ` [Linux-kernel-mentees] " Dwaipayan Ray
2021-02-13 13:15 ` [PATCH RFC v3 1/3] " Dwaipayan Ray
2021-02-13 13:15   ` [Linux-kernel-mentees] " Dwaipayan Ray
2021-02-13 13:15 ` [PATCH RFC v3 2/3] docs: add documentation for checkpatch Dwaipayan Ray
2021-02-13 13:15   ` [Linux-kernel-mentees] " Dwaipayan Ray
2021-02-14 12:15   ` Matthew Wilcox
2021-02-14 12:15     ` [Linux-kernel-mentees] " Matthew Wilcox
2021-02-15 18:11     ` Joe Perches [this message]
2021-02-15 18:11       ` Joe Perches
2021-02-15 19:12       ` Matthew Wilcox
2021-02-15 19:12         ` [Linux-kernel-mentees] " Matthew Wilcox
2021-02-14 16:57   ` Joe Perches
2021-02-14 16:57     ` [Linux-kernel-mentees] " Joe Perches
2021-02-15 15:50     ` Dwaipayan Ray
2021-02-15 15:50       ` [Linux-kernel-mentees] " Dwaipayan Ray
2021-02-15 15:55       ` Joe Perches
2021-02-15 15:55         ` [Linux-kernel-mentees] " Joe Perches
2021-02-16 14:18     ` Dwaipayan Ray
2021-02-16 14:18       ` [Linux-kernel-mentees] " Dwaipayan Ray
2021-02-17 10:37       ` Joe Perches
2021-02-17 10:37         ` [Linux-kernel-mentees] " Joe Perches
2021-02-17 15:46         ` Dwaipayan Ray
2021-02-17 15:46           ` [Linux-kernel-mentees] " Dwaipayan Ray
2021-02-13 13:15 ` [PATCH RFC v3 3/3] " Dwaipayan Ray
2021-02-13 13:15   ` [Linux-kernel-mentees] " Dwaipayan Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2162334bdf4d635f1414ffef52378c0f423366a7.camel@perches.com \
    --to=joe@perches.com \
    --cc=dwaipayanray1@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.