All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene.kim@samsung.com>
To: "'Paul Bolle'" <pebolle@tiscali.nl>,
	"'Ben Dooks'" <ben-linux@fluff.org>,
	"'Russell King'" <linux@arm.linux.org.uk>
Cc: "'Arnd Bergmann'" <arnd@arndb.de>,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: RE: [PATCH] ARM: S3C64XX: remove obsolete Makefile line
Date: Tue, 02 Apr 2013 18:55:08 +0900	[thread overview]
Message-ID: <237a01ce2f88$28edbd90$7ac938b0$%kim@samsung.com> (raw)
In-Reply-To: <1364597502.1345.103.camel@x61.thuisdomein>

Paul Bolle wrote:
> 
> Commit a07613a54d700a974f3a4a657da78ef5d097315d ("Merge branch
> 'samsung/dt' into samsung/cleanup") added this line to
> arch/arm/mach-s3c64xx/Makefile:
>     obj-$(CONFIG_S3C64XX_DEV_SPI)	+= dev-spi.o
> 
> But at that time CONFIG_S3C64XX_DEV_SPI wasn't a valid Kconfig macro
> anymore and arch/arm/mach-s3c64xx/dev-spi.c was already removed. So we
> can remove this line.
> 
Yes, the dev-spi.c has been removed with Consolidation work of SPI platform devices.

> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Untested.
> 
>  arch/arm/mach-s3c64xx/Makefile | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/mach-s3c64xx/Makefile b/arch/arm/mach-
> s3c64xx/Makefile
> index f9ce1dc..31d0c91 100644
> --- a/arch/arm/mach-s3c64xx/Makefile
> +++ b/arch/arm/mach-s3c64xx/Makefile
> @@ -32,7 +32,6 @@ obj-$(CONFIG_S3C64XX_DMA)	+= dma.o
> 
>  obj-y				+= dev-uart.o
>  obj-y				+= dev-audio.o
> -obj-$(CONFIG_S3C64XX_DEV_SPI)	+= dev-spi.o
> 
>  # Device setup
> 
> --
> 1.7.11.7
> 
Looks OK to me, applied.

Thanks.

- Kukjin


WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: S3C64XX: remove obsolete Makefile line
Date: Tue, 02 Apr 2013 18:55:08 +0900	[thread overview]
Message-ID: <237a01ce2f88$28edbd90$7ac938b0$%kim@samsung.com> (raw)
In-Reply-To: <1364597502.1345.103.camel@x61.thuisdomein>

Paul Bolle wrote:
> 
> Commit a07613a54d700a974f3a4a657da78ef5d097315d ("Merge branch
> 'samsung/dt' into samsung/cleanup") added this line to
> arch/arm/mach-s3c64xx/Makefile:
>     obj-$(CONFIG_S3C64XX_DEV_SPI)	+= dev-spi.o
> 
> But at that time CONFIG_S3C64XX_DEV_SPI wasn't a valid Kconfig macro
> anymore and arch/arm/mach-s3c64xx/dev-spi.c was already removed. So we
> can remove this line.
> 
Yes, the dev-spi.c has been removed with Consolidation work of SPI platform devices.

> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Untested.
> 
>  arch/arm/mach-s3c64xx/Makefile | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/mach-s3c64xx/Makefile b/arch/arm/mach-
> s3c64xx/Makefile
> index f9ce1dc..31d0c91 100644
> --- a/arch/arm/mach-s3c64xx/Makefile
> +++ b/arch/arm/mach-s3c64xx/Makefile
> @@ -32,7 +32,6 @@ obj-$(CONFIG_S3C64XX_DMA)	+= dma.o
> 
>  obj-y				+= dev-uart.o
>  obj-y				+= dev-audio.o
> -obj-$(CONFIG_S3C64XX_DEV_SPI)	+= dev-spi.o
> 
>  # Device setup
> 
> --
> 1.7.11.7
> 
Looks OK to me, applied.

Thanks.

- Kukjin

  reply	other threads:[~2013-04-02  9:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-29 22:51 [PATCH] ARM: S3C64XX: remove obsolete Makefile line Paul Bolle
2013-03-29 22:51 ` Paul Bolle
2013-04-02  9:55 ` Kukjin Kim [this message]
2013-04-02  9:55   ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='237a01ce2f88$28edbd90$7ac938b0$%kim@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=arnd@arndb.de \
    --cc=ben-linux@fluff.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=pebolle@tiscali.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.