[Qemu-devel] [PATCH] target: hax: fix a typo

[Qemu-devel] [PATCH] target: hax: fix a typo

[Li Qiang]

Cc: qemu-trivial@nongnu.org

Signed-off-by: Li Qiang <liq3ea@gmail.com>
---
 target/i386/hax-all.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c
index 502ce6f0af..464744a406 100644
--- a/target/i386/hax-all.c
+++ b/target/i386/hax-all.c
@@ -205,7 +205,7 @@ int hax_vcpu_destroy(CPUState *cpu)
     }
 
     /*
-     * 1. The hax_tunnel is also destroied when vcpu destroy
+     * 1. The hax_tunnel is also destroyed when vcpu destroy
      * 2. close fd will cause hax module vcpu be cleaned
      */
     hax_close_fd(vcpu->fd);
-- 
2.11.0

Re: [Qemu-devel] [PATCH] target: hax: fix a typo

[Alex Bennée]

Li Qiang <liq3ea@gmail.com> writes:

> Cc: qemu-trivial@nongnu.org
>
> Signed-off-by: Li Qiang <liq3ea@gmail.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  target/i386/hax-all.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c
> index 502ce6f0af..464744a406 100644
> --- a/target/i386/hax-all.c
> +++ b/target/i386/hax-all.c
> @@ -205,7 +205,7 @@ int hax_vcpu_destroy(CPUState *cpu)
>      }
>
>      /*
> -     * 1. The hax_tunnel is also destroied when vcpu destroy
> +     * 1. The hax_tunnel is also destroyed when vcpu destroy
>       * 2. close fd will cause hax module vcpu be cleaned
>       */
>      hax_close_fd(vcpu->fd);


--
Alex Bennée

Re: [Qemu-devel] [PATCH] target: hax: fix a typo

[Philippe Mathieu-Daudé]

Hi Li, Alex.

On 26/11/18 12:51, Alex Bennée wrote:
> 
> Li Qiang <liq3ea@gmail.com> writes:
> 
>> Cc: qemu-trivial@nongnu.org
>>
>> Signed-off-by: Li Qiang <liq3ea@gmail.com>
> 
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> 
>> ---
>>  target/i386/hax-all.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c
>> index 502ce6f0af..464744a406 100644
>> --- a/target/i386/hax-all.c
>> +++ b/target/i386/hax-all.c
>> @@ -205,7 +205,7 @@ int hax_vcpu_destroy(CPUState *cpu)
>>      }
>>
>>      /*
>> -     * 1. The hax_tunnel is also destroied when vcpu destroy
>> +     * 1. The hax_tunnel is also destroyed when vcpu destroy

I'm not native english speaker. Isn't it:

'The hax_tunnel is also destroyed at vcpu destroy'

or

'The hax_tunnel is also destroyed when vcpu is destroyed'?

>>       * 2. close fd will cause hax module vcpu be cleaned
>>       */
>>      hax_close_fd(vcpu->fd);
> 
> 
> --
> Alex Bennée
> 

Re: [Qemu-devel] [PATCH] target: hax: fix a typo

[Richard Henderson]

On 11/26/18 1:25 PM, Philippe Mathieu-Daudé wrote:
>>> -     * 1. The hax_tunnel is also destroied when vcpu destroy
>>> +     * 1. The hax_tunnel is also destroyed when vcpu destroy
> I'm not native english speaker. Isn't it:
> 
> 'The hax_tunnel is also destroyed at vcpu destroy'
> 
> or
> 
> 'The hax_tunnel is also destroyed when vcpu is destroyed'?

This second option is best, fwiw.


r~

Re: [Qemu-devel] [PATCH] target: hax: fix a typo

[Paolo Bonzini]

On 26/11/18 10:58, Li Qiang wrote:
> Cc: qemu-trivial@nongnu.org
> 
> Signed-off-by: Li Qiang <liq3ea@gmail.com>
> ---
>  target/i386/hax-all.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c
> index 502ce6f0af..464744a406 100644
> --- a/target/i386/hax-all.c
> +++ b/target/i386/hax-all.c
> @@ -205,7 +205,7 @@ int hax_vcpu_destroy(CPUState *cpu)
>      }
>  
>      /*
> -     * 1. The hax_tunnel is also destroied when vcpu destroy
> +     * 1. The hax_tunnel is also destroyed when vcpu destroy
>       * 2. close fd will cause hax module vcpu be cleaned
>       */
>      hax_close_fd(vcpu->fd);
> 

Queued, thanks.

Paolo

Re: [Qemu-devel] [PATCH] target: hax: fix a typo

[Laurent Vivier]

Le 28/11/2018 à 13:43, Paolo Bonzini a écrit :
> On 26/11/18 10:58, Li Qiang wrote:
>> Cc: qemu-trivial@nongnu.org
>>
>> Signed-off-by: Li Qiang <liq3ea@gmail.com>
>> ---
>>  target/i386/hax-all.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c
>> index 502ce6f0af..464744a406 100644
>> --- a/target/i386/hax-all.c
>> +++ b/target/i386/hax-all.c
>> @@ -205,7 +205,7 @@ int hax_vcpu_destroy(CPUState *cpu)
>>      }
>>  
>>      /*
>> -     * 1. The hax_tunnel is also destroied when vcpu destroy
>> +     * 1. The hax_tunnel is also destroyed when vcpu destroy
>>       * 2. close fd will cause hax module vcpu be cleaned
>>       */
>>      hax_close_fd(vcpu->fd);
>>
> 
> Queued, thanks.
> 

There is a v2: "target: hax: fix errors in comment" with "vcpu is
destroyed" rather than "vcpu destroy".

Thanks,
Laurent

Re: [Qemu-devel] [PATCH] target: hax: fix a typo

[Paolo Bonzini]

On 28/11/18 13:47, Laurent Vivier wrote:
> Le 28/11/2018 à 13:43, Paolo Bonzini a écrit :
>> On 26/11/18 10:58, Li Qiang wrote:
>>> Cc: qemu-trivial@nongnu.org
>>>
>>> Signed-off-by: Li Qiang <liq3ea@gmail.com>
>>> ---
>>>  target/i386/hax-all.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c
>>> index 502ce6f0af..464744a406 100644
>>> --- a/target/i386/hax-all.c
>>> +++ b/target/i386/hax-all.c
>>> @@ -205,7 +205,7 @@ int hax_vcpu_destroy(CPUState *cpu)
>>>      }
>>>  
>>>      /*
>>> -     * 1. The hax_tunnel is also destroied when vcpu destroy
>>> +     * 1. The hax_tunnel is also destroyed when vcpu destroy
>>>       * 2. close fd will cause hax module vcpu be cleaned
>>>       */
>>>      hax_close_fd(vcpu->fd);
>>>
>>
>> Queued, thanks.
>>
> 
> There is a v2: "target: hax: fix errors in comment" with "vcpu is
> destroyed" rather than "vcpu destroy".
> 
> Thanks,
> Laurent
> 

Got it---I'll adjust my filter to hide qemu-trivial patches. :)

Paolo