All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Ming Lei <ming.lei@redhat.com>,
	linux-scsi@vger.kernel.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
	Hannes Reinecke <hare@suse.com>, Christoph Hellwig <hch@lst.de>,
	Jim Gill <jgill@vmware.com>, Cathy Avery <cavery@redhat.com>,
	"Ewan D . Milne" <emilne@redhat.com>,
	Brian King <brking@us.ibm.com>,
	James Smart <james.smart@broadcom.com>,
	"Juergen E . Fischer" <fischer@norbit.de>,
	Michael Schmitz <schmitzmic@gmail.com>,
	Finn Thain <fthain@telegraphics.com.au>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, linux-usb@vger.kernel.org,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Benjamin Block <bblock@linux.ibm.com>
Subject: Re: [PATCH V4 00/16] use sg helper to operate scatterlist
Date: Mon, 17 Jun 2019 16:52:25 -0700	[thread overview]
Message-ID: <25be959c-82fc-996e-76ed-c1fe7b4dce5d@acm.org> (raw)
In-Reply-To: <20190617030349.26415-1-ming.lei@redhat.com>

On 6/16/19 8:03 PM, Ming Lei wrote:
> Scsi MQ makes a large static allocation for the first scatter gather
> list chunk for the driver to use.  This is a performance headache we'd
> like to fix by reducing the size of the allocation to a 2 element
> array.  Doing this will break the current guarantee that any driver
> using SG_ALL doesn't need to use the scatterlist iterators and can get
> away with directly dereferencing the array.  Thus we need to update all
> drivers to use the scatterlist iterators and remove direct indexing of
> the scatterlist array before reducing the initial scatterlist
> allocation size in SCSI.

For all patches in this series except 9/16 and 11/16, please add the 
following:

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <bvanassche@acm.org>
To: Ming Lei <ming.lei@redhat.com>,
	linux-scsi@vger.kernel.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Michael Schmitz <schmitzmic@gmail.com>,
	devel@driverdev.osuosl.org, Hannes Reinecke <hare@suse.com>,
	Benjamin Block <bblock@linux.ibm.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, James Smart <james.smart@broadcom.com>,
	"Ewan D . Milne" <emilne@redhat.com>, Jim Gill <jgill@vmware.com>,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	Brian King <brking@us.ibm.com>,
	Finn Thain <fthain@telegraphics.com.au>,
	"Juergen E . Fischer" <fischer@norbit.de>,
	Christoph Hellwig <hch@lst.de>,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH V4 00/16] use sg helper to operate scatterlist
Date: Mon, 17 Jun 2019 16:52:25 -0700	[thread overview]
Message-ID: <25be959c-82fc-996e-76ed-c1fe7b4dce5d@acm.org> (raw)
In-Reply-To: <20190617030349.26415-1-ming.lei@redhat.com>

On 6/16/19 8:03 PM, Ming Lei wrote:
> Scsi MQ makes a large static allocation for the first scatter gather
> list chunk for the driver to use.  This is a performance headache we'd
> like to fix by reducing the size of the allocation to a 2 element
> array.  Doing this will break the current guarantee that any driver
> using SG_ALL doesn't need to use the scatterlist iterators and can get
> away with directly dereferencing the array.  Thus we need to update all
> drivers to use the scatterlist iterators and remove direct indexing of
> the scatterlist array before reducing the initial scatterlist
> allocation size in SCSI.

For all patches in this series except 9/16 and 11/16, please add the 
following:

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

  parent reply	other threads:[~2019-06-17 23:52 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-17  3:03 [PATCH V4 00/16] use sg helper to operate scatterlist Ming Lei
2019-06-17  3:03 ` Ming Lei
2019-06-17  3:03 ` [PATCH V4 01/16] scsi: vmw_pscsi: " Ming Lei
2019-06-17  3:03   ` Ming Lei
2019-06-17  8:22   ` Christoph Hellwig
2019-06-17  8:22     ` Christoph Hellwig
2019-06-17  3:03 ` [PATCH V4 02/16] scsi: advansys: " Ming Lei
2019-06-17  3:03   ` Ming Lei
2019-06-17  8:22   ` Christoph Hellwig
2019-06-17  8:22     ` Christoph Hellwig
2019-06-17  3:03 ` [PATCH V4 03/16] scsi: lpfc: " Ming Lei
2019-06-17  3:03   ` Ming Lei
2019-06-17  8:22   ` Christoph Hellwig
2019-06-17  8:22     ` Christoph Hellwig
2019-06-17  3:03 ` [PATCH V4 04/16] scsi: mvumi: " Ming Lei
2019-06-17  3:03   ` Ming Lei
2019-06-17  8:22   ` Christoph Hellwig
2019-06-17  8:22     ` Christoph Hellwig
2019-06-17  3:03 ` [PATCH V4 05/16] scsi: ipr: " Ming Lei
2019-06-17  3:03   ` Ming Lei
2019-06-17  8:24   ` Christoph Hellwig
2019-06-17  8:24     ` Christoph Hellwig
2019-06-17  8:50     ` Ming Lei
2019-06-17  8:50       ` Ming Lei
2019-06-17  3:03 ` [PATCH V4 06/16] scsi: pmcraid: " Ming Lei
2019-06-17  3:03   ` Ming Lei
2019-06-17  8:24   ` Christoph Hellwig
2019-06-17  8:24     ` Christoph Hellwig
2019-06-17  3:03 ` [PATCH V4 07/16] usb: image: microtek: " Ming Lei
2019-06-17  3:03   ` Ming Lei
2019-06-17  8:25   ` Christoph Hellwig
2019-06-17  8:25     ` Christoph Hellwig
2019-06-17  3:03 ` [PATCH V4 08/16] staging: unisys: visorhba: " Ming Lei
2019-06-17  3:03   ` Ming Lei
2019-06-17  8:25   ` Christoph Hellwig
2019-06-17  8:25     ` Christoph Hellwig
2019-06-17  3:03 ` [PATCH V4 09/16] staging: rtsx: " Ming Lei
2019-06-17  3:03   ` Ming Lei
2019-06-17  8:27   ` Christoph Hellwig
2019-06-17  8:27     ` Christoph Hellwig
2019-06-17  9:15     ` Ming Lei
2019-06-17  9:15       ` Ming Lei
2019-06-17  9:24       ` Christoph Hellwig
2019-06-17  9:24         ` Christoph Hellwig
2019-06-17  3:03 ` [PATCH V4 10/16] s390: zfcp_fc: " Ming Lei
2019-06-17  3:03   ` Ming Lei
2019-06-17  8:27   ` Christoph Hellwig
2019-06-17  8:27     ` Christoph Hellwig
2019-06-17  3:03 ` [PATCH V4 11/16] scsi: aha152x: " Ming Lei
2019-06-17  3:03   ` Ming Lei
2019-06-17  3:35   ` Finn Thain
2019-06-17  3:35     ` Finn Thain
2019-06-17 23:35     ` Finn Thain
2019-06-17 23:35       ` Finn Thain
2019-06-18  0:15       ` Ming Lei
2019-06-18  0:15         ` Ming Lei
2019-06-17  8:28   ` Christoph Hellwig
2019-06-17  8:28     ` Christoph Hellwig
2019-06-17  3:03 ` [PATCH V4 12/16] scsi: imm: " Ming Lei
2019-06-17  3:03   ` Ming Lei
2019-06-17  8:28   ` Christoph Hellwig
2019-06-17  8:28     ` Christoph Hellwig
2019-06-17  3:03 ` [PATCH V4 13/16] scsi: pcmcia: nsp_cs: " Ming Lei
2019-06-17  3:03   ` Ming Lei
2019-06-17  8:29   ` Christoph Hellwig
2019-06-17  8:29     ` Christoph Hellwig
2019-06-17  3:03 ` [PATCH V4 14/16] scsi: ppa: " Ming Lei
2019-06-17  3:03   ` Ming Lei
2019-06-17  8:29   ` Christoph Hellwig
2019-06-17  8:29     ` Christoph Hellwig
2019-06-17  3:03 ` [PATCH V4 15/16] scsi: wd33c93: " Ming Lei
2019-06-17  3:03   ` Ming Lei
2019-06-17  8:29   ` Christoph Hellwig
2019-06-17  8:29     ` Christoph Hellwig
2019-06-17  3:03 ` [PATCH V4 16/16] NCR5380: Support chained sg lists Ming Lei
2019-06-17  3:03   ` Ming Lei
2019-06-17  8:30   ` Christoph Hellwig
2019-06-17  8:30     ` Christoph Hellwig
2019-06-17 23:52 ` Bart Van Assche [this message]
2019-06-17 23:52   ` [PATCH V4 00/16] use sg helper to operate scatterlist Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25be959c-82fc-996e-76ed-c1fe7b4dce5d@acm.org \
    --to=bvanassche@acm.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=bblock@linux.ibm.com \
    --cc=brking@us.ibm.com \
    --cc=cavery@redhat.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=emilne@redhat.com \
    --cc=fischer@norbit.de \
    --cc=fthain@telegraphics.com.au \
    --cc=gregkh@linuxfoundation.org \
    --cc=hare@suse.com \
    --cc=hch@lst.de \
    --cc=james.smart@broadcom.com \
    --cc=jgill@vmware.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=ming.lei@redhat.com \
    --cc=schmitzmic@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.