* [PATCH] arm64: dts: fvp: Remove panel timings
@ 2021-07-14 17:22 Robin Murphy
2021-07-14 22:02 ` Linus Walleij
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Robin Murphy @ 2021-07-14 17:22 UTC (permalink / raw)
To: sudeep.holla, liviu.dudau, lorenzo.pieralisi
Cc: linus.walleij, linux-arm-kernel
The simple-panel driver already has hard-coded timings for
"arm,rtsm-display", and as such screams at us for trying to override a
fixed mode from DT. Since the exact values probably don't matter all
that much anyway, just remove the DT node to keep boot quiet.
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
---
arch/arm64/boot/dts/arm/fvp-base-revc.dts | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/arch/arm64/boot/dts/arm/fvp-base-revc.dts b/arch/arm64/boot/dts/arm/fvp-base-revc.dts
index b8a21092db4d..2732d8e5bb5d 100644
--- a/arch/arm64/boot/dts/arm/fvp-base-revc.dts
+++ b/arch/arm64/boot/dts/arm/fvp-base-revc.dts
@@ -192,18 +192,6 @@ panel_in: endpoint {
remote-endpoint = <&clcd_pads>;
};
};
-
- panel-timing {
- clock-frequency = <63500127>;
- hactive = <1024>;
- hback-porch = <152>;
- hfront-porch = <48>;
- hsync-len = <104>;
- vactive = <768>;
- vback-porch = <23>;
- vfront-porch = <3>;
- vsync-len = <4>;
- };
};
bus@8000000 {
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: fvp: Remove panel timings
2021-07-14 17:22 [PATCH] arm64: dts: fvp: Remove panel timings Robin Murphy
@ 2021-07-14 22:02 ` Linus Walleij
2021-07-15 10:57 ` Sudeep Holla
2021-07-26 10:02 ` Sudeep Holla
2 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2021-07-14 22:02 UTC (permalink / raw)
To: Robin Murphy; +Cc: Sudeep Holla, Liviu Dudau, Lorenzo Pieralisi, Linux ARM
On Wed, Jul 14, 2021 at 7:22 PM Robin Murphy <robin.murphy@arm.com> wrote:
> The simple-panel driver already has hard-coded timings for
> "arm,rtsm-display", and as such screams at us for trying to override a
> fixed mode from DT. Since the exact values probably don't matter all
> that much anyway, just remove the DT node to keep boot quiet.
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Thanks for fixing this, I must have forgotten about it when I added the
RTSM display type.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: fvp: Remove panel timings
2021-07-14 17:22 [PATCH] arm64: dts: fvp: Remove panel timings Robin Murphy
2021-07-14 22:02 ` Linus Walleij
@ 2021-07-15 10:57 ` Sudeep Holla
2021-07-15 11:04 ` Robin Murphy
2021-07-26 10:02 ` Sudeep Holla
2 siblings, 1 reply; 5+ messages in thread
From: Sudeep Holla @ 2021-07-15 10:57 UTC (permalink / raw)
To: Robin Murphy
Cc: liviu.dudau, lorenzo.pieralisi, Sudeep Holla, linus.walleij,
linux-arm-kernel
On Wed, Jul 14, 2021 at 06:22:38PM +0100, Robin Murphy wrote:
> The simple-panel driver already has hard-coded timings for
> "arm,rtsm-display", and as such screams at us for trying to override a
> fixed mode from DT. Since the exact values probably don't matter all
> that much anyway, just remove the DT node to keep boot quiet.
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
> arch/arm64/boot/dts/arm/fvp-base-revc.dts | 12 ------------
> 1 file changed, 12 deletions(-)
>
Hi Robin,
Does this need go as fix for v5.14 ? Or can it wait for v5.15 ?
Fine either way, let me know.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: fvp: Remove panel timings
2021-07-15 10:57 ` Sudeep Holla
@ 2021-07-15 11:04 ` Robin Murphy
0 siblings, 0 replies; 5+ messages in thread
From: Robin Murphy @ 2021-07-15 11:04 UTC (permalink / raw)
To: Sudeep Holla
Cc: liviu.dudau, lorenzo.pieralisi, linus.walleij, linux-arm-kernel
On 2021-07-15 11:57, Sudeep Holla wrote:
> On Wed, Jul 14, 2021 at 06:22:38PM +0100, Robin Murphy wrote:
>> The simple-panel driver already has hard-coded timings for
>> "arm,rtsm-display", and as such screams at us for trying to override a
>> fixed mode from DT. Since the exact values probably don't matter all
>> that much anyway, just remove the DT node to keep boot quiet.
>>
>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
>> ---
>> arch/arm64/boot/dts/arm/fvp-base-revc.dts | 12 ------------
>> 1 file changed, 12 deletions(-)
>>
>
> Hi Robin,
>
> Does this need go as fix for v5.14 ? Or can it wait for v5.15 ?
> Fine either way, let me know.
It's just cleanup really, so 5.15 is fine by me - the driver ignores the
DT data so it has no functional effect, it's merely that the warning is
annoying.
Thanks,
Robin.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: fvp: Remove panel timings
2021-07-14 17:22 [PATCH] arm64: dts: fvp: Remove panel timings Robin Murphy
2021-07-14 22:02 ` Linus Walleij
2021-07-15 10:57 ` Sudeep Holla
@ 2021-07-26 10:02 ` Sudeep Holla
2 siblings, 0 replies; 5+ messages in thread
From: Sudeep Holla @ 2021-07-26 10:02 UTC (permalink / raw)
To: lorenzo.pieralisi, liviu.dudau, Robin Murphy
Cc: Sudeep Holla, linus.walleij, linux-arm-kernel
On Wed, 14 Jul 2021 18:22:38 +0100, Robin Murphy wrote:
> The simple-panel driver already has hard-coded timings for
> "arm,rtsm-display", and as such screams at us for trying to override a
> fixed mode from DT. Since the exact values probably don't matter all
> that much anyway, just remove the DT node to keep boot quiet.
Applied to sudeep.holla/linux (for-next/juno), thanks!
[1/1] arm64: dts: fvp: Remove panel timings
https://git.kernel.org/sudeep.holla/c/15934f515911
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-07-26 10:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-14 17:22 [PATCH] arm64: dts: fvp: Remove panel timings Robin Murphy
2021-07-14 22:02 ` Linus Walleij
2021-07-15 10:57 ` Sudeep Holla
2021-07-15 11:04 ` Robin Murphy
2021-07-26 10:02 ` Sudeep Holla
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.