All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Tiwei Bie <tiwei.bie@intel.com>,
	mst@redhat.com, jasowang@redhat.com,
	virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc: wexu@redhat.com, jfreimann@redhat.com
Subject: Re: [RFC v4 5/5] virtio_ring: enable packed ring
Date: Wed, 16 May 2018 13:15:48 +0300	[thread overview]
Message-ID: <27dfb4e8-6d63-bf7d-0f97-ac51559f8040@cogentembedded.com> (raw)
In-Reply-To: <20180516083737.26504-6-tiwei.bie@intel.com>

On 5/16/2018 11:37 AM, Tiwei Bie wrote:

> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
>   drivers/virtio/virtio_ring.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> index de3839f3621a..b158692263b0 100644
> --- a/drivers/virtio/virtio_ring.c
> +++ b/drivers/virtio/virtio_ring.c
> @@ -1940,6 +1940,8 @@ void vring_transport_features(struct virtio_device *vdev)
>   			break;
>   		case VIRTIO_F_IOMMU_PLATFORM:
>   			break;
> +		case VIRTIO_F_RING_PACKED:
> +			break;

    Why not just add this *case* under the previous *case*?

>    		default:
>   			/* We don't understand this bit. */
>   			__virtio_clear_bit(vdev, i);

MBR, Sergei

WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Tiwei Bie <tiwei.bie@intel.com>,
	mst@redhat.com, jasowang@redhat.com,
	virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc: wexu@redhat.com
Subject: Re: [RFC v4 5/5] virtio_ring: enable packed ring
Date: Wed, 16 May 2018 13:15:48 +0300	[thread overview]
Message-ID: <27dfb4e8-6d63-bf7d-0f97-ac51559f8040@cogentembedded.com> (raw)
In-Reply-To: <20180516083737.26504-6-tiwei.bie@intel.com>

On 5/16/2018 11:37 AM, Tiwei Bie wrote:

> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
>   drivers/virtio/virtio_ring.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> index de3839f3621a..b158692263b0 100644
> --- a/drivers/virtio/virtio_ring.c
> +++ b/drivers/virtio/virtio_ring.c
> @@ -1940,6 +1940,8 @@ void vring_transport_features(struct virtio_device *vdev)
>   			break;
>   		case VIRTIO_F_IOMMU_PLATFORM:
>   			break;
> +		case VIRTIO_F_RING_PACKED:
> +			break;

    Why not just add this *case* under the previous *case*?

>    		default:
>   			/* We don't understand this bit. */
>   			__virtio_clear_bit(vdev, i);

MBR, Sergei

  reply	other threads:[~2018-05-16 10:21 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-16  8:37 [RFC v4 0/5] virtio: support packed ring Tiwei Bie
2018-05-16  8:37 ` [RFC v4 1/5] virtio: add packed ring definitions Tiwei Bie
2018-05-16  8:37   ` Tiwei Bie
2018-05-16  8:37 ` [RFC v4 2/5] virtio_ring: support creating packed ring Tiwei Bie
2018-05-16  8:37 ` Tiwei Bie
2018-05-16  8:37 ` [RFC v4 3/5] virtio_ring: add packed ring support Tiwei Bie
2018-05-16  8:37 ` Tiwei Bie
2018-05-16 11:50   ` Jason Wang
2018-05-16 12:39     ` Tiwei Bie
2018-05-16 12:51       ` Jason Wang
2018-05-16 13:45         ` Tiwei Bie
2018-05-16 13:45         ` Tiwei Bie
2018-05-16 14:05           ` Jason Wang
2018-05-16 14:05           ` Jason Wang
2018-05-16 14:33             ` Tiwei Bie
2018-05-17 12:01               ` Jason Wang
2018-05-17 12:01               ` Jason Wang
2018-05-18 11:29                 ` Tiwei Bie
2018-05-18 13:17                   ` Jason Wang
2018-05-18 13:17                   ` Jason Wang
2018-05-18 14:33                     ` Tiwei Bie
2018-05-19  1:12                       ` Jason Wang
2018-05-19  2:29                         ` Tiwei Bie
2018-05-21  2:30                           ` Jason Wang
2018-05-21  2:39                             ` Tiwei Bie
2018-05-21  2:39                             ` Tiwei Bie
2018-05-21  2:30                           ` Jason Wang
2018-05-19  2:29                         ` Tiwei Bie
2018-05-19  1:12                       ` Jason Wang
2018-05-18 14:33                     ` Tiwei Bie
2018-05-18 11:29                 ` Tiwei Bie
2018-05-16 14:33             ` Tiwei Bie
2018-05-16 12:51       ` Jason Wang
2018-05-16 12:39     ` Tiwei Bie
2018-05-16 11:50   ` Jason Wang
2018-05-16  8:37 ` [RFC v4 4/5] virtio_ring: add event idx support in packed ring Tiwei Bie
2018-05-16  8:37   ` Tiwei Bie
2018-05-16 12:17   ` Jason Wang
2018-05-16 12:58     ` Tiwei Bie
2018-05-16 13:31       ` Jason Wang
2018-05-16 13:31       ` Jason Wang
2018-05-16 12:58     ` Tiwei Bie
2018-05-16 12:17   ` Jason Wang
2018-05-16  8:37 ` [RFC v4 5/5] virtio_ring: enable " Tiwei Bie
2018-05-16  8:37 ` Tiwei Bie
2018-05-16 10:15   ` Sergei Shtylyov [this message]
2018-05-16 10:15     ` Sergei Shtylyov
2018-05-16 10:21     ` Tiwei Bie
2018-05-16 11:42       ` Sergei Shtylyov
2018-05-16 11:42         ` Sergei Shtylyov
2018-05-16 12:26         ` Tiwei Bie
2018-05-16 12:26         ` Tiwei Bie
2018-05-16 10:21     ` Tiwei Bie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27dfb4e8-6d63-bf7d-0f97-ac51559f8040@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=jasowang@redhat.com \
    --cc=jfreimann@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=tiwei.bie@intel.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=wexu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.