* [PATCH -next] PKCS#7: fix sparse non static symbol warning
@ 2014-07-28 13:17 weiyj_lk
2014-07-28 13:57 ` David Howells
0 siblings, 1 reply; 2+ messages in thread
From: weiyj_lk @ 2014-07-28 13:17 UTC (permalink / raw)
To: Herbert Xu, David Howells, Stephen Rothwell; +Cc: Wei Yongjun, linux-crypto
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fixes the following sparse warnings:
crypto/asymmetric_keys/pkcs7_key_type.c:73:17: warning:
symbol 'key_type_pkcs7' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
crypto/asymmetric_keys/pkcs7_key_type.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crypto/asymmetric_keys/pkcs7_key_type.c b/crypto/asymmetric_keys/pkcs7_key_type.c
index 8605ff6..9c60e9c 100644
--- a/crypto/asymmetric_keys/pkcs7_key_type.c
+++ b/crypto/asymmetric_keys/pkcs7_key_type.c
@@ -70,7 +70,7 @@ error:
* user defined keys take an arbitrary string as the description and an
* arbitrary blob of data as the payload
*/
-struct key_type key_type_pkcs7 = {
+static struct key_type key_type_pkcs7 = {
.name = "pkcs7_test",
.def_lookup_type = KEYRING_SEARCH_LOOKUP_DIRECT,
.preparse = pkcs7_preparse,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] PKCS#7: fix sparse non static symbol warning
2014-07-28 13:17 [PATCH -next] PKCS#7: fix sparse non static symbol warning weiyj_lk
@ 2014-07-28 13:57 ` David Howells
0 siblings, 0 replies; 2+ messages in thread
From: David Howells @ 2014-07-28 13:57 UTC (permalink / raw)
To: weiyj_lk
Cc: dhowells, Herbert Xu, Stephen Rothwell, Wei Yongjun, linux-crypto
weiyj_lk@163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fixes the following sparse warnings:
>
> crypto/asymmetric_keys/pkcs7_key_type.c:73:17: warning:
> symbol 'key_type_pkcs7' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-28 13:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-28 13:17 [PATCH -next] PKCS#7: fix sparse non static symbol warning weiyj_lk
2014-07-28 13:57 ` David Howells
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.