From: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
To: Heiko Stuebner <heiko@sntech.de>,
mchehab@kernel.org, hverkuil-cisco@xs4all.nl
Cc: ezequiel@collabora.com, helen.koike@collabora.com,
Laurent.pinchart@ideasonboard.com,
linux-rockchip@lists.infradead.org, linux-media@vger.kernel.org,
Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
Subject: Re: [PATCH v2 1/7] media: rockchip: rkisp1: remove unused irq variable
Date: Tue, 15 Jun 2021 08:44:25 +0300 [thread overview]
Message-ID: <2cab11ac-fb57-73fd-7262-70a3636e1253@collabora.com> (raw)
In-Reply-To: <20210615003741.3758316-2-heiko@sntech.de>
Hi,
On 15.06.21 03:37, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>
> The irq variable in struct rkisp1 is unused as it is only used
> to request the irq during probe, so remove it.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Reviewed-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
> ---
> drivers/media/platform/rockchip/rkisp1/rkisp1-common.h | 1 -
> drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 2 --
> 2 files changed, 3 deletions(-)
>
> diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h b/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h
> index 038c303a8aed..be8a350c7527 100644
> --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h
> +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h
> @@ -352,7 +352,6 @@ struct rkisp1_debug {
> */
> struct rkisp1_device {
> void __iomem *base_addr;
> - int irq;
> struct device *dev;
> unsigned int clk_size;
> struct clk_bulk_data clks[RKISP1_MAX_BUS_CLK];
> diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
> index 7474150b94ed..7afa4c123834 100644
> --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
> +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
> @@ -489,8 +489,6 @@ static int rkisp1_probe(struct platform_device *pdev)
> return ret;
> }
>
> - rkisp1->irq = irq;
> -
> for (i = 0; i < match_data->size; i++)
> rkisp1->clks[i].id = match_data->clks[i];
> ret = devm_clk_bulk_get(dev, match_data->size, rkisp1->clks);
>
WARNING: multiple messages have this Message-ID (diff)
From: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
To: Heiko Stuebner <heiko@sntech.de>,
mchehab@kernel.org, hverkuil-cisco@xs4all.nl
Cc: ezequiel@collabora.com, helen.koike@collabora.com,
Laurent.pinchart@ideasonboard.com,
linux-rockchip@lists.infradead.org, linux-media@vger.kernel.org,
Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
Subject: Re: [PATCH v2 1/7] media: rockchip: rkisp1: remove unused irq variable
Date: Tue, 15 Jun 2021 08:44:25 +0300 [thread overview]
Message-ID: <2cab11ac-fb57-73fd-7262-70a3636e1253@collabora.com> (raw)
In-Reply-To: <20210615003741.3758316-2-heiko@sntech.de>
Hi,
On 15.06.21 03:37, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>
> The irq variable in struct rkisp1 is unused as it is only used
> to request the irq during probe, so remove it.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Reviewed-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
> ---
> drivers/media/platform/rockchip/rkisp1/rkisp1-common.h | 1 -
> drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 2 --
> 2 files changed, 3 deletions(-)
>
> diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h b/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h
> index 038c303a8aed..be8a350c7527 100644
> --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h
> +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h
> @@ -352,7 +352,6 @@ struct rkisp1_debug {
> */
> struct rkisp1_device {
> void __iomem *base_addr;
> - int irq;
> struct device *dev;
> unsigned int clk_size;
> struct clk_bulk_data clks[RKISP1_MAX_BUS_CLK];
> diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
> index 7474150b94ed..7afa4c123834 100644
> --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
> +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
> @@ -489,8 +489,6 @@ static int rkisp1_probe(struct platform_device *pdev)
> return ret;
> }
>
> - rkisp1->irq = irq;
> -
> for (i = 0; i < match_data->size; i++)
> rkisp1->clks[i].id = match_data->clks[i];
> ret = devm_clk_bulk_get(dev, match_data->size, rkisp1->clks);
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2021-06-15 5:44 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 0:37 [PATCH v2 0/7] rkisp1 support for px30 Heiko Stuebner
2021-06-15 0:37 ` Heiko Stuebner
2021-06-15 0:37 ` [PATCH v2 1/7] media: rockchip: rkisp1: remove unused irq variable Heiko Stuebner
2021-06-15 0:37 ` Heiko Stuebner
2021-06-15 5:44 ` Dafna Hirschfeld [this message]
2021-06-15 5:44 ` Dafna Hirschfeld
2021-06-15 0:37 ` [PATCH v2 2/7] media: rockchip: rkisp1: allow separate interrupts Heiko Stuebner
2021-06-15 0:37 ` Heiko Stuebner
2021-06-15 5:42 ` Dafna Hirschfeld
2021-06-15 5:42 ` Dafna Hirschfeld
2021-06-15 0:37 ` [PATCH v2 3/7] media: rockchip: rkisp1: make some isp-param functions variable Heiko Stuebner
2021-06-15 0:37 ` Heiko Stuebner
2021-06-15 5:53 ` Dafna Hirschfeld
2021-06-15 5:53 ` Dafna Hirschfeld
2021-06-15 22:44 ` Heiko Stübner
2021-06-15 22:44 ` Heiko Stübner
2021-06-16 18:17 ` kernel test robot
2021-06-16 18:17 ` kernel test robot
2021-06-16 18:17 ` kernel test robot
2021-06-15 0:37 ` [PATCH v2 4/7] media: rockchip: rkisp1: make some isp-stats " Heiko Stuebner
2021-06-15 0:37 ` Heiko Stuebner
2021-06-15 0:37 ` [PATCH v2 5/7] media: rockchip: rkisp1: add prefixes for v10 specific parts Heiko Stuebner
2021-06-15 0:37 ` Heiko Stuebner
2021-06-15 6:06 ` Dafna Hirschfeld
2021-06-15 6:06 ` Dafna Hirschfeld
2021-06-16 19:36 ` kernel test robot
2021-06-16 19:36 ` kernel test robot
2021-06-16 19:36 ` kernel test robot
2021-06-15 0:37 ` [PATCH v2 6/7] media: rockchip: rkisp1: add support for v12 isp variants Heiko Stuebner
2021-06-15 0:37 ` Heiko Stuebner
2021-06-15 6:33 ` Dafna Hirschfeld
2021-06-15 6:33 ` Dafna Hirschfeld
2021-06-15 22:31 ` Heiko Stübner
2021-06-15 22:31 ` Heiko Stübner
2021-06-15 0:37 ` [PATCH v2 7/7] media: rockchip: rkisp1: add support for px30 isp version Heiko Stuebner
2021-06-15 0:37 ` Heiko Stuebner
2021-06-15 6:31 ` Dafna Hirschfeld
2021-06-15 6:31 ` Dafna Hirschfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cab11ac-fb57-73fd-7262-70a3636e1253@collabora.com \
--to=dafna.hirschfeld@collabora.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=ezequiel@collabora.com \
--cc=heiko.stuebner@theobroma-systems.com \
--cc=heiko@sntech.de \
--cc=helen.koike@collabora.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.