All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Hans Verkuil <hansverk@cisco.com>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>,
	Hans Verkuil <hans.verkuil@cisco.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-media@vger.kernel.org, Andrzej Hajda <a.hajda@samsung.com>,
	Chen-Yu Tsai <wens@csie.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH 0/5] media: Allwinner A10 CSI support
Date: Tue, 13 Nov 2018 18:15:49 +0100	[thread overview]
Message-ID: <2d25e395-af73-e69b-dc8a-3d0956d668f9@xs4all.nl> (raw)
In-Reply-To: <20181113175558.3bfa3e8d@windsurf>

On 11/13/2018 05:55 PM, Thomas Petazzoni wrote:
> Hello,
> 
> On Tue, 13 Nov 2018 17:00:25 +0100, Hans Verkuil wrote:
> 
>> Weird, if I build directly from that tarball, then v4l2-compliance should say:
>>
>> v4l2-compliance SHA: not available, 64 bits
>>
>> So that's what I expect to see from buildroot as well.
> 
> Indeed, that's strange, I see that the v4l2-compliance Makefile does:
> 
> version.h:
>         @if git -C $(srcdir) rev-parse HEAD >/dev/null 2>&1; then \
>                 echo -n "#define SHA " >$@ ; \
>                 git -C $(srcdir) rev-parse HEAD >>$@ ; \
>         else \
>                 touch $@ ; \
>         fi
> 
> which correctly uses $(srcdir), so it shouldn't go "up" the libv4l
> build folder and pick up the latest Buildroot commit SHA1. I'll have a
> quick look.

I think it does, actually. If the tar archive is unpacked inside the
checked-out buildroot git tree, then it will pick up the buildroot SHA.

I fixed v4l-utils to be a bit smarter about this:

https://git.linuxtv.org/v4l-utils.git/patch/?id=98b4c9f276a18535b5691e5f350f59ffbf5a9aa5

Regards,

	Hans

WARNING: multiple messages have this Message-ID (diff)
From: hverkuil@xs4all.nl (Hans Verkuil)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/5] media: Allwinner A10 CSI support
Date: Tue, 13 Nov 2018 18:15:49 +0100	[thread overview]
Message-ID: <2d25e395-af73-e69b-dc8a-3d0956d668f9@xs4all.nl> (raw)
In-Reply-To: <20181113175558.3bfa3e8d@windsurf>

On 11/13/2018 05:55 PM, Thomas Petazzoni wrote:
> Hello,
> 
> On Tue, 13 Nov 2018 17:00:25 +0100, Hans Verkuil wrote:
> 
>> Weird, if I build directly from that tarball, then v4l2-compliance should say:
>>
>> v4l2-compliance SHA: not available, 64 bits
>>
>> So that's what I expect to see from buildroot as well.
> 
> Indeed, that's strange, I see that the v4l2-compliance Makefile does:
> 
> version.h:
>         @if git -C $(srcdir) rev-parse HEAD >/dev/null 2>&1; then \
>                 echo -n "#define SHA " >$@ ; \
>                 git -C $(srcdir) rev-parse HEAD >>$@ ; \
>         else \
>                 touch $@ ; \
>         fi
> 
> which correctly uses $(srcdir), so it shouldn't go "up" the libv4l
> build folder and pick up the latest Buildroot commit SHA1. I'll have a
> quick look.

I think it does, actually. If the tar archive is unpacked inside the
checked-out buildroot git tree, then it will pick up the buildroot SHA.

I fixed v4l-utils to be a bit smarter about this:

https://git.linuxtv.org/v4l-utils.git/patch/?id=98b4c9f276a18535b5691e5f350f59ffbf5a9aa5

Regards,

	Hans

  reply	other threads:[~2018-11-13 17:16 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-13  8:24 [PATCH 0/5] media: Allwinner A10 CSI support Maxime Ripard
2018-11-13  8:24 ` Maxime Ripard
2018-11-13  8:24 ` [PATCH 1/5] dt-bindings: media: Add Allwinner A10 CSI binding Maxime Ripard
2018-11-13  8:24   ` Maxime Ripard
2018-11-13  8:24   ` Maxime Ripard
2018-11-13  8:38   ` Sakari Ailus
2018-11-13  8:38     ` Sakari Ailus
2018-11-15 19:04     ` Maxime Ripard
2018-11-15 19:04       ` Maxime Ripard
2018-11-21 21:56       ` Sakari Ailus
2018-11-21 21:56         ` Sakari Ailus
2018-11-27 15:04         ` Maxime Ripard
2018-11-27 15:04           ` Maxime Ripard
2018-11-13 10:34   ` Sakari Ailus
2018-11-13 10:34     ` Sakari Ailus
2018-11-13  8:24 ` [PATCH 2/5] media: sunxi: Refactor the Makefile and Kconfig Maxime Ripard
2018-11-13  8:24   ` Maxime Ripard
2018-11-13  8:24 ` [PATCH 3/5] media: sunxi: Add A10 CSI driver Maxime Ripard
2018-11-13  8:24   ` Maxime Ripard
2018-11-13  8:57   ` Sakari Ailus
2018-11-13  8:57     ` Sakari Ailus
2018-11-13 12:24   ` Hans Verkuil
2018-11-13 12:24     ` Hans Verkuil
2018-11-13 15:19     ` Joe Perches
2018-11-13 15:19       ` Joe Perches
2018-11-13 15:39       ` Hans Verkuil
2018-11-13 15:39         ` Hans Verkuil
2018-11-15 20:51     ` Maxime Ripard
2018-11-15 20:51       ` Maxime Ripard
2018-11-21 22:01       ` Sakari Ailus
2018-11-21 22:01         ` Sakari Ailus
2018-11-22 13:58         ` Maxime Ripard
2018-11-22 13:58           ` Maxime Ripard
2018-11-13 12:48   ` Fabio Estevam
2018-11-13 12:48     ` Fabio Estevam
2018-11-13 12:48     ` Fabio Estevam
2018-11-13 13:37     ` Hans Verkuil
2018-11-13 13:37       ` Hans Verkuil
2018-11-13 13:37       ` Hans Verkuil
2018-11-13 14:13       ` Fabio Estevam
2018-11-13 14:13         ` Fabio Estevam
2018-11-13 14:13         ` Fabio Estevam
2018-11-13 14:46         ` Thomas Petazzoni
2018-11-13 14:46           ` Thomas Petazzoni
2018-11-13 14:46           ` Thomas Petazzoni
2018-11-13  8:24 ` [PATCH 4/5] ARM: dts: sun7i: Add CSI0 controller Maxime Ripard
2018-11-13  8:24   ` Maxime Ripard
2018-11-13  8:24 ` [PATCH 5/5] DO NOT MERGE: ARM: dts: bananapi: Add Camera support Maxime Ripard
2018-11-13  8:24   ` Maxime Ripard
2018-11-27  6:56   ` Jagan Teki
2018-11-27  6:56     ` Jagan Teki
2018-11-27 10:31     ` Maxime Ripard
2018-11-27 10:31       ` Maxime Ripard
2018-11-27 11:00       ` Jagan Teki
2018-11-27 11:00         ` Jagan Teki
2018-11-27 15:19         ` Maxime Ripard
2018-11-27 15:19           ` Maxime Ripard
2018-11-27 15:34           ` Jagan Teki
2018-11-27 15:34             ` Jagan Teki
2018-11-13 12:30 ` [PATCH 0/5] media: Allwinner A10 CSI support Hans Verkuil
2018-11-13 12:30   ` Hans Verkuil
2018-11-13 13:52   ` Maxime Ripard
2018-11-13 13:52     ` Maxime Ripard
2018-11-13 14:01     ` Hans Verkuil
2018-11-13 14:01       ` Hans Verkuil
2018-11-13 15:52       ` Maxime Ripard
2018-11-13 15:52         ` Maxime Ripard
2018-11-13 16:00         ` Hans Verkuil
2018-11-13 16:00           ` Hans Verkuil
2018-11-13 16:55           ` Thomas Petazzoni
2018-11-13 16:55             ` Thomas Petazzoni
2018-11-13 17:15             ` Hans Verkuil [this message]
2018-11-13 17:15               ` Hans Verkuil
2018-11-14  3:24 ` Chen-Yu Tsai
2018-11-14  3:24   ` Chen-Yu Tsai
2018-11-15 19:10   ` Maxime Ripard
2018-11-15 19:10     ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d25e395-af73-e69b-dc8a-3d0956d668f9@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=a.hajda@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=hans.verkuil@cisco.com \
    --cc=hansverk@cisco.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=mchehab@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.