All of lore.kernel.org
 help / color / mirror / Atom feed
From: Schrempf Frieder <frieder.schrempf@kontron.De>
To: Peter Chen <peter.chen@nxp.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Cc: dl-linux-imx <linux-imx@nxp.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"frieder.schrempf@exceet.de" <frieder.schrempf@exceet.de>,
	"festevam@gmail.com" <festevam@gmail.com>
Subject: Re: [PATCH v2 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups
Date: Mon, 22 Oct 2018 14:54:57 +0000	[thread overview]
Message-ID: <2f67fca8-5a50-641e-9e56-6a5a701a2f70@kontron.de> (raw)
In-Reply-To: <20181022054031.14027-5-peter.chen@nxp.com>

On 22.10.18 07:43, Peter Chen wrote:
> For USB HSIC, the data and strobe pin needs to be pulled down
> at default, we consider it as "idle" state. When the USB host
> is ready to be used, the strobe pin needs to be pulled up,
> we consider it as "active" state.
> 
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
>   Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> index 529e51879fb2..10c8d793ea49 100644
> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> @@ -81,6 +81,7 @@ Optional properties:
>     mux state of 1 indicates host mode.
>   - mux-control-names: Shall be "usb_switch" if mux-controls is specified.
>   - pinctrl-names: Names for optional pin modes in "default", "host", "device"
> +  Or names for HSIC "idle" and "active" pin modes.

I think you forgot to improve this description. Maybe something like this:

pinctrl-names: Names for optional pin modes for "default", "host" or
                "device". In case of HSIC-mode "idle" and "active" pin
                modes are mandatory. In this case the "idle" state needs
                to pull down the data and strobe pin and the "active"
                state needs to pull up the strobe pin.

Thanks,
Frieder

>   - pinctrl-n: alternate pin modes
>   
>   i.mx specific properties
> 

WARNING: multiple messages have this Message-ID (diff)
From: Frieder Schrempf <frieder.schrempf@kontron.de>
To: Peter Chen <peter.chen@nxp.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Cc: dl-linux-imx <linux-imx@nxp.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"frieder.schrempf@exceet.de" <frieder.schrempf@exceet.de>,
	"festevam@gmail.com" <festevam@gmail.com>
Subject: [v2,4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups
Date: Mon, 22 Oct 2018 14:54:57 +0000	[thread overview]
Message-ID: <2f67fca8-5a50-641e-9e56-6a5a701a2f70@kontron.de> (raw)

On 22.10.18 07:43, Peter Chen wrote:
> For USB HSIC, the data and strobe pin needs to be pulled down
> at default, we consider it as "idle" state. When the USB host
> is ready to be used, the strobe pin needs to be pulled up,
> we consider it as "active" state.
> 
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
>   Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> index 529e51879fb2..10c8d793ea49 100644
> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
> @@ -81,6 +81,7 @@ Optional properties:
>     mux state of 1 indicates host mode.
>   - mux-control-names: Shall be "usb_switch" if mux-controls is specified.
>   - pinctrl-names: Names for optional pin modes in "default", "host", "device"
> +  Or names for HSIC "idle" and "active" pin modes.

I think you forgot to improve this description. Maybe something like this:

pinctrl-names: Names for optional pin modes for "default", "host" or
                "device". In case of HSIC-mode "idle" and "active" pin
                modes are mandatory. In this case the "idle" state needs
                to pull down the data and strobe pin and the "active"
                state needs to pull up the strobe pin.

Thanks,
Frieder

>   - pinctrl-n: alternate pin modes
>   
>   i.mx specific properties
>

  reply	other threads:[~2018-10-22 23:21 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-22  5:42 [PATCH v2 0/4] usb: chipidea: imx: add HSIC support Peter Chen
2018-10-22  5:42 ` [PATCH v2 1/4] usb: chipidea: add flag for imx hsic implementation Peter Chen
2018-10-22  5:42   ` [v2,1/4] " Peter Chen
2018-11-05  8:52   ` [PATCH v2 1/4] " Schrempf Frieder
2018-11-05  8:52     ` [v2,1/4] " Frieder Schrempf
2018-11-05  9:31     ` [PATCH v2 1/4] " Peter Chen
2018-11-05  9:31       ` [v2,1/4] " Peter Chen
2018-10-22  5:43 ` [PATCH v2 2/4] usb: chipidea: imx: add HSIC support Peter Chen
2018-10-22  5:43   ` [v2,2/4] " Peter Chen
2018-11-05  8:52   ` [PATCH v2 2/4] " Schrempf Frieder
2018-11-05  8:52     ` [v2,2/4] " Frieder Schrempf
2018-11-05  9:40     ` [PATCH v2 2/4] " Peter Chen
2018-11-05  9:40       ` [v2,2/4] " Peter Chen
2018-10-22  5:43 ` [PATCH v2 3/4] usb: chipidea: host: override ehci->hub_control Peter Chen
2018-10-22  5:43   ` [v2,3/4] " Peter Chen
2018-10-22  5:43 ` [PATCH v2 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups Peter Chen
2018-10-22  5:43   ` [v2,4/4] " Peter Chen
2018-10-22 14:54   ` Schrempf Frieder [this message]
2018-10-22 14:54     ` Frieder Schrempf
2018-10-22 14:59     ` [PATCH v2 4/4] " Fabio Estevam
2018-10-22 14:59       ` [v2,4/4] " Fabio Estevam
2018-10-23  5:59       ` [PATCH v2 4/4] " Peter Chen
2018-10-23  5:59         ` [v2,4/4] " Peter Chen
2018-10-23  6:30 ` [PATCH v2 0/4] usb: chipidea: imx: add HSIC support Schrempf Frieder
2018-10-23  6:33   ` Peter Chen
2018-11-05  8:52     ` Schrempf Frieder
2018-11-19  8:36       ` Schrempf Frieder
2018-11-20  2:11         ` PETER CHEN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f67fca8-5a50-641e-9e56-6a5a701a2f70@kontron.de \
    --to=frieder.schrempf@kontron.de \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=frieder.schrempf@exceet.de \
    --cc=linux-imx@nxp.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=peter.chen@nxp.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.