* [PATCH] btrfs: Extend btrfs/003 device removal test
@ 2019-03-19 10:58 Nikolay Borisov
2019-03-19 11:04 ` Nikolay Borisov
0 siblings, 1 reply; 2+ messages in thread
From: Nikolay Borisov @ 2019-03-19 10:58 UTC (permalink / raw)
To: fstests; +Cc: linux-btrfs, guaneryu, Nikolay Borisov
When a device is deleted/removed from a btrfs filesystem the kernel
ensures all superblocks on said device are zeroed out. Test for this
behavior. Since btrfs inspect-internal dump-super always return success
I cannot test for the return value of the command. Instead there are 2
cases to handle:
1. When the device is smaller than the requested super block copy, i.e.
super block copy 2 resides at 256GB. In such cases btrfs command just
returns blank screen
2. When the device is removed and a valid offset of the super block is
queried btrfs command returns a textual error to stderr.
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
tests/btrfs/003 | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/tests/btrfs/003 b/tests/btrfs/003
index 22aa57aad0b9..938030ef4c65 100755
--- a/tests/btrfs/003
+++ b/tests/btrfs/003
@@ -161,6 +161,13 @@ _test_remove()
dev_del=`echo ${SCRATCH_DEV_POOL} | awk '{print $NF}'`
$BTRFS_UTIL_PROG device delete $dev_del $SCRATCH_MNT || _fail "btrfs device delete failed"
$BTRFS_UTIL_PROG filesystem show $SCRATCH_DEV 2>&1 | grep $dev_del >> $seqres.full && _fail "btrfs still shows the deleted dev"
+ for i in {0..2}; do
+ local output=$($BTRFS_UTIL_PROG inspect-internal dump-super -s $i $dev_del 2>&1)
+ $BTRFS_UTIL_PROG inspect-internal dump-super -s $i $dev_del 2>&1 | grep -q "bad magic"
+ if [[ "$output" != "" && $ret -eq 1 ]]; then
+ _fail "Delete dev superblocks not scratched"
+ fi
+ done
_scratch_unmount
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] btrfs: Extend btrfs/003 device removal test
2019-03-19 10:58 [PATCH] btrfs: Extend btrfs/003 device removal test Nikolay Borisov
@ 2019-03-19 11:04 ` Nikolay Borisov
0 siblings, 0 replies; 2+ messages in thread
From: Nikolay Borisov @ 2019-03-19 11:04 UTC (permalink / raw)
To: fstests; +Cc: linux-btrfs, guaneryu
On 19.03.19 г. 12:58 ч., Nikolay Borisov wrote:
> When a device is deleted/removed from a btrfs filesystem the kernel
> ensures all superblocks on said device are zeroed out. Test for this
> behavior. Since btrfs inspect-internal dump-super always return success
> I cannot test for the return value of the command. Instead there are 2
> cases to handle:
>
> 1. When the device is smaller than the requested super block copy, i.e.
> super block copy 2 resides at 256GB. In such cases btrfs command just
> returns blank screen
>
> 2. When the device is removed and a valid offset of the super block is
> queried btrfs command returns a textual error to stderr.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> ---
Disregard this version and check v2.
> tests/btrfs/003 | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/tests/btrfs/003 b/tests/btrfs/003
> index 22aa57aad0b9..938030ef4c65 100755
> --- a/tests/btrfs/003
> +++ b/tests/btrfs/003
> @@ -161,6 +161,13 @@ _test_remove()
> dev_del=`echo ${SCRATCH_DEV_POOL} | awk '{print $NF}'`
> $BTRFS_UTIL_PROG device delete $dev_del $SCRATCH_MNT || _fail "btrfs device delete failed"
> $BTRFS_UTIL_PROG filesystem show $SCRATCH_DEV 2>&1 | grep $dev_del >> $seqres.full && _fail "btrfs still shows the deleted dev"
> + for i in {0..2}; do
> + local output=$($BTRFS_UTIL_PROG inspect-internal dump-super -s $i $dev_del 2>&1)
> + $BTRFS_UTIL_PROG inspect-internal dump-super -s $i $dev_del 2>&1 | grep -q "bad magic"
> + if [[ "$output" != "" && $ret -eq 1 ]]; then
> + _fail "Delete dev superblocks not scratched"
> + fi
> + done
> _scratch_unmount
> }
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-19 11:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-19 10:58 [PATCH] btrfs: Extend btrfs/003 device removal test Nikolay Borisov
2019-03-19 11:04 ` Nikolay Borisov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.