From: David Howells <dhowells@redhat.com>
To: Hillf Danton <hdanton@sina.com>
Cc: dhowells@redhat.com,
syzbot <syzbot+6455648abc28dbdd1e7f@syzkaller.appspotmail.com>,
jarkko.sakkinen@linux.intel.com, jmorris@namei.org,
keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, serge@hallyn.com,
syzkaller-bugs@googlegroups.com
Subject: Re: WARNING: refcount bug in find_key_to_update
Date: Fri, 18 Oct 2019 16:46:27 +0000 [thread overview]
Message-ID: <32000.1571417187@warthog.procyon.org.uk> (raw)
In-Reply-To: <20191017092428.7336-1-hdanton@sina.com>
Hillf Danton <hdanton@sina.com> wrote:
> - (1 << KEY_FLAG_REVOKED))) {
> + (1 << KEY_FLAG_REVOKED)) || !key_tryget(key)) {
> kleave(" = NULL [x]");
> return NULL;
> }
> - __key_get(key);
That should be ineffective and ought not to fix the bug.
David
WARNING: multiple messages have this Message-ID (diff)
From: David Howells <dhowells@redhat.com>
To: Hillf Danton <hdanton@sina.com>
Cc: dhowells@redhat.com,
syzbot <syzbot+6455648abc28dbdd1e7f@syzkaller.appspotmail.com>,
jarkko.sakkinen@linux.intel.com, jmorris@namei.org,
keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, serge@hallyn.com,
syzkaller-bugs@googlegroups.com
Subject: Re: WARNING: refcount bug in find_key_to_update
Date: Fri, 18 Oct 2019 17:46:27 +0100 [thread overview]
Message-ID: <32000.1571417187@warthog.procyon.org.uk> (raw)
In-Reply-To: <20191017092428.7336-1-hdanton@sina.com>
Hillf Danton <hdanton@sina.com> wrote:
> - (1 << KEY_FLAG_REVOKED))) {
> + (1 << KEY_FLAG_REVOKED)) || !key_tryget(key)) {
> kleave(" = NULL [x]");
> return NULL;
> }
> - __key_get(key);
That should be ineffective and ought not to fix the bug.
David
next parent reply other threads:[~2019-10-18 16:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191017092428.7336-1-hdanton@sina.com>
2019-10-18 16:46 ` David Howells [this message]
2019-10-18 16:46 ` WARNING: refcount bug in find_key_to_update David Howells
2019-10-17 1:42 syzbot
2019-10-17 1:42 ` syzbot
2019-10-17 2:42 ` syzbot
2019-10-17 2:42 ` syzbot
2019-10-17 2:42 ` syzbot
2019-10-17 15:53 ` Linus Torvalds
2019-10-17 15:53 ` Linus Torvalds
2019-10-17 15:53 ` Linus Torvalds
2019-10-17 16:00 ` Eric Biggers
2019-10-17 16:00 ` Eric Biggers
2019-10-17 16:00 ` Eric Biggers
2019-10-18 10:54 ` Tetsuo Handa
2019-10-18 10:54 ` Tetsuo Handa
2019-10-18 16:45 ` David Howells
2019-10-18 16:45 ` David Howells
2019-10-18 16:38 ` David Howells
2019-10-18 16:38 ` David Howells
2019-10-18 16:38 ` David Howells
2019-10-22 10:35 ` David Howells
2019-10-22 10:35 ` David Howells
2019-10-22 10:35 ` David Howells
2019-10-22 13:17 ` David Howells
2019-10-22 13:17 ` David Howells
2019-10-22 13:17 ` David Howells
2019-10-21 15:59 ` David Howells
2019-10-21 15:59 ` David Howells
2019-10-21 16:05 ` Dmitry Vyukov
2019-10-21 16:05 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32000.1571417187@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=hdanton@sina.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=syzbot+6455648abc28dbdd1e7f@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.