* [PATCH] mmc: fsl_esdhc_imx: fix the DTOCV to 0xE
@ 2021-02-19 19:25 ` Ye Li
2021-02-21 23:39 ` Jaehoon Chung
2021-03-01 11:56 ` sbabic at denx.de
0 siblings, 2 replies; 3+ messages in thread
From: Ye Li @ 2021-02-19 19:25 UTC (permalink / raw)
To: u-boot
From: Haibo Chen <haibo.chen@nxp.com>
On imx6Q/imx6DL, we find if config the DTOCV to 0~3, it will impact
cmd6 behavior, after cmd6 get transfer complete interrupt, the data0
line will keep low over 5 seconds. This should be a IC bug on imx6Q/DL.
For other platforms, do not has this issue.
To fix this issue, fix the DTOCV to 0xE, the max setting, this also align
with Linux configuration.
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
Reviewed-by: Ye Li <ye.li@nxp.com>
---
drivers/mmc/fsl_esdhc_imx.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/mmc/fsl_esdhc_imx.c b/drivers/mmc/fsl_esdhc_imx.c
index e0e1326..7b31ed8 100644
--- a/drivers/mmc/fsl_esdhc_imx.c
+++ b/drivers/mmc/fsl_esdhc_imx.c
@@ -43,6 +43,12 @@
#include "mmc_private.h"
#endif
+#ifndef ESDHCI_QUIRK_BROKEN_TIMEOUT_VALUE
+#ifdef CONFIG_FSL_USDHC
+#define ESDHCI_QUIRK_BROKEN_TIMEOUT_VALUE 1
+#endif
+#endif
+
DECLARE_GLOBAL_DATA_PTR;
#define SDHCI_IRQ_EN_BITS (IRQSTATEN_CC | IRQSTATEN_TC | \
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] mmc: fsl_esdhc_imx: fix the DTOCV to 0xE
2021-02-19 19:25 ` [PATCH] mmc: fsl_esdhc_imx: fix the DTOCV to 0xE Ye Li
@ 2021-02-21 23:39 ` Jaehoon Chung
2021-03-01 11:56 ` sbabic at denx.de
1 sibling, 0 replies; 3+ messages in thread
From: Jaehoon Chung @ 2021-02-21 23:39 UTC (permalink / raw)
To: u-boot
On 2/20/21 4:25 AM, Ye Li wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
>
> On imx6Q/imx6DL, we find if config the DTOCV to 0~3, it will impact
> cmd6 behavior, after cmd6 get transfer complete interrupt, the data0
> line will keep low over 5 seconds. This should be a IC bug on imx6Q/DL.
> For other platforms, do not has this issue.
>
> To fix this issue, fix the DTOCV to 0xE, the max setting, this also align
> with Linux configuration.
>
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> Reviewed-by: Ye Li <ye.li@nxp.com>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Best Regards,
Jaehoon Chung
> ---
> drivers/mmc/fsl_esdhc_imx.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/mmc/fsl_esdhc_imx.c b/drivers/mmc/fsl_esdhc_imx.c
> index e0e1326..7b31ed8 100644
> --- a/drivers/mmc/fsl_esdhc_imx.c
> +++ b/drivers/mmc/fsl_esdhc_imx.c
> @@ -43,6 +43,12 @@
> #include "mmc_private.h"
> #endif
>
> +#ifndef ESDHCI_QUIRK_BROKEN_TIMEOUT_VALUE
> +#ifdef CONFIG_FSL_USDHC
> +#define ESDHCI_QUIRK_BROKEN_TIMEOUT_VALUE 1
> +#endif
> +#endif
> +
> DECLARE_GLOBAL_DATA_PTR;
>
> #define SDHCI_IRQ_EN_BITS (IRQSTATEN_CC | IRQSTATEN_TC | \
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] mmc: fsl_esdhc_imx: fix the DTOCV to 0xE
2021-02-19 19:25 ` [PATCH] mmc: fsl_esdhc_imx: fix the DTOCV to 0xE Ye Li
2021-02-21 23:39 ` Jaehoon Chung
@ 2021-03-01 11:56 ` sbabic at denx.de
1 sibling, 0 replies; 3+ messages in thread
From: sbabic at denx.de @ 2021-03-01 11:56 UTC (permalink / raw)
To: u-boot
> From: Haibo Chen <haibo.chen@nxp.com>
> On imx6Q/imx6DL, we find if config the DTOCV to 0~3, it will impact
> cmd6 behavior, after cmd6 get transfer complete interrupt, the data0
> line will keep low over 5 seconds. This should be a IC bug on imx6Q/DL.
> For other platforms, do not has this issue.
> To fix this issue, fix the DTOCV to 0xE, the max setting, this also align
> with Linux configuration.
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> Reviewed-by: Ye Li <ye.li@nxp.com>
> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-01 11:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20210220072630epcas1p2e14149ace7592b1a1f805d4ac8e2f313@epcas1p2.samsung.com>
2021-02-19 19:25 ` [PATCH] mmc: fsl_esdhc_imx: fix the DTOCV to 0xE Ye Li
2021-02-21 23:39 ` Jaehoon Chung
2021-03-01 11:56 ` sbabic at denx.de
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.