From: John Garry <john.garry@huawei.com>
To: Yicong Yang <yangyicong@huawei.com>,
Yicong Yang <yangyicong@hisilicon.com>,
<gregkh@linuxfoundation.org>, <helgaas@kernel.org>,
<alexander.shishkin@linux.intel.com>, <lorenzo.pieralisi@arm.com>,
<will@kernel.org>, <mark.rutland@arm.com>,
<mathieu.poirier@linaro.org>, <suzuki.poulose@arm.com>,
<mike.leach@linaro.org>, <leo.yan@linaro.org>,
<jonathan.cameron@huawei.com>, <daniel.thompson@linaro.org>,
<joro@8bytes.org>, <shameerali.kolothum.thodi@huawei.com>,
<robin.murphy@arm.com>, <peterz@infradead.org>,
<mingo@redhat.com>, <acme@kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<coresight@lists.linaro.org>, <linux-pci@vger.kernel.org>,
<linux-perf-users@vger.kernel.org>,
<iommu@lists.linux-foundation.org>
Cc: <prime.zeng@huawei.com>, <liuqi115@huawei.com>,
<zhangshaokun@hisilicon.com>, <linuxarm@huawei.com>
Subject: Re: [PATCH v7 5/7] perf tool: Add support for HiSilicon PCIe Tune and Trace device driver
Date: Thu, 14 Apr 2022 14:00:44 +0100 [thread overview]
Message-ID: <40f03ea6-1690-8a6f-2969-24c47f39c215@huawei.com> (raw)
In-Reply-To: <e2b7484b-eb15-029c-b1e1-4831368f61c9@huawei.com>
On 12/04/2022 08:41, Yicong Yang wrote:
>>> + hisi_ptt_pmus = zalloc(sizeof(struct perf_pmu *) * (*nr_ptts));
>>> + if (!hisi_ptt_pmus) {
>>> + pr_err("hisi_ptt alloc failed\n");
>>> + *err = -ENOMEM;
>> using PTR_ERR seems better, if possible
>>
> ok will change to that. *err = -ENOMEM is used here to keep consistence with
> what spe does.
>
Ah, I see that we are contrained by the interface of
auxtrace_record_init() to pass err as a pointer, so I suppose the code
in this patch is ok to fit into that.
WARNING: multiple messages have this Message-ID (diff)
From: John Garry via iommu <iommu@lists.linux-foundation.org>
To: Yicong Yang <yangyicong@huawei.com>,
Yicong Yang <yangyicong@hisilicon.com>,
<gregkh@linuxfoundation.org>, <helgaas@kernel.org>,
<alexander.shishkin@linux.intel.com>, <lorenzo.pieralisi@arm.com>,
<will@kernel.org>, <mark.rutland@arm.com>,
<mathieu.poirier@linaro.org>, <suzuki.poulose@arm.com>,
<mike.leach@linaro.org>, <leo.yan@linaro.org>,
<jonathan.cameron@huawei.com>, <daniel.thompson@linaro.org>,
<joro@8bytes.org>, <shameerali.kolothum.thodi@huawei.com>,
<robin.murphy@arm.com>, <peterz@infradead.org>,
<mingo@redhat.com>, <acme@kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<coresight@lists.linaro.org>, <linux-pci@vger.kernel.org>,
<linux-perf-users@vger.kernel.org>,
<iommu@lists.linux-foundation.org>
Cc: zhangshaokun@hisilicon.com, liuqi115@huawei.com,
linuxarm@huawei.com, prime.zeng@huawei.com
Subject: Re: [PATCH v7 5/7] perf tool: Add support for HiSilicon PCIe Tune and Trace device driver
Date: Thu, 14 Apr 2022 14:00:44 +0100 [thread overview]
Message-ID: <40f03ea6-1690-8a6f-2969-24c47f39c215@huawei.com> (raw)
In-Reply-To: <e2b7484b-eb15-029c-b1e1-4831368f61c9@huawei.com>
On 12/04/2022 08:41, Yicong Yang wrote:
>>> + hisi_ptt_pmus = zalloc(sizeof(struct perf_pmu *) * (*nr_ptts));
>>> + if (!hisi_ptt_pmus) {
>>> + pr_err("hisi_ptt alloc failed\n");
>>> + *err = -ENOMEM;
>> using PTR_ERR seems better, if possible
>>
> ok will change to that. *err = -ENOMEM is used here to keep consistence with
> what spe does.
>
Ah, I see that we are contrained by the interface of
auxtrace_record_init() to pass err as a pointer, so I suppose the code
in this patch is ok to fit into that.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: John Garry <john.garry@huawei.com>
To: Yicong Yang <yangyicong@huawei.com>,
Yicong Yang <yangyicong@hisilicon.com>,
<gregkh@linuxfoundation.org>, <helgaas@kernel.org>,
<alexander.shishkin@linux.intel.com>, <lorenzo.pieralisi@arm.com>,
<will@kernel.org>, <mark.rutland@arm.com>,
<mathieu.poirier@linaro.org>, <suzuki.poulose@arm.com>,
<mike.leach@linaro.org>, <leo.yan@linaro.org>,
<jonathan.cameron@huawei.com>, <daniel.thompson@linaro.org>,
<joro@8bytes.org>, <shameerali.kolothum.thodi@huawei.com>,
<robin.murphy@arm.com>, <peterz@infradead.org>,
<mingo@redhat.com>, <acme@kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<coresight@lists.linaro.org>, <linux-pci@vger.kernel.org>,
<linux-perf-users@vger.kernel.org>,
<iommu@lists.linux-foundation.org>
Cc: <prime.zeng@huawei.com>, <liuqi115@huawei.com>,
<zhangshaokun@hisilicon.com>, <linuxarm@huawei.com>
Subject: Re: [PATCH v7 5/7] perf tool: Add support for HiSilicon PCIe Tune and Trace device driver
Date: Thu, 14 Apr 2022 14:00:44 +0100 [thread overview]
Message-ID: <40f03ea6-1690-8a6f-2969-24c47f39c215@huawei.com> (raw)
In-Reply-To: <e2b7484b-eb15-029c-b1e1-4831368f61c9@huawei.com>
On 12/04/2022 08:41, Yicong Yang wrote:
>>> + hisi_ptt_pmus = zalloc(sizeof(struct perf_pmu *) * (*nr_ptts));
>>> + if (!hisi_ptt_pmus) {
>>> + pr_err("hisi_ptt alloc failed\n");
>>> + *err = -ENOMEM;
>> using PTR_ERR seems better, if possible
>>
> ok will change to that. *err = -ENOMEM is used here to keep consistence with
> what spe does.
>
Ah, I see that we are contrained by the interface of
auxtrace_record_init() to pass err as a pointer, so I suppose the code
in this patch is ok to fit into that.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-14 12:59 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 12:58 [PATCH v7 0/7] Add support for HiSilicon PCIe Tune and Trace device Yicong Yang via iommu
2022-04-07 12:58 ` Yicong Yang
2022-04-07 12:58 ` Yicong Yang
2022-04-07 12:58 ` [PATCH v7 1/7] iommu/arm-smmu-v3: Make default domain type of HiSilicon PTT device to identity Yicong Yang via iommu
2022-04-07 12:58 ` Yicong Yang
2022-04-07 12:58 ` Yicong Yang
2022-05-10 11:23 ` Will Deacon
2022-05-10 11:23 ` Will Deacon
2022-05-10 11:23 ` Will Deacon
2022-05-10 12:43 ` Yicong Yang
2022-05-10 12:43 ` Yicong Yang
2022-05-10 12:43 ` Yicong Yang via iommu
2022-05-11 11:42 ` John Garry
2022-05-11 11:42 ` John Garry
2022-05-11 11:42 ` John Garry via iommu
2022-04-07 12:58 ` [PATCH v7 2/7] hwtracing: Add trace function support for HiSilicon PCIe Tune and Trace device Yicong Yang via iommu
2022-04-07 12:58 ` Yicong Yang
2022-04-07 12:58 ` Yicong Yang
2022-04-11 17:02 ` John Garry
2022-04-11 17:02 ` John Garry
2022-04-11 17:02 ` John Garry via iommu
2022-04-12 7:36 ` Yicong Yang via iommu
2022-04-12 7:36 ` Yicong Yang
2022-04-12 7:36 ` Yicong Yang
2022-04-12 8:39 ` John Garry via iommu
2022-04-12 8:39 ` John Garry
2022-04-12 8:39 ` John Garry
2022-04-12 12:52 ` Yicong Yang via iommu
2022-04-12 12:52 ` Yicong Yang
2022-04-12 12:52 ` Yicong Yang
2022-04-29 16:00 ` Leo Yan
2022-04-29 16:00 ` Leo Yan
2022-04-29 16:00 ` Leo Yan
2022-05-05 12:13 ` Yicong Yang
2022-05-05 12:13 ` Yicong Yang
2022-05-05 12:13 ` Yicong Yang via iommu
2022-05-10 9:46 ` James Clark
2022-05-10 9:46 ` James Clark
2022-05-10 9:46 ` James Clark
2022-05-10 11:18 ` Yicong Yang
2022-05-10 11:18 ` Yicong Yang
2022-05-10 11:18 ` Yicong Yang via iommu
2022-05-10 12:54 ` James Clark
2022-05-10 12:54 ` James Clark
2022-05-10 12:54 ` James Clark
2022-05-10 13:17 ` Yicong Yang via iommu
2022-05-10 13:17 ` Yicong Yang
2022-05-10 13:17 ` Yicong Yang
2022-04-07 12:58 ` [PATCH v7 3/7] hisi_ptt: Add support for dynamically updating the filter list Yicong Yang via iommu
2022-04-07 12:58 ` Yicong Yang
2022-04-07 12:58 ` Yicong Yang
2022-04-07 12:58 ` [PATCH v7 4/7] hisi_ptt: Add tune function support for HiSilicon PCIe Tune and Trace device Yicong Yang via iommu
2022-04-07 12:58 ` Yicong Yang
2022-04-07 12:58 ` Yicong Yang
2022-04-07 12:58 ` [PATCH v7 5/7] perf tool: Add support for HiSilicon PCIe Tune and Trace device driver Yicong Yang via iommu
2022-04-07 12:58 ` Yicong Yang
2022-04-07 12:58 ` Yicong Yang
2022-04-11 17:19 ` John Garry
2022-04-11 17:19 ` John Garry
2022-04-11 17:19 ` John Garry via iommu
2022-04-12 7:41 ` Yicong Yang via iommu
2022-04-12 7:41 ` Yicong Yang
2022-04-12 7:41 ` Yicong Yang
2022-04-14 13:00 ` John Garry [this message]
2022-04-14 13:00 ` John Garry
2022-04-14 13:00 ` John Garry via iommu
2022-04-30 7:35 ` Leo Yan
2022-04-30 7:35 ` Leo Yan
2022-04-30 7:35 ` Leo Yan
2022-05-05 11:30 ` liuqi (BA)
2022-05-05 11:30 ` liuqi (BA) via iommu
2022-05-05 11:30 ` liuqi (BA)
2022-05-10 10:14 ` James Clark
2022-05-10 10:14 ` James Clark
2022-05-10 10:14 ` James Clark
2022-05-11 2:02 ` liuqi (BA)
2022-05-11 2:02 ` liuqi (BA)
2022-05-11 2:02 ` liuqi (BA) via iommu
2022-05-11 9:18 ` James Clark
2022-05-11 9:18 ` James Clark
2022-05-11 9:18 ` James Clark
2022-04-07 12:58 ` [PATCH v7 6/7] docs: Add HiSilicon PTT device driver documentation Yicong Yang via iommu
2022-04-07 12:58 ` Yicong Yang
2022-04-07 12:58 ` Yicong Yang
2022-04-07 12:58 ` [PATCH v7 7/7] MAINTAINERS: Add maintainer for HiSilicon PTT driver Yicong Yang via iommu
2022-04-07 12:58 ` Yicong Yang
2022-04-07 12:58 ` Yicong Yang
2022-04-14 13:20 ` [PATCH v7 0/7] Add support for HiSilicon PCIe Tune and Trace device Yicong Yang via iommu
2022-04-14 13:20 ` Yicong Yang
2022-04-14 13:20 ` Yicong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40f03ea6-1690-8a6f-2969-24c47f39c215@huawei.com \
--to=john.garry@huawei.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jonathan.cameron@huawei.com \
--cc=joro@8bytes.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liuqi115@huawei.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=prime.zeng@huawei.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yangyicong@hisilicon.com \
--cc=yangyicong@huawei.com \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.