All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	<chunkuang.hu@kernel.org>, <robh+dt@kernel.org>,
	<krzk+dt@kernel.org>
Cc: devicetree@vger.kernel.org, airlied@linux.ie,
	jason-jh.lin@mediatek.com, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	Project_Global_Chrome_Upstream_Group@mediatek.com,
	nancy.lin@mediatek.com, linux-mediatek@lists.infradead.org,
	yongqiang.niu@mediatek.com, matthias.bgg@gmail.com,
	linux-arm-kernel@lists.infradead.org,
	allen-kh.cheng@mediatek.com
Subject: Re: [PATCH 1/3] dt-bindings: display: mediatek: Correct disp_aal binding for MT8183
Date: Wed, 6 Apr 2022 18:49:59 +0800	[thread overview]
Message-ID: <42e890bef5927f2c4854c146f9bab2f974b64a48.camel@mediatek.com> (raw)
In-Reply-To: <19a1af29-19a7-a546-b565-a2cc973a7f28@collabora.com>

On Wed, 2022-04-06 at 12:38 +0200, AngeloGioacchino Del Regno wrote:
> Il 06/04/22 11:46, Rex-BC Chen ha scritto:
> > The driver data of MT8183 and MT8173 are different.
> > The value of has_gamma for MT8173 is true while the value of MT8183
> > is
> > false. Therefore, the compatible of disp_aal for MT8183 is not
> > suitable
> > for the compatible for MT8173.
> > 
> > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> 
> Hello!
> Yes, I definitely agree with this change, it makes no sense to have
> both
> 8173 and 8183 compatibles for 8183 (and similar).
> 
> Though, please, add a note in this commit message advertising that
> the
> mistake was only in the yaml binding, as the driver doesn't require
> any
> functional changes, so that things are clear for people with less
> expertise
> on MediaTek platforms.
> 
> After that:
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>

Hello Angelo,

Thanks for your review.
I will add them to the commit message in next version.

BRs,
Rex


WARNING: multiple messages have this Message-ID (diff)
From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	<chunkuang.hu@kernel.org>, <robh+dt@kernel.org>,
	<krzk+dt@kernel.org>
Cc: <matthias.bgg@gmail.com>, <p.zabel@pengutronix.de>,
	<airlied@linux.ie>, <yongqiang.niu@mediatek.com>,
	<jason-jh.lin@mediatek.com>, <nancy.lin@mediatek.com>,
	<allen-kh.cheng@mediatek.com>, <dri-devel@lists.freedesktop.org>,
	<linux-mediatek@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH 1/3] dt-bindings: display: mediatek: Correct disp_aal binding for MT8183
Date: Wed, 6 Apr 2022 18:49:59 +0800	[thread overview]
Message-ID: <42e890bef5927f2c4854c146f9bab2f974b64a48.camel@mediatek.com> (raw)
In-Reply-To: <19a1af29-19a7-a546-b565-a2cc973a7f28@collabora.com>

On Wed, 2022-04-06 at 12:38 +0200, AngeloGioacchino Del Regno wrote:
> Il 06/04/22 11:46, Rex-BC Chen ha scritto:
> > The driver data of MT8183 and MT8173 are different.
> > The value of has_gamma for MT8173 is true while the value of MT8183
> > is
> > false. Therefore, the compatible of disp_aal for MT8183 is not
> > suitable
> > for the compatible for MT8173.
> > 
> > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> 
> Hello!
> Yes, I definitely agree with this change, it makes no sense to have
> both
> 8173 and 8183 compatibles for 8183 (and similar).
> 
> Though, please, add a note in this commit message advertising that
> the
> mistake was only in the yaml binding, as the driver doesn't require
> any
> functional changes, so that things are clear for people with less
> expertise
> on MediaTek platforms.
> 
> After that:
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>

Hello Angelo,

Thanks for your review.
I will add them to the commit message in next version.

BRs,
Rex


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	<chunkuang.hu@kernel.org>, <robh+dt@kernel.org>,
	<krzk+dt@kernel.org>
Cc: <matthias.bgg@gmail.com>, <p.zabel@pengutronix.de>,
	<airlied@linux.ie>, <yongqiang.niu@mediatek.com>,
	<jason-jh.lin@mediatek.com>, <nancy.lin@mediatek.com>,
	<allen-kh.cheng@mediatek.com>, <dri-devel@lists.freedesktop.org>,
	<linux-mediatek@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH 1/3] dt-bindings: display: mediatek: Correct disp_aal binding for MT8183
Date: Wed, 6 Apr 2022 18:49:59 +0800	[thread overview]
Message-ID: <42e890bef5927f2c4854c146f9bab2f974b64a48.camel@mediatek.com> (raw)
In-Reply-To: <19a1af29-19a7-a546-b565-a2cc973a7f28@collabora.com>

On Wed, 2022-04-06 at 12:38 +0200, AngeloGioacchino Del Regno wrote:
> Il 06/04/22 11:46, Rex-BC Chen ha scritto:
> > The driver data of MT8183 and MT8173 are different.
> > The value of has_gamma for MT8173 is true while the value of MT8183
> > is
> > false. Therefore, the compatible of disp_aal for MT8183 is not
> > suitable
> > for the compatible for MT8173.
> > 
> > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> 
> Hello!
> Yes, I definitely agree with this change, it makes no sense to have
> both
> 8173 and 8183 compatibles for 8183 (and similar).
> 
> Though, please, add a note in this commit message advertising that
> the
> mistake was only in the yaml binding, as the driver doesn't require
> any
> functional changes, so that things are clear for people with less
> expertise
> on MediaTek platforms.
> 
> After that:
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>

Hello Angelo,

Thanks for your review.
I will add them to the commit message in next version.

BRs,
Rex


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>,
	<chunkuang.hu@kernel.org>, <robh+dt@kernel.org>,
	<krzk+dt@kernel.org>
Cc: <matthias.bgg@gmail.com>, <p.zabel@pengutronix.de>,
	<airlied@linux.ie>, <yongqiang.niu@mediatek.com>,
	<jason-jh.lin@mediatek.com>, <nancy.lin@mediatek.com>,
	<allen-kh.cheng@mediatek.com>, <dri-devel@lists.freedesktop.org>,
	<linux-mediatek@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH 1/3] dt-bindings: display: mediatek: Correct disp_aal binding for MT8183
Date: Wed, 6 Apr 2022 18:49:59 +0800	[thread overview]
Message-ID: <42e890bef5927f2c4854c146f9bab2f974b64a48.camel@mediatek.com> (raw)
In-Reply-To: <19a1af29-19a7-a546-b565-a2cc973a7f28@collabora.com>

On Wed, 2022-04-06 at 12:38 +0200, AngeloGioacchino Del Regno wrote:
> Il 06/04/22 11:46, Rex-BC Chen ha scritto:
> > The driver data of MT8183 and MT8173 are different.
> > The value of has_gamma for MT8173 is true while the value of MT8183
> > is
> > false. Therefore, the compatible of disp_aal for MT8183 is not
> > suitable
> > for the compatible for MT8173.
> > 
> > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> 
> Hello!
> Yes, I definitely agree with this change, it makes no sense to have
> both
> 8173 and 8183 compatibles for 8183 (and similar).
> 
> Though, please, add a note in this commit message advertising that
> the
> mistake was only in the yaml binding, as the driver doesn't require
> any
> functional changes, so that things are clear for people with less
> expertise
> on MediaTek platforms.
> 
> After that:
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>

Hello Angelo,

Thanks for your review.
I will add them to the commit message in next version.

BRs,
Rex


  reply	other threads:[~2022-04-06 10:50 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-06  9:46 [PATCH 0/3] Correct disp_aal dt-binding Rex-BC Chen
2022-04-06  9:46 ` Rex-BC Chen
2022-04-06  9:46 ` Rex-BC Chen
2022-04-06  9:46 ` Rex-BC Chen
2022-04-06  9:46 ` [PATCH 1/3] dt-bindings: display: mediatek: Correct disp_aal binding for MT8183 Rex-BC Chen
2022-04-06  9:46   ` Rex-BC Chen
2022-04-06  9:46   ` Rex-BC Chen
2022-04-06  9:46   ` Rex-BC Chen
2022-04-06 10:38   ` AngeloGioacchino Del Regno
2022-04-06 10:38     ` AngeloGioacchino Del Regno
2022-04-06 10:38     ` AngeloGioacchino Del Regno
2022-04-06 10:38     ` AngeloGioacchino Del Regno
2022-04-06 10:49     ` Rex-BC Chen [this message]
2022-04-06 10:49       ` Rex-BC Chen
2022-04-06 10:49       ` Rex-BC Chen
2022-04-06 10:49       ` Rex-BC Chen
2022-04-06 14:44   ` Krzysztof Kozlowski
2022-04-06 14:44     ` Krzysztof Kozlowski
2022-04-06 14:44     ` Krzysztof Kozlowski
2022-04-06 14:44     ` Krzysztof Kozlowski
2022-04-07  6:22     ` Rex-BC Chen
2022-04-07  6:22       ` Rex-BC Chen
2022-04-07  6:22       ` Rex-BC Chen
2022-04-07  6:22       ` Rex-BC Chen
2022-04-07  6:49       ` Krzysztof Kozlowski
2022-04-07  6:49         ` Krzysztof Kozlowski
2022-04-07  6:49         ` Krzysztof Kozlowski
2022-04-07  6:49         ` Krzysztof Kozlowski
2022-04-07  8:38         ` Rex-BC Chen
2022-04-07  8:38           ` Rex-BC Chen
2022-04-07  8:38           ` Rex-BC Chen
2022-04-07  8:38           ` Rex-BC Chen
2022-04-06  9:46 ` [PATCH 2/3] arm64: dts: mt8183: Correct disp_aal node compatible Rex-BC Chen
2022-04-06  9:46   ` Rex-BC Chen
2022-04-06  9:46   ` Rex-BC Chen
2022-04-06  9:46   ` Rex-BC Chen
2022-04-06 10:39   ` AngeloGioacchino Del Regno
2022-04-06 10:39     ` AngeloGioacchino Del Regno
2022-04-06 10:39     ` AngeloGioacchino Del Regno
2022-04-06 10:39     ` AngeloGioacchino Del Regno
2022-04-06  9:46 ` [PATCH 3/3] dt-bindings: display: mediatek: Correct disp_aal binding for MT8192 Rex-BC Chen
2022-04-06  9:46   ` Rex-BC Chen
2022-04-06  9:46   ` Rex-BC Chen
2022-04-06  9:46   ` Rex-BC Chen
2022-04-06 10:40   ` AngeloGioacchino Del Regno
2022-04-06 10:40     ` AngeloGioacchino Del Regno
2022-04-06 10:40     ` AngeloGioacchino Del Regno
2022-04-06 10:40     ` AngeloGioacchino Del Regno
2022-04-06 10:48     ` Rex-BC Chen
2022-04-06 10:48       ` Rex-BC Chen
2022-04-06 10:48       ` Rex-BC Chen
2022-04-06 10:48       ` Rex-BC Chen
2022-04-06 10:51       ` AngeloGioacchino Del Regno
2022-04-06 10:51         ` AngeloGioacchino Del Regno
2022-04-06 10:51         ` AngeloGioacchino Del Regno
2022-04-06 10:51         ` AngeloGioacchino Del Regno
2022-04-07  8:43     ` Rex-BC Chen
2022-04-07  8:43       ` Rex-BC Chen
2022-04-07  8:43       ` Rex-BC Chen
2022-04-07  8:43       ` Rex-BC Chen
2022-04-06 14:46   ` Krzysztof Kozlowski
2022-04-06 14:46     ` Krzysztof Kozlowski
2022-04-06 14:46     ` Krzysztof Kozlowski
2022-04-06 14:46     ` Krzysztof Kozlowski
2022-04-07  6:07     ` Rex-BC Chen
2022-04-07  6:07       ` Rex-BC Chen
2022-04-07  6:07       ` Rex-BC Chen
2022-04-07  6:07       ` Rex-BC Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42e890bef5927f2c4854c146f9bab2f974b64a48.camel@mediatek.com \
    --to=rex-bc.chen@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=airlied@linux.ie \
    --cc=allen-kh.cheng@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jason-jh.lin@mediatek.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nancy.lin@mediatek.com \
    --cc=robh+dt@kernel.org \
    --cc=yongqiang.niu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.