From: Alex Elder <elder@ieee.org>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
Oleksii Kurochko <olkuroch@cisco.com>,
Sagi Grimberg <sagi@grimberg.me>,
Mike Snitzer <snitzer@redhat.com>,
Ilya Dryomov <idryomov@gmail.com>,
Dongsheng Yang <dongsheng.yang@easystack.cn>,
ceph-devel@vger.kernel.org, dm-devel@redhat.com,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH 1/4] block: add a hard-readonly flag to struct gendisk
Date: Sun, 29 Nov 2020 19:23:29 -0600 [thread overview]
Message-ID: <44c60506-059f-f272-208f-a39d94a8617d@ieee.org> (raw)
In-Reply-To: <20201129181926.897775-2-hch@lst.de>
On 11/29/20 12:19 PM, Christoph Hellwig wrote:
> Commit 20bd1d026aac ("scsi: sd: Keep disk read-only when re-reading
> partition") addressed a long-standing problem with user read-only
Little nit I noticed below. -Alex
. . .
> diff --git a/block/genhd.c b/block/genhd.c
> index 565cf36a5f1864..5e746223b6fa0f 100644
> --- a/block/genhd.c
> +++ b/block/genhd.c
> @@ -1625,31 +1625,35 @@ static void set_disk_ro_uevent(struct gendisk *gd, int ro)
> kobject_uevent_env(&disk_to_dev(gd)->kobj, KOBJ_CHANGE, envp);
> }
>
> -void set_disk_ro(struct gendisk *disk, int flag)
> +/**
> + * set_disk_ro - set a gendisk read-only
> + * @disk: The disk device
> + * @state: true or false
s/state/read_only/
> + *
> + * This function is used to indicate whether a given disk device should have its
> + * read-only flag set. set_disk_ro() is typically used by device drivers to
> + * indicate whether the underlying physical device is write-protected.
> + */
> +void set_disk_ro(struct gendisk *disk, bool read_only)
. . .
WARNING: multiple messages have this Message-ID (diff)
From: Alex Elder <elder@ieee.org>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: Sagi Grimberg <sagi@grimberg.me>,
Mike Snitzer <snitzer@redhat.com>,
Oleksii Kurochko <olkuroch@cisco.com>,
Dongsheng Yang <dongsheng.yang@easystack.cn>,
linux-block@vger.kernel.org, dm-devel@redhat.com,
linux-nvme@lists.infradead.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Ilya Dryomov <idryomov@gmail.com>,
ceph-devel@vger.kernel.org
Subject: Re: [PATCH 1/4] block: add a hard-readonly flag to struct gendisk
Date: Sun, 29 Nov 2020 19:23:29 -0600 [thread overview]
Message-ID: <44c60506-059f-f272-208f-a39d94a8617d@ieee.org> (raw)
In-Reply-To: <20201129181926.897775-2-hch@lst.de>
On 11/29/20 12:19 PM, Christoph Hellwig wrote:
> Commit 20bd1d026aac ("scsi: sd: Keep disk read-only when re-reading
> partition") addressed a long-standing problem with user read-only
Little nit I noticed below. -Alex
. . .
> diff --git a/block/genhd.c b/block/genhd.c
> index 565cf36a5f1864..5e746223b6fa0f 100644
> --- a/block/genhd.c
> +++ b/block/genhd.c
> @@ -1625,31 +1625,35 @@ static void set_disk_ro_uevent(struct gendisk *gd, int ro)
> kobject_uevent_env(&disk_to_dev(gd)->kobj, KOBJ_CHANGE, envp);
> }
>
> -void set_disk_ro(struct gendisk *disk, int flag)
> +/**
> + * set_disk_ro - set a gendisk read-only
> + * @disk: The disk device
> + * @state: true or false
s/state/read_only/
> + *
> + * This function is used to indicate whether a given disk device should have its
> + * read-only flag set. set_disk_ro() is typically used by device drivers to
> + * indicate whether the underlying physical device is write-protected.
> + */
> +void set_disk_ro(struct gendisk *disk, bool read_only)
. . .
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
WARNING: multiple messages have this Message-ID (diff)
From: Alex Elder <elder@ieee.org>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: Sagi Grimberg <sagi@grimberg.me>,
Mike Snitzer <snitzer@redhat.com>,
Oleksii Kurochko <olkuroch@cisco.com>,
Dongsheng Yang <dongsheng.yang@easystack.cn>,
linux-block@vger.kernel.org, dm-devel@redhat.com,
linux-nvme@lists.infradead.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Ilya Dryomov <idryomov@gmail.com>,
ceph-devel@vger.kernel.org
Subject: Re: [dm-devel] [PATCH 1/4] block: add a hard-readonly flag to struct gendisk
Date: Sun, 29 Nov 2020 19:23:29 -0600 [thread overview]
Message-ID: <44c60506-059f-f272-208f-a39d94a8617d@ieee.org> (raw)
In-Reply-To: <20201129181926.897775-2-hch@lst.de>
On 11/29/20 12:19 PM, Christoph Hellwig wrote:
> Commit 20bd1d026aac ("scsi: sd: Keep disk read-only when re-reading
> partition") addressed a long-standing problem with user read-only
Little nit I noticed below. -Alex
. . .
> diff --git a/block/genhd.c b/block/genhd.c
> index 565cf36a5f1864..5e746223b6fa0f 100644
> --- a/block/genhd.c
> +++ b/block/genhd.c
> @@ -1625,31 +1625,35 @@ static void set_disk_ro_uevent(struct gendisk *gd, int ro)
> kobject_uevent_env(&disk_to_dev(gd)->kobj, KOBJ_CHANGE, envp);
> }
>
> -void set_disk_ro(struct gendisk *disk, int flag)
> +/**
> + * set_disk_ro - set a gendisk read-only
> + * @disk: The disk device
> + * @state: true or false
s/state/read_only/
> + *
> + * This function is used to indicate whether a given disk device should have its
> + * read-only flag set. set_disk_ro() is typically used by device drivers to
> + * indicate whether the underlying physical device is write-protected.
> + */
> +void set_disk_ro(struct gendisk *disk, bool read_only)
. . .
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2020-11-30 1:24 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-29 18:19 split hard read-only vs read-only policy v2 Christoph Hellwig
2020-11-29 18:19 ` [dm-devel] " Christoph Hellwig
2020-11-29 18:19 ` Christoph Hellwig
2020-11-29 18:19 ` [PATCH 1/4] block: add a hard-readonly flag to struct gendisk Christoph Hellwig
2020-11-29 18:19 ` [dm-devel] " Christoph Hellwig
2020-11-29 18:19 ` Christoph Hellwig
2020-11-30 1:23 ` Alex Elder [this message]
2020-11-30 1:23 ` [dm-devel] " Alex Elder
2020-11-30 1:23 ` Alex Elder
2020-11-30 7:55 ` Hannes Reinecke
2020-11-30 7:55 ` [dm-devel] " Hannes Reinecke
2020-11-30 7:55 ` Hannes Reinecke
2020-12-03 4:04 ` Martin K. Petersen
2020-12-03 4:04 ` [dm-devel] " Martin K. Petersen
2020-12-03 4:04 ` Martin K. Petersen
2020-12-03 8:53 ` Christoph Hellwig
2020-12-03 8:53 ` [dm-devel] " Christoph Hellwig
2020-12-03 8:53 ` Christoph Hellwig
2020-12-03 14:01 ` Martin K. Petersen
2020-12-03 14:01 ` [dm-devel] " Martin K. Petersen
2020-12-03 14:01 ` Martin K. Petersen
2020-11-29 18:19 ` [PATCH 2/4] rbd: remove the ->set_read_only method Christoph Hellwig
2020-11-29 18:19 ` [dm-devel] " Christoph Hellwig
2020-11-29 18:19 ` Christoph Hellwig
2020-11-30 7:56 ` Hannes Reinecke
2020-11-30 7:56 ` [dm-devel] " Hannes Reinecke
2020-11-30 7:56 ` Hannes Reinecke
2020-11-29 18:19 ` [PATCH 3/4] nvme: allow revalidate to set a namespace read-only Christoph Hellwig
2020-11-29 18:19 ` [dm-devel] " Christoph Hellwig
2020-11-29 18:19 ` Christoph Hellwig
2020-11-29 21:13 ` Chaitanya Kulkarni
2020-11-29 21:13 ` [dm-devel] " Chaitanya Kulkarni
2020-11-29 21:13 ` Chaitanya Kulkarni
2020-11-30 7:57 ` Hannes Reinecke
2020-11-30 7:57 ` [dm-devel] " Hannes Reinecke
2020-11-30 7:57 ` Hannes Reinecke
2020-11-29 18:19 ` [PATCH 4/4] dm: use bdev_read_only to check if a device is read-only Christoph Hellwig
2020-11-29 18:19 ` [dm-devel] " Christoph Hellwig
2020-11-29 18:19 ` Christoph Hellwig
2020-11-30 7:58 ` Hannes Reinecke
2020-11-30 7:58 ` [dm-devel] " Hannes Reinecke
2020-11-30 7:58 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44c60506-059f-f272-208f-a39d94a8617d@ieee.org \
--to=elder@ieee.org \
--cc=axboe@kernel.dk \
--cc=ceph-devel@vger.kernel.org \
--cc=dm-devel@redhat.com \
--cc=dongsheng.yang@easystack.cn \
--cc=hch@lst.de \
--cc=idryomov@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=olkuroch@cisco.com \
--cc=sagi@grimberg.me \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.