From: Chao Yu <chao@kernel.org> To: Jaegeuk Kim <jaegeuk@kernel.org>, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 3/5] f2fs: keep wait_ms if EAGAIN happens Date: Sun, 8 May 2022 23:22:16 +0800 [thread overview] Message-ID: <44d184dd-ad4c-eac9-c631-98fabcc14294@kernel.org> (raw) In-Reply-To: <eb8f1316-11df-ab02-1834-542ca193c17c@kernel.org> On 2022/5/8 22:41, Chao Yu wrote: > On 2022/5/7 7:20, Jaegeuk Kim wrote: >> In f2fs_gc thread, let's keep wait_ms when sec_freed was zero. > > sec_freed won't increase for background GC due to below statement: > > if (gc_type == FG_GC && > get_valid_blocks(sbi, segno, false) == 0) > seg_freed++; > > It may cause gc thread migrates lots of segments in each round? Please ignore this comment, I misunderstood it. :-P > > Thanks, > >> >> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> Reviewed-by: Chao Yu <chao@kernel.org> Thanks,
WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <chao@kernel.org> To: Jaegeuk Kim <jaegeuk@kernel.org>, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 3/5] f2fs: keep wait_ms if EAGAIN happens Date: Sun, 8 May 2022 23:22:16 +0800 [thread overview] Message-ID: <44d184dd-ad4c-eac9-c631-98fabcc14294@kernel.org> (raw) In-Reply-To: <eb8f1316-11df-ab02-1834-542ca193c17c@kernel.org> On 2022/5/8 22:41, Chao Yu wrote: > On 2022/5/7 7:20, Jaegeuk Kim wrote: >> In f2fs_gc thread, let's keep wait_ms when sec_freed was zero. > > sec_freed won't increase for background GC due to below statement: > > if (gc_type == FG_GC && > get_valid_blocks(sbi, segno, false) == 0) > seg_freed++; > > It may cause gc thread migrates lots of segments in each round? Please ignore this comment, I misunderstood it. :-P > > Thanks, > >> >> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> Reviewed-by: Chao Yu <chao@kernel.org> Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2022-05-08 15:22 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-06 23:20 [PATCH 1/5] f2fs: stop allocating pinned sections if EAGAIN happens Jaegeuk Kim 2022-05-06 23:20 ` [f2fs-dev] " Jaegeuk Kim 2022-05-06 23:20 ` [PATCH 2/5] f2fs: introduce f2fs_gc_control to consolidate f2fs_gc parameters Jaegeuk Kim 2022-05-06 23:20 ` [f2fs-dev] " Jaegeuk Kim 2022-05-08 14:27 ` Chao Yu 2022-05-08 14:27 ` Chao Yu 2022-05-09 16:46 ` Jaegeuk Kim 2022-05-09 16:46 ` Jaegeuk Kim 2022-05-09 16:47 ` [f2fs-dev] [PATCH 2/5 v2] " Jaegeuk Kim 2022-05-09 16:47 ` Jaegeuk Kim 2022-05-11 3:16 ` [f2fs-dev] " Chao Yu 2022-05-11 3:16 ` Chao Yu 2022-05-11 3:30 ` Jaegeuk Kim 2022-05-11 3:30 ` Jaegeuk Kim 2022-05-11 3:30 ` Jaegeuk Kim 2022-05-11 3:30 ` Jaegeuk Kim 2022-05-11 8:54 ` Chao Yu 2022-05-11 8:54 ` Chao Yu 2022-05-12 20:51 ` Jaegeuk Kim 2022-05-12 20:51 ` [f2fs-dev] " Jaegeuk Kim 2022-05-06 23:20 ` [PATCH 3/5] f2fs: keep wait_ms if EAGAIN happens Jaegeuk Kim 2022-05-06 23:20 ` [f2fs-dev] " Jaegeuk Kim 2022-05-08 14:41 ` Chao Yu 2022-05-08 14:41 ` Chao Yu 2022-05-08 15:22 ` Chao Yu [this message] 2022-05-08 15:22 ` Chao Yu 2022-05-06 23:20 ` [PATCH 4/5] f2fs: do not stop GC when requiring a free section Jaegeuk Kim 2022-05-06 23:20 ` [f2fs-dev] " Jaegeuk Kim 2022-05-07 3:33 ` Chao Yu 2022-05-07 3:33 ` Chao Yu 2022-05-09 16:58 ` Jaegeuk Kim 2022-05-09 16:58 ` Jaegeuk Kim 2022-05-08 15:25 ` Chao Yu 2022-05-08 15:25 ` Chao Yu 2022-05-09 16:55 ` Jaegeuk Kim 2022-05-09 16:55 ` Jaegeuk Kim 2022-05-11 8:53 ` Chao Yu 2022-05-11 8:53 ` Chao Yu 2022-05-11 16:47 ` Jaegeuk Kim 2022-05-11 16:47 ` Jaegeuk Kim 2022-05-12 2:04 ` Chao Yu 2022-05-12 2:04 ` Chao Yu 2022-05-12 21:05 ` Jaegeuk Kim 2022-05-12 21:05 ` Jaegeuk Kim 2022-05-12 20:50 ` [PATCH 4/5 v2] " Jaegeuk Kim 2022-05-12 20:50 ` [f2fs-dev] " Jaegeuk Kim 2022-05-12 21:54 ` Jaegeuk Kim 2022-05-12 21:54 ` Jaegeuk Kim 2022-05-15 14:26 ` Chao Yu 2022-05-15 14:26 ` Chao Yu 2022-05-16 17:29 ` Jaegeuk Kim 2022-05-16 17:29 ` Jaegeuk Kim 2022-05-17 2:19 ` Chao Yu 2022-05-17 2:19 ` Chao Yu 2022-05-06 23:20 ` [PATCH 5/5] f2fs: don't need inode lock for system hidden quota Jaegeuk Kim 2022-05-06 23:20 ` [f2fs-dev] " Jaegeuk Kim 2022-05-08 13:56 ` [f2fs-dev] [PATCH 1/5] f2fs: stop allocating pinned sections if EAGAIN happens Chao Yu 2022-05-08 13:56 ` Chao Yu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=44d184dd-ad4c-eac9-c631-98fabcc14294@kernel.org \ --to=chao@kernel.org \ --cc=jaegeuk@kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.