[PATCH] staging: sm750fb: Add SPDX GPL-2.0 license identifier

[PATCH] staging: sm750fb: Add SPDX GPL-2.0 license identifier

[Sanjana Sanikommu]

Add the SPDX GPL-2.0 license identifier to fix checkpatch.pl warning
Issue found by checkpatch.pl warning:
"WARNING: Missing or malformed SPDX-License-Identifier tag in line 1"

Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
---
 drivers/staging/sm750fb/sm750.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index e1a892e3b3ad..105089b97bf5 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/errno.h>
-- 
2.17.1

Re: [PATCH] staging: sm750fb: Add SPDX GPL-2.0 license identifier

[Greg KH]

On Tue, Apr 02, 2019 at 11:13:33AM +0530, Sanjana Sanikommu wrote:
> Add the SPDX GPL-2.0 license identifier to fix checkpatch.pl warning
> Issue found by checkpatch.pl warning:
> "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1"
> 
> Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
> ---
>  drivers/staging/sm750fb/sm750.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index e1a892e3b3ad..105089b97bf5 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/errno.h>

Why did you pick this license for this file?

You need to be explicit about why you did what you did here, as this is
a legal-type thing you are claiming.  As a hint, look at the huge commit
that I made to the whole kernel tree that did much this same thing just
over a year ago.

thanks,

greg k-h

Re: [PATCH] staging: sm750fb: Add SPDX GPL-2.0 license identifier

[sanjana99reddy99]

[-- Attachment #1.1: Type: text/plain, Size: 1318 bytes --]



On Tuesday, April 2, 2019 at 11:20:03 AM UTC+5:30, gregkh wrote:
>
> On Tue, Apr 02, 2019 at 11:13:33AM +0530, Sanjana Sanikommu wrote: 
> > Add the SPDX GPL-2.0 license identifier to fix checkpatch.pl warning 
> > Issue found by checkpatch.pl warning: 
> > "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1" 
> > 
> > Signed-off-by: Sanjana Sanikommu <sanjana9...@gmail.com <javascript:>> 
> > --- 
> >  drivers/staging/sm750fb/sm750.c | 1 + 
> >  1 file changed, 1 insertion(+) 
> > 
> > diff --git a/drivers/staging/sm750fb/sm750.c 
> b/drivers/staging/sm750fb/sm750.c 
> > index e1a892e3b3ad..105089b97bf5 100644 
> > --- a/drivers/staging/sm750fb/sm750.c 
> > +++ b/drivers/staging/sm750fb/sm750.c 
> > @@ -1,3 +1,4 @@ 
> > +// SPDX-License-Identifier: GPL-2.0 
> >  #include <linux/kernel.h> 
> >  #include <linux/module.h> 
> >  #include <linux/errno.h> 
>
> Why did you pick this license for this file? 
>
> You need to be explicit about why you did what you did here, as this is 
> a legal-type thing you are claiming.  As a hint, look at the huge commit 
> that I made to the whole kernel tree that did much this same thing just 
> over a year ago. 
>

   I will drop the license. I would look to the change. Thank you for 
letting me 
   know.
   Sanjana 

>
> thanks, 
>
> greg k-h 
>

[-- Attachment #1.2: Type: text/html, Size: 2846 bytes --]